Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2911587rdh; Wed, 27 Sep 2023 17:36:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETT1zrswthuC6Hw7BwqV168s6+/2MDRBKh+3B01cRrU4/Kju71UdNBN+5xLsDdwjKNdpcY X-Received: by 2002:a05:6a20:7f9d:b0:12e:5f07:7ede with SMTP id d29-20020a056a207f9d00b0012e5f077edemr4431418pzj.41.1695861362336; Wed, 27 Sep 2023 17:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695861362; cv=none; d=google.com; s=arc-20160816; b=j+Wj/MwR2X2r48HytGatJWPUZ2lx97HYnZxh/P+QEEGdl0fa90Y4rmwtQZdMPGe/1z Fxlpytx+wnNm2boQWU24aSogmt+W5OB/EyxbFWSX/mPjTMhE9cZpJ8LIuCYRotbHyRC+ ux+9Dmjl1scG28r129Fe485e+oFgTlYk6cvnyU9B+zTu4cj7aO/Wlauu3i/yOT4xzm1b mH28M5SxkdB75g+RyXL1Iit8x5oa+40aV/Q022o8kS3cJ0tep1WHYOhM3AcRexriTaWX Mb/qSZMRkepyL76lzaIQuafi2Li1J0yL0EosZPyL2wiue2z8et7ENcUe1x2a2F9JGlpG 1Qcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=yTY333uB+lnx85QRK4UhGRcNGGIw7L3jD83kYOSz/mk=; fh=k7z308eIjdnfApHt+vb7yxZ0KmJ2QLHOHYvddnqQSfQ=; b=dyQWu9ffcZjcK9n4StY8k8hfrAYYo60GTsXDz2at436xxkybX+l/WnNRQhqQSRrGJP TrDlMsc2AwaiFKoipqTh+CuSou1mnKCdgTM1u2nwQtbvHF5uRUft08jIZAiaCAVIrrRh jOI4dnaJ7cxMOg/FCFPwHvV3O1YT7uGT5SZwHRJg+E4B79XjYA++XVCSmT+MbbTuZ4u2 isjE0wtPWnD/HNZ4P8KULjfI7ZMyA+xpPaHeb6PZ6MN2NQ3LjsnHWpnAILpWqscIgWFd B7PEzMDSpZCEQm1jmOVzn1jij9eS68Tz1SOoFncZwCM05FiJKBiNgiufWBDHesi51Dn1 QE1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Isgr6Kga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id l6-20020a17090a49c600b002776a60ea68si7923015pjm.1.2023.09.27.17.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 17:36:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Isgr6Kga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id CEE5E805000A; Wed, 27 Sep 2023 08:02:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232283AbjI0PBi (ORCPT + 99 others); Wed, 27 Sep 2023 11:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232169AbjI0PBe (ORCPT ); Wed, 27 Sep 2023 11:01:34 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C97F139 for ; Wed, 27 Sep 2023 08:01:32 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-691c05bc5aaso9892159b3a.2 for ; Wed, 27 Sep 2023 08:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1695826892; x=1696431692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=yTY333uB+lnx85QRK4UhGRcNGGIw7L3jD83kYOSz/mk=; b=Isgr6KgaqmmexAKyGkB8Hpoivf3+H2r2oB1yNE2ZON1oXyA7UU/kXuh8qBYeFFaeQU 4br+w0ziVpC8/buC3NCHU4jla3zb0Dhmzgi2aadrLxO9cOCAIMMgxairPzXDVv8La+Aw PQbtq9qXMYNwa0lcaekQHg76pP8zhHGTU7hc2QSxEdY9BtlJmdRIu8tcp3JNrjMsRYjh RMMV326M1bgXSr7JUTlTdiD4C+irrVVBANvCGdkifTM/2rwyHviNhDI0k+vZpCJbn3Z+ ONUVPDltKaqw2CpKPAzGu7ol35YSZkHUE/VcXzYEhG9IuB+Vtyu4SL0bEy0ltItn47qM YdhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695826892; x=1696431692; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yTY333uB+lnx85QRK4UhGRcNGGIw7L3jD83kYOSz/mk=; b=KAHEbq746PatExmUsL66JhM68Po0Kb23RbHKntcha+sI98hiFvrCMwfBrd37iXEWMw GBs2Gco31pv8W4lWt0twMFjWQTPqW52FxmLZI/sRslw41u3HSILFpPu9krC63Rvi7ivH iwseAdk8nWRHk71MP+J9oOSxOOQiHUjWLOlPa6DwZmqv6d4aOe13+KC5G4rd0ve6YzeB HlEMhPfvAGZs2DRDv+ti2rgKdfUwtFV5KPB1iCGlBIBH4aKJQuLm1/OeMIYCEIBQJtKX GcbAANCVsvnI3ou5o362Kzajpnqw5l3W5K1w+KlaYb/x1ZR0Wxpak+GyMO6FI2kf/+zw frMg== X-Gm-Message-State: AOJu0YyXL/pziwoqo4c9VR63be16mThKu5GhRWsRS0+RfLfzwXzm2w7s EcPgkLZPZff6b2+HOLmw9Lsglw== X-Received: by 2002:a05:6a20:3d0b:b0:134:4f86:7966 with SMTP id y11-20020a056a203d0b00b001344f867966mr2743151pzi.9.1695826891666; Wed, 27 Sep 2023 08:01:31 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id b19-20020aa78113000000b0069302c3c054sm4003815pfi.207.2023.09.27.08.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 08:01:31 -0700 (PDT) Date: Wed, 27 Sep 2023 08:01:31 -0700 (PDT) X-Google-Original-Date: Wed, 27 Sep 2023 08:01:29 PDT (-0700) Subject: Re: [PATCH v2 0/9] KVM RISC-V Conditional Operations In-Reply-To: <20230927-snowcap-stadium-2f6aeffac59e@spud> CC: apatel@ventanamicro.com, pbonzini@redhat.com, atishp@atishpatra.org, Paul Walmsley , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shuah@kernel.org, ajones@ventanamicro.com, mchitale@ventanamicro.com, devicetree@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org From: Palmer Dabbelt To: Conor Dooley Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 08:02:14 -0700 (PDT) On Wed, 27 Sep 2023 07:45:28 PDT (-0700), Conor Dooley wrote: > On Wed, Sep 27, 2023 at 07:54:49PM +0530, Anup Patel wrote: >> On Mon, Sep 25, 2023 at 9:07 PM Conor Dooley wrote: >> > >> > On Mon, Sep 25, 2023 at 04:33:15PM +0100, Conor Dooley wrote: >> > > On Mon, Sep 25, 2023 at 07:08:50PM +0530, Anup Patel wrote: >> > > > This series extends KVM RISC-V to allow Guest/VM discover and use >> > > > conditional operations related ISA extensions (namely XVentanaCondOps >> > > > and Zicond). >> > > > >> > > > To try these patches, use KVMTOOL from riscv_zbx_zicntr_smstateen_condops_v1 >> > > > branch at: https://github.com/avpatel/kvmtool.git >> > > > >> > > > These patches are based upon the latest riscv_kvm_queue and can also be >> > > > found in the riscv_kvm_condops_v2 branch at: >> > > > https://github.com/avpatel/linux.git >> > > > >> > > > Changes since v1: >> > > > - Rebased the series on riscv_kvm_queue >> > > > - Split PATCH1 and PATCH2 of v1 series into two patches >> > > > - Added separate test configs for XVentanaCondOps and Zicond in PATCH7 >> > > > of v1 series. >> > > > >> > > > Anup Patel (9): >> > > > dt-bindings: riscv: Add XVentanaCondOps extension entry >> > > > RISC-V: Detect XVentanaCondOps from ISA string >> > > > dt-bindings: riscv: Add Zicond extension entry >> > > > RISC-V: Detect Zicond from ISA string >> > > >> > > For these 4: >> > > Reviewed-by: Conor Dooley >> > >> > Actually, now that I think of it, I'm going to temporarily un-review this. >> > From patch-acceptance.rst: >> > | Additionally, the RISC-V specification allows implementers to create >> > | their own custom extensions. These custom extensions aren't required >> > | to go through any review or ratification process by the RISC-V >> > | Foundation. To avoid the maintenance complexity and potential >> > | performance impact of adding kernel code for implementor-specific >> > | RISC-V extensions, we'll only consider patches for extensions that either: >> > | >> > | - Have been officially frozen or ratified by the RISC-V Foundation, or >> > | - Have been implemented in hardware that is widely available, per standard >> > | Linux practice. >> > >> > The xventanacondops bits don't qualify under the first entry, and I >> > don't think they qualify under the second yet. Am I wrong? >> >> The Ventana Veyron V1 was announced in Dec 2022 at RISC-V summit >> followed by press releases: >> https://www.ventanamicro.com/ventana-introduces-veyron-worlds-first-data-center-class-risc-v-cpu-product-family/ >> https://www.embedded.com/ventana-reveals-risc-v-cpu-compute-chiplet-for-data-center/ >> https://www.prnewswire.com/news-releases/ventana-introduces-veyron-worlds-first-data-center-class-risc-v-cpu-product-family-301700985.html >> >> @Palmer if the above looks good to you then please ack PATCH1-to-4 > > These are announcements AFAICT & not an indication of "being implemented > in hardware that is widely available". The second two look to just be news articles quoting the first without any real new information, at least just from skimming them -- sorry if I missed something, though. The article says "SDK released with necessary software already ported to Veyron" and "Veyron V1 Development Platform available", but aside from quotes of the press release I can't find information on either of those (or anything VT1 related, as there were some naming ambiguities). Anup said during the call that they're still bringing up the chip and haven't started sampling yet, which usually means things are far from publicly availiable. I thought I heard him say that these press releases would say the chip is sampling 2H23, but I can't find anything in them about sampling. Anup also said it's availiable as IP and I remember something at Hot Chips talking about an example place and route for a VT1, which also sounds very much like a chip that's not availiable yet -- usually if there's a chip folks are a lot more concrete about that sort of thing. So is there you can point to about this chip actually being publicly availiable?