Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <dc1281bd-68ce-18f8-e4fe-d2d07535f047@intel.com>
Date:   Wed, 27 Sep 2023 11:30:57 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 01/10] x86/resctrl: Add multiple tasks to the resctrl
 group at once
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-2-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915224227.1336967-2-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnZQdklFbTBMMWJLenpQcmRFOXZyWG9lTkVkWXluZEZUTHdVemI2bXBUaFV5?=
 =?utf-8?B?YnpXMHoyTGp0TEg0aWlHOVE2TnJPRFc2ay9oc1lZTGNNdXo2aWk5RHYxaXk1?=
 =?utf-8?B?emFYZnVERjgvTUVkVTNnY3NoTWoyUEJtOWhSL1UrdDhKZXFjRjFOZjN2L00r?=
 =?utf-8?B?eDVCdzV3SWI2dHl3ZkN3dnVmK1hMM2pNejVYTy8rZ0ozYThsSzJKR0xyZzNu?=
 =?utf-8?B?S1pvMWNpSnBUMGV5QnhhYjFHN3g3Z1lvV2tQL3NhQlNDcnVWOXNXWm1xMUww?=
 =?utf-8?B?OVFmbzk0R1gyaGwrNkR6dTV6UEpDNFZpVkJueTNyc1RnWTRpWndldXZZbHhq?=
 =?utf-8?B?cWY1SksvKzhBK2YwUjhzRnhLUCtqY2hHd1dyTU5aaHFkUXhJdVJZQVVaL1ZO?=
 =?utf-8?B?S0JUZVZnRDRmQjMyMW5icGY3S1UxMUNPOXduWGt1bWFRM1pCb0dZY2Z5M1ZS?=
 =?utf-8?B?akJMSEdZZW5nZGhuYjlwMnJhWXFGU2VBOGFsbE1aMk9va2RVazNtaXdRSG43?=
 =?utf-8?B?V1Y3NmR2czRhNTV1TzMyVGU4U0VBN3hXa1pVdWNaNjJ6NFFvaEM5SEY5RnlC?=
 =?utf-8?B?OU1hRkFFWS8raURKTUJKODVlSHZmN1EyaEE2Sk1IN2d3dkVmdmxxVEFuSC8w?=
 =?utf-8?B?RWppOGREUGxpTFF6b2ZvTXhmZThGUnk1aUYvV2tXSjQra2hnazRZaFdZTUFD?=
 =?utf-8?B?U3ZGRjBxa01aNXI0LzU1NE1SWXFvaXp2WExleXpheUoxYXNaQTEyQ1JnTjYy?=
 =?utf-8?B?eWVHZ2lwcVArU2dSUjJsaTNpRDJRMVNIOGczZkovQlY4SjNsd3hNU0JJcGRx?=
 =?utf-8?B?QzhwQXhBSkRBTktlQlpMMHEvc3hVdUpNZkhDSE9Cdm1IRDA5Z3V0VklNNlpM?=
 =?utf-8?B?WXp5Sjg2cDUzcVdUckhUejVIRXFPZ0JMekYxYjlZRWlmaDBkdUIyTVpRUHQy?=
 =?utf-8?B?ektWRW5SWG9PVkplcGRVNlRPMVhWTndBeFJ6YlR5eWFBbnFoSUtoaFFzaTQ5?=
 =?utf-8?B?Z3lTcTc2QXpIUmpRSGtMcmtoUXJ2ZnV0R3MvRm8xRWNCYXpWV2FBbEFoVDN5?=
 =?utf-8?B?c0dpK2lBeVRzOXc1UzE1MnlQZVNWZUQ2UzFyNCtDdWJrYnlNZ2NFMm94VzdH?=
 =?utf-8?B?dGFFbFNnZ2xGT1ZTcEVObWJhVWhaUThSc3BET1JOM3UrWHl4K3hDTVZWQUhD?=
 =?utf-8?B?eUwxMWlpLzhjL3MwTDVpN2xzaW9tQ1dHcEEwcndiS3pFR2Myalg3Tkd3cys3?=
 =?utf-8?B?ekYrcFFVM1hVdFoyVmtoMlNIRGFiclVtOEpkSGZldHB6V21ZVzF1K3dGT2U4?=
 =?utf-8?B?ekVxcVlRRFZycHBER0plcjNoNHJ4MlhEeDV6azYyb1hpNVo0N1V4RWxCMXJL?=
 =?utf-8?B?aXd0SVk2RElDTzQ1MFdLdjdYem0vSWZycWhVc1hLSkJXaEg0OHFOREtNSjJP?=
 =?utf-8?B?QzNBTC9VbFNsQmROTTJMdlc5MW5EbDRnZzI1cThWZkE2T2VKS2lBUU4vNEZx?=
 =?utf-8?B?QWRTV01vVG5McTdVekVUR0dncDJvME5Udk9ucTFwcWxoalg1dDhKT3I0dDRO?=
 =?utf-8?B?M1NCd1YyTTJhT1IxZkgwbkhDQm9zY21OMmNXQnEyWlJpRTl6Y3E1SFVsc25y?=
 =?utf-8?B?UkVoOFgyQWVMU0JXV1ZDcWNnZGlQYUUzbUdMWXRGc3RPM001VFk1S0dSL3gv?=
 =?utf-8?B?cXMyZ3VsSVJtbTR0MFphK05rRFovQ2RsRG5PL3NFdDVYNkJYRDNTKzhTT05Z?=
 =?utf-8?B?Q0hxcFVTb2c3T2pMNHR1U2EyWXgyUERHcFVaMUYyRUErUnkvdGRvdEJvTENF?=
 =?utf-8?B?WWp3YVFxeVhidmZtMVhFUitPc0Zid0NnZjFtRW84czFRWHBMSURWZUc2MUg5?=
 =?utf-8?B?Zm5ic1dzVG4yQWxqNmdsL2IwNExzc2dzQW5FbUFDeW5zOXhab2pRTVpIN0Ez?=
 =?utf-8?B?SFNFemtkRDJ3TE14dmNhZW05WDN5M0dkWTQ4dzBmdnc2UU9FWlRKOStjbTJW?=
 =?utf-8?B?bUx4T0RPbXBBK2FuSWZLNFBGUWJtNzRpSlo0NjZKV25xUDZiVlBHUW9QN3FH?=
 =?utf-8?B?dDllejVQTDlTTUdBVDk0dnFGbHlkUFQ2bStZbkcrczZqZ0VtWWZYc0FzVXhM?=
 =?utf-8?B?dUNhdm8ya2pHQit4bXliQlpWckZqMjh1MVdZUzBBdG5XZUpGSXZGRnQ2UjdT?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1018301a-4885-495f-91c5-08dbbf87e663
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:31:01.2374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XAn/x9JdpYG1WzbfgMMh65wNCaYM4k9eg43nhmsGKeU+JTRWSKHU9S3Hhd3nhTjhYCI7Mtni3/lT6DnTstDayMlk57fiEOYkOl6tK+Kl2EY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5411
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 11:32:13 -0700 (PDT)

Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
> The resctrl task assignment for monitor or control group needs to be
> done one at a time. For example:
> 
>   $mount -t resctrl resctrl /sys/fs/resctrl/
>   $mkdir /sys/fs/resctrl/ctrl_grp1
>   $echo 123 > /sys/fs/resctrl/ctrl_grp1/tasks
>   $echo 456 > /sys/fs/resctrl/ctrl_grp1/tasks
>   $echo 789 > /sys/fs/resctrl/ctrl_grp1/tasks
> 
> This is not user-friendly when dealing with hundreds of tasks.
> 
> Support multiple task assignment in one command with tasks ids separated
> by commas. For example:
>   $echo 123,456,789 > /sys/fs/resctrl/ctrl_grp1/tasks
> 
> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>

x86 area aims to have a uniform view of commit tags.
Please review the "Ordering of commit tags" section within
Documentation/process/maintainer-tip.rst and apply that
custom to this whole series.

Reinette