Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <5305cedf-80e7-aa87-1566-d1cc102c5cf5@intel.com>
Date:   Wed, 27 Sep 2023 11:35:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 10/10] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-11-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915224227.1336967-11-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU40MFdpV3FNSVBsRVdPNG9JaThuNkt6Vys2MFc2OGhwOGN4TWxLaXkySmVp?=
 =?utf-8?B?NFBQd3FIdGZWZDVhSEtnQ0J1SGwySVlHZWpubzZCMFl4d3o5OEd1c2dIazkr?=
 =?utf-8?B?Y0tzVzZxb1lMQkJyTWZPWjdWb09YQ055MHl4NkY0eU8wcnhkM291eGROL1Mr?=
 =?utf-8?B?bjNleFlqUFB4SzUxOEE1M0JlMktuNEJzQUlXTDRwS3dnVWVPMGYyMlFzNjdk?=
 =?utf-8?B?MmZ0U2VwQTYwU2dWNGVTbXBXdVNBNDFKTElrbTNmSDlacVNZQVRmcGZ6QXdy?=
 =?utf-8?B?aldDajk1VDJzTjNmbCtLOXFRWG1FcGdjK0pneGJqUHdFdHYyaHVMbE92a0Fr?=
 =?utf-8?B?dWJWNG9WYllHa3p5L0dxUjdMWUwvM2FlTkhxUDBYU2QrOTlFN3Jwa0dHSnlT?=
 =?utf-8?B?QjZYb21qNDdQeTk2WkxGRy9EOVM4ak96bzZSY1dOR2c1ejk0ZWdLWG5SRzBZ?=
 =?utf-8?B?S1haS2tEdFM0ampGYkcycjhvdUN2c1ZnQ29LbWcvbGV2NndpWTVnRmpsUFIr?=
 =?utf-8?B?NDI2cklKWkdNQ0lvL1ZsQ1l6SlBWVGJBc2dCUDhnR0RvNlBIQ1VOK1ZUNXdT?=
 =?utf-8?B?bmpibXVMR1VBaU9mb2FKWnhtZDMybjc4TTBUb3NCaXZEYWJkejB1eUtTeFhw?=
 =?utf-8?B?MEpJUFJCc3JpRzdicDZpRGlsdnVjRHNQV0dxeWVoN2NwUzhSRnV6SEc2Wkdj?=
 =?utf-8?B?amRXQmZjamJlY0s1RWgxbVpKVXNCREMydmViUHcydW9jN0Zwek94NGVUZ0xZ?=
 =?utf-8?B?eFEwcDFqdDREUjl5TFhzc3kvSytPdnROVWhIamd1cjRpZzZLaDV6SXJ4NlVT?=
 =?utf-8?B?cFVpRTJKemJIblhTK0ZVdzhKODdtV1pNZUs0VGZEUzNCUzFWZDdMR0d1bHF6?=
 =?utf-8?B?U3FTZGt5TmlEdjdIQTRWZXJZTFEreUk3SDJxUmtFbmZnZ2lqYUh0eHhqZWhQ?=
 =?utf-8?B?MnQrcDgvc0NJaVZ2d3gzcUd4N1FobjlWUXY2QWM4aXgzMGxCbHVoeTREc1Uv?=
 =?utf-8?B?L2R0YXk5eFVsZGNkM2tTRWlwL0d1dm0wRmlwNjZackpZVHFra29IMm52Vng5?=
 =?utf-8?B?KzlObjljTUxaRjVQTUZDY3JxRU45YnM3R09yMUZBazIrWFA5NHM1S1lDNGY2?=
 =?utf-8?B?TVREUTNpTDZGMy9ab3hndDlHVkh6Y29kV3VqOVhRWVRsc3hiTUZsRXNrMVBn?=
 =?utf-8?B?VmowaDVCcmxETVI2Z1l0c25NblVOWFZTbXlqMzlCU3VVdXZIeUF4U2ZJMGlB?=
 =?utf-8?B?Z3h6ZWxVVW9uYVVjU1hjSEVuYlB1RFgrc1gwTCs5aE9zamFTOWc0eGpwbWMy?=
 =?utf-8?B?RWlMVGtJWTBSVkNlVTFwVVpVWWVRczEyTnhEenFPaERudHRZcGc1TFplYjdK?=
 =?utf-8?B?Mk1mVnNaM2FOTnJKb00xQ25RTjNqR1FyN2hNSk5LSXdra294dHNGVTdwTW1s?=
 =?utf-8?B?TmtqZE9ma1JlNTFBeGJReTBSaFRVdjhqL1ZmNncvV0U0cXV2Z0E2RllxNkVG?=
 =?utf-8?B?TU5tY2NPN1IxeE5oRVlvcmZWREgxbndsMTVrREVxaUs0L0tBNFNKNVIrK09x?=
 =?utf-8?B?aklCdk9kZk9zek80Ui9aeENOdVhYd21HdWZWMWg1K0dCemQvYVBNQ09ObG5M?=
 =?utf-8?B?VTg5TG92UDJHelluZjVoODhlcFFkenlOZTc4aENxcUx1VVVMSFFqU0l0b0Fy?=
 =?utf-8?B?THZWOGU0N1Q0R0hQRXlpbWNLb2R2NUx4Z0xPQzVUckJjZnpVTm84Si9NU3Rr?=
 =?utf-8?B?TDFSNC9HbkV4WnMxK2UzOUpYUDlyVkVVN2ZFRzZpYVZJQjdnRTFqUnQrdW5I?=
 =?utf-8?B?TkFnRjlDRHU3d3VXYjNPanFaTHNWa0NYdklIeEFzTGw2ZkhkdE9QN3JUQVpm?=
 =?utf-8?B?OURpTGN3ZVV3U0x1bDN5S0R3dlF0aFJYVjVxOFFnSHMwVll4clNuSnZpYjE0?=
 =?utf-8?B?dlVjOTR3S2E0ZkV0Yzk2bmdJNnlVSVBCK2o2akU3bmgxYkJHVHVWanVQNzFo?=
 =?utf-8?B?VE1zRmV0UW92NUcvaGJQTFUvcDc4MVpMd2ZaYU04UHRKYmFrYnE0VlpVVGZq?=
 =?utf-8?B?bXFlL3lWWnIrSFJYaE5vNkpTV3NYYTNVNzVld0F6MklNeEJIYzFyclo4U3dR?=
 =?utf-8?B?VlgwS1QxbVhmNTZJZEhaT3lQUG1sVTZEZkJ0d3E0SEx6cVVtODFwTHBBdU5z?=
 =?utf-8?B?alE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99b868d3-586c-4755-3503-08dbbf887fc9
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:35:18.5562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aIi7OGJi+XgB8zKgNyr4CgHNf8I55SZy9F7b9h6F+nbdXBOW3muSjUHhBac2bGaGbgCGqrW4yhfVeE7y+4G8SefRgnlk0pr9xMQJZSBs6bA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5240
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 11:35:54 -0700 (PDT)

Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
> In x86, hardware uses RMID to identify a monitoring group. When a user
> creates a monitor group these details are not visible. These details
> can help resctrl debugging.
> 
> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
> Users can see these details when resctrl is mounted with "-o debug" option.
> 
> Other architectures do not use "RMID". Use the name mon_hw_id to refer
> to "RMID" in an effort to keep the naming generic.
> 
> For example:
>  $cat /sys/fs/resctrl/mon_groups/mon_grp1/mon_hw_id
>  3
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette