Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <635364f6-fb75-b9b3-d230-78eb62d77b9c@intel.com>
Date:   Wed, 27 Sep 2023 15:20:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 01/10] x86/resctrl: Add multiple tasks to the resctrl
 group at once
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-2-babu.moger@amd.com>
 <dc1281bd-68ce-18f8-e4fe-d2d07535f047@intel.com>
 <c58a017d-81ff-a797-5b3c-af5a016319bb@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c58a017d-81ff-a797-5b3c-af5a016319bb@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUx1TUdNcUhyalRFUll0R2dhQUoxTWgvRCs2UHhyVzY3WDU1UENZb1ljNXI3?=
 =?utf-8?B?WlV4N0EzYmRZemQyY3NJa0VXU1FFTzZ1V0wwRFR5RmVMNk1jT1gyRDBpMlB5?=
 =?utf-8?B?Vjg2OWNQMUo5d09LY09Ka3V3dUU2dlpXR0cxckhFVDV5TUh6WGtueG1aTDRh?=
 =?utf-8?B?QWxKSWRZZS9IK1F4YUlOcTFkVjBGZ2FCakIwWmdGOUNLM3dyY1BraU5vY2VB?=
 =?utf-8?B?WDhMUWFLK0RjdFoxVVBXSDltU054V3NZT3FlSk5UZGVzT3F5cVNSZTlQbHpL?=
 =?utf-8?B?VFpMa3dIMlRRTzZUek9RTWtRdks0ZXRQMnBUTVRGaTdOcUtWUkY0d2FMZEE5?=
 =?utf-8?B?UjMzU2QwMUJUaWJJS2dJWDdOL1JaeFpsOTZxZVFFdmp3SHdCODkycDYwQlFH?=
 =?utf-8?B?bGNmVGx0MnVjSm1pNjFKMUZldHdza3cyKy9IRlNJS0U4dkdBd3lyVVp1Y2ly?=
 =?utf-8?B?MHJaL3BEaGJmS3l1WHRRWVlvRjdGcTV3Zll6VTVVcmM0eno4UW1LcUxCb0pJ?=
 =?utf-8?B?MDdtNG5XREdTSEMxdXJvbXdtdFowckJscWFYcjhzMGZIVEowSmFmRllMbkNU?=
 =?utf-8?B?MUpueGloZkFTRzJNaDFtVXFVNUxqeGZHVGhYY1FUSDBtZ3VJY2J2UzRzY0Vl?=
 =?utf-8?B?cEVRQUZvYVVZVmI1dzhXOXZYYjRONU5pdHJWdUszVTFYWW9NVXFyY1JtRDkx?=
 =?utf-8?B?V3NCQiswVjJIU0ZpR0h5MXNOdURESTF2eDk4RDlJL0dqZmwvbzhROUtjOS9E?=
 =?utf-8?B?bEFObE5lYnRzK1R4WTc1aEE3VVZLY0l1Z0kzeHUzekNVU1NxUjNzbmJiNWt2?=
 =?utf-8?B?bWFxaU1RaEw4UWhqRVlIS3A3VVdVYUF1WmZTR1kwekwxcDU2b1VlaDhxZUhI?=
 =?utf-8?B?QUNVZlV3MUdTYVlsSllQQW0wTUdYTnVpMXVFd2Jsa2JsaGN3NVp5cjVrRXdw?=
 =?utf-8?B?cXJKa1hjQSs5Q0o2TUVPbEJQQnF5TlplaS94ZWozRjVMUmdsUkk5eEFtTDNB?=
 =?utf-8?B?VXZib1BRdjJSbTFjd0xQWmFZRG5mNzI5ZXIzTDU0M1ZBK1Q2Z3c1N1VES1E2?=
 =?utf-8?B?c1RRQUs1S1R6c3VrUjduYzM5U2dUeGo2UkdMVGlqalJEQ2dBZjdjWE8xMEE2?=
 =?utf-8?B?MTZBNlZaYkJpMnMxRVBJQ1R2ZWlHRXp4Tk5wSHJQa1dPSUJzOWVoaDh5M2x1?=
 =?utf-8?B?Sml1RGlJL2ExUEdpLzlzYkdCdnVlTlF1RGU3UVlqOXk4MWNjam5QZE1RdzNq?=
 =?utf-8?B?N2RHbGlDZktwQjJYWmtKTkh4QUdGNkh4NThYTE9pK1RyOFN6R0FFY2ttUU84?=
 =?utf-8?B?TW5ocDVEOXV4NCtCVVlNKzF5U0xQTnp5UlVKb2hHY0trQ0FzOENwQmdXTkEx?=
 =?utf-8?B?WTcyNllhZHU1U2Y5c2ZicG9GMzhVU3lmU29SNlZBRDhTUnJkZm5wd0pXQjYy?=
 =?utf-8?B?L3U1ZGlXbTdQWDFXQ1VLenlYVGo0SEx6SlZJby9FTk9GYzJwd0s0bllZQTFj?=
 =?utf-8?B?WFNGV0VJalRSSExhSDBtVldKaFJUaFlyOHJZaThIWXdlUXpvRXh3ZE1XaElt?=
 =?utf-8?B?RUFpWXNjZzgyYzM0V2pweGQxbDlVUGQrdlp3ZEhEQWxXbUhWWXVTbnVRVDdK?=
 =?utf-8?B?NW16VGJwNURGQXFwbWhEaUtlZklJME5nYWI2RlNqZTFSVUl3LzBhYWg2eStO?=
 =?utf-8?B?ZzRYa1ZKS1RuNVFkL2VtR1gwVjNqUFB5aEN0ajR2Q3F0ZnFSZ003WlZPaEc0?=
 =?utf-8?B?N2M3RkJPZ1h2NG8vZEZOQlRtaFp0S0lJMkJONStuSnBZWXBRL0puZHE0enE0?=
 =?utf-8?B?NUNIczlkeEdvU3ZwcUFPSU5sRDJRbTJ6VCtSVnd1UkI3b1gxY3M5RlRGQjZ3?=
 =?utf-8?B?QWt3YmpwZU1CZzhQcitndXlCcHYvSFBuamFTSFBlMzhVZFhOUktNZW9wMVA5?=
 =?utf-8?B?M3pYUm5XMGxycnk4WERsWnlFemVmcS9VZEhVV2g2V3h0R1hTRmlOelNBb0lQ?=
 =?utf-8?B?U2hWMnpLNFdmdWhPSUphOUFBNWhlWnRnbFZZR1pkZG82SDRRa3JqeVh0bnpk?=
 =?utf-8?B?eDhVeDhOVmRXWHlRaFY0c1BsVnRBMlV1STBrVHY2dUk0eXhqVlk2aDl6RXpB?=
 =?utf-8?B?Yk9xV1B1bGJaaG5aSXArcXViMkpzeTBLdTN0cHdyRWFnazJ6RllURXk1dWxC?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 211a7295-bfcb-4fea-0233-08dbbfa7eed7
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 22:20:19.2008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wjL4HWCSeqqlZr9t1G6WA4pMQuv8gCm1uBLBjeRfdd85KiXGmKy4KhnNe3JVs+cnv0pbtw00BjSYe0JioeSOV8Kbr68D6pW8DQ6vSO9qAMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8225
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 15:20:46 -0700 (PDT)

Hi Babu,

On 9/27/2023 2:44 PM, Moger, Babu wrote:
> On 9/27/2023 1:30 PM, Reinette Chatre wrote:
>> On 9/15/2023 3:42 PM, Babu Moger wrote:
>>> The resctrl task assignment for monitor or control group needs to be
>>> done one at a time. For example:
>>>
>>>    $mount -t resctrl resctrl /sys/fs/resctrl/
>>>    $mkdir /sys/fs/resctrl/ctrl_grp1
>>>    $echo 123 > /sys/fs/resctrl/ctrl_grp1/tasks
>>>    $echo 456 > /sys/fs/resctrl/ctrl_grp1/tasks
>>>    $echo 789 > /sys/fs/resctrl/ctrl_grp1/tasks
>>>
>>> This is not user-friendly when dealing with hundreds of tasks.
>>>
>>> Support multiple task assignment in one command with tasks ids separated
>>> by commas. For example:
>>>    $echo 123,456,789 > /sys/fs/resctrl/ctrl_grp1/tasks
>>>
>>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> x86 area aims to have a uniform view of commit tags.
>> Please review the "Ordering of commit tags" section within
>> Documentation/process/maintainer-tip.rst and apply that
>> custom to this whole series.
> 
> After reading it, it appears this should be the order. starting with Author SOB. Hope this is what you meant.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> 

This matches my interpretation.

Reinette