Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <7c6dcc06-0b6c-a346-c7ff-60da3fe59fbc@amd.com>
Date:   Wed, 27 Sep 2023 16:34:00 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v10 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Babu Moger <babu.moger@amd.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-10-babu.moger@amd.com>
 <031ef099-a7d2-37ce-eb97-c4f7d76a12c4@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <031ef099-a7d2-37ce-eb97-c4f7d76a12c4@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDRJYm14Vm10ZXN3S2xJaTJ5V1ArdjdnNGxPUE1oY1RPb2srVXJ3Q2RnZWd2?=
 =?utf-8?B?ZVA3SlRYczRJZGladWhtU2FQc2lJQkc3RlREYXBPYUo5dmhLMkZ4LzdnemNu?=
 =?utf-8?B?TWhtRjJHMTFaclVXTlRhd1d2WllCcVZOcXBleUZ0TTBKOG9RVUxyUlg1RU9j?=
 =?utf-8?B?WWNRejBIODNLZi94a1pqWVVadHJqRDlSUk5tRVRMc1FJZlc5VTNCS2RPVzFR?=
 =?utf-8?B?MWxyY3o2aG1DOU5vamI3amw0QWJqWUwveHFxcUpqRVo5cjFOcWU2R1JJcklk?=
 =?utf-8?B?SGF4SmxkNTNKUkszRjhpc3BFeFlEMlZENEZPbG1STG1sYk1vWjFzTnhoRTJa?=
 =?utf-8?B?SnpMY05vdnlWVVRNOVljaTZvRXBkY0p0bHRLWnQxRXIxdlloZTdXc1NsZHdx?=
 =?utf-8?B?RFQ4Smc3RHRsQzVNTHZCenlMMzZ3M0U3dzh5MG5oeVV6QndVUE5ldmRObDZx?=
 =?utf-8?B?TUE3NlM0cy9sckowNGpPeTFhMjRidzZ5bFNrR3NpdjNuQXlCelRMV2JqTStE?=
 =?utf-8?B?Q0x0K3BhcUJiRUxKUmhkdUQ4RncrTlBkYnVrNFNFa3h0NFdBR3VGb0pPZ3dk?=
 =?utf-8?B?Snh3Q1YxMG9ZNFk5LzEzUVZzZGRPVjVZaDAvZm5LaVNHRk9KUGNlMGprWHNT?=
 =?utf-8?B?OEovaDVnbytJTEptcFNhTExxOGYwSk5VcHZmeFh6UkFkdXpNdmt1NWsvSURO?=
 =?utf-8?B?ZUxZYWhxQytkYUxsb2QyWGpaUy9kRVRneHAzbEhpOVB1ZTZKTkZ5RlFJcU92?=
 =?utf-8?B?L0dEZ1I0K3RxT0NqSTVTSitUSTUxNVNtT3VxWnVtL0tHdWNPZDQ2TE4yOEdQ?=
 =?utf-8?B?amNHOFhhNnYvVzZRRXBNbHViM1kzRmpIWjVqbWVJNGhqa1ZXZ09KQzNnMXhG?=
 =?utf-8?B?cjF6WW8yR3ZHR2pwRUFxTUVzbDFBTEFVOFhmV2xtL2RBdkpkdHU1eVNYWEtT?=
 =?utf-8?B?S2NkME53MTZvOWJ2SzRyWEZHNzJZLzMybWJKTFRoQ05ldzliUDJJNHlJWm1w?=
 =?utf-8?B?TkhjRy83U041ZWtMaU1SWjcrWEpRNG9jaDRMTnBlTHI2dkF5UTZsaHFsdVR2?=
 =?utf-8?B?VHlvNFB4NWxjL2VJRHFOQ2JqVVV0OUVXaUkvd3VsdVg3RXhIcjNYSHYxMGxR?=
 =?utf-8?B?b1FQRDZDUlRRVmNpRE1aQ2pKcjRHL3NDSzZic1JqZTBkK1h0LzRTNlJtdnJs?=
 =?utf-8?B?ZWorY3dGRDV5VXZxVGhOZ09iMm00cU5CN0ZGVzY2Zm5FdDYyNmpTRGk4RGRB?=
 =?utf-8?B?bHI2c3pUQzRyMlFFOE1QemkyTmIrZDZYSnhlMDZIL0IwN0cyMUpncnZsb2Jq?=
 =?utf-8?B?NWc3Ymp2d3N4a2N4ME9WbkFERFN3cW0xNDQyZC9ZQll3VUIyQ29XeDlhWFNW?=
 =?utf-8?B?ZWV6aXBOTmdrWVhveDg4VmhVRUs4SnFIZ1d2ZmJCU3RLN2ZjcVQxbmpHVjdG?=
 =?utf-8?B?Qk9hUXU1Y09VdjZOSDdWVklwU1BMZWFEQWJBb2tBU0wzRHViVHJhcGhKQnNM?=
 =?utf-8?B?UWJHalluYTZjaDBOWXJNTXpBY0UwNXpoVTF2c1BaTis4aEhvYWVsYkcvbzY2?=
 =?utf-8?B?VjFvQlpWMXpYSEdLNjg4cnpIMEJBam1jSG03aHhMUDFPTTlTY1RjeXJXVklM?=
 =?utf-8?B?cGFHRzkybm9WLzExZjRYdHNHRXYxQ3c4bmpJN2E4YmpXeFdMSUxhbFEyREw3?=
 =?utf-8?B?QXJkYUZYakRDZ2VXN0hlbmpnNUdOTzNLbzZaNCs3ZTg0SWNEckloREtObndi?=
 =?utf-8?B?MzdWNTBoeFBsaGRYU3U0dng5RVpHakJCS0pkMnUzR0cvTVJRZUpMbVFVWFVq?=
 =?utf-8?B?YWwrWEZaZ0d2MW05eU8wZEp2a21UUDNheStGZ2VBb3VMQ0YrNUYvRXByNkdE?=
 =?utf-8?B?MXJjbnJQOXd4K2dxYmJXTmh0czVDTHVvWGMrbElVZEdjUW1UaHFjTkswaEpv?=
 =?utf-8?B?emM5ZWVmSzZLeFNPOVRxRHM2TnRCRkpSYlhiaUhvUm90b04yVnZlMGVLUm9H?=
 =?utf-8?B?UE9LWWtUSGMyUVExODY4a1VPZkpPRzFJTGpnUkVrT3ZVWTV1VE9kakxKdTZQ?=
 =?utf-8?B?YS9lQmQzNDhHNis4S3J4RUtZN0xwYjJ4WDh1b0Q2NzJmWjZhNUlCMkZQTHpI?=
 =?utf-8?Q?/6BE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2101ec56-2e03-4540-3ea8-08dbbfa17980
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 21:34:05.3792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MKhTIRUBtKGtg4qmzWg8s5PJQzwGxnD5fZQ+w8QHktMyncRLmo4zzlk/kE1SRQLi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7524
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 14:34:22 -0700 (PDT)

Hi Reinette,

On 9/27/2023 1:34 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/15/2023 3:42 PM, Babu Moger wrote:
>> There are 3 types resctrl root files.
> Considering patch #4, should this be "base"?
Sure.
>
>> 1. RFTYPE_BASE : Files common for both MON and CTRL groups
>> 2. RFTYPE_BASE | RFTYPE_CTRL : Files only for CTRL groups
> If (1) is accurate then I cannot see how (2) can be accurate.

How about ?

2. RFTYPE_BASE | RFTYPE_CTRL : Files for the CTRL groups

>
>> 3. RFTYPE_BASE | RFTYPE_MON : Files only for MON groups
> Same here.

How bout?

3. RFTYPE_BASE | RFTYPE_MON : Files for the MON groups

>
>> Files only for the MON groups are not supported now. Add the
>> support to create these files.
> This is not accurate. Files "only for the MON groups" are
> actually the only monitor files that *are* supported. The
> problem being fixed here is that monitor files are
> not supported for CTRL_MON groups.
>
> I made an attempt at rewriting this commit message but I am
> doing it quite quickly so please do improve it:
>
> 	Files unique to monitoring groups have the
> 	RFTYPE_MON flag. When a new monitoring group is created
> 	the resctrl files with flags RFTYPE_BASE (files common
> 	to all resource groups) and RFTYPE_MON (files unique
> 	to monitoring groups) are created to support interacting with
> 	the new monitoring group.
>
> 	A resource group can support both monitoring and control,
> 	also termed a CTRL_MON resource group. CTRL_MON groups should
> 	get both monitoring and control resctrl files but that
> 	is not the case. Only the RFTYPE_BASE and RFTYPE_CTRL files
> 	are created for	CTRL_MON groups. This is not a problem
> 	because there are no monitoring specific files with the
> 	RFTYPE_MON flag associated with resource groups.
>
> 	A later patch introduces the first RFTYPE_MON file for
> 	resource groups so fix resctrl file creation for CTRL_MON
> 	groups to ensure that monitoring files,	those with the
> 	RFTYPE_MON flag, are also created.

Looks good with slight change(only last para. Rest looks good). Just 
removed the "fix".

A later patch introduces the first RFTYPE_MON file for
resource groups. Add the changes to create the files for CTRL_MON
groups to ensure that monitoring files,	those with the RFTYPE_MON flag,
are also created.


>   
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
> I only have feedback about the changelog. The patch looks good to me.

Thanks

Babu