Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20230920223242.3425775-1-yang@os.amperecomputing.com>
 <20230925084840.af05fefd19a101c71308a8cf@linux-foundation.org> <90fc0e8d-f378-4d6f-5f52-c14583200a2e@os.amperecomputing.com>
In-Reply-To: <90fc0e8d-f378-4d6f-5f52-c14583200a2e@os.amperecomputing.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Wed, 27 Sep 2023 14:39:21 -0700
Message-ID: <CAJuCfpExMWXHfZjgZ=UKf4k=zxrNOLx2R-a_wQdZ3O_+JTOq4w@mail.gmail.com>
Subject: Re: [PATCH] mm: mempolicy: keep VMA walk if both MPOL_MF_STRICT and
 MPOL_MF_MOVE are specified
To:     Yang Shi <yang@os.amperecomputing.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, hughd@google.com,
        willy@infradead.org, mhocko@suse.com, vbabka@suse.cz,
        osalvador@suse.de, aquini@redhat.com, kirill@shutemov.name,
        rientjes@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 25, 2023 at 10:16=E2=80=AFAM Yang Shi <yang@os.amperecomputing.=
com> wrote:
>
>
>
> On 9/25/23 8:48 AM, Andrew Morton wrote:
> > On Wed, 20 Sep 2023 15:32:42 -0700 Yang Shi <yang@os.amperecomputing.co=
m> wrote:
> >
> >> When calling mbind() with MPOL_MF_{MOVE|MOVEALL} | MPOL_MF_STRICT,
> >> kernel should attempt to migrate all existing pages, and return -EIO i=
f
> >> there is misplaced or unmovable page.  Then commit 6f4576e3687b
> >> ("mempolicy: apply page table walker on queue_pages_range()") messed u=
p
> >> the return value and didn't break VMA scan early ianymore when MPOL_MF=
_STRICT
> >> alone.  The return value problem was fixed by commit a7f40cfe3b7a
> >> ("mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is speci=
fied"),
> >> but it broke the VMA walk early if unmovable page is met, it may cause=
 some
> >> pages are not migrated as expected.
> > So I'm thinking that a7f40cfe3b7a is the suitable Fixes: target?
>
> Yes, thanks. My follow-up email also added this.
>
> >
> >> The code should conceptually do:
> >>
> >>   if (MPOL_MF_MOVE|MOVEALL)
> >>       scan all vmas
> >>       try to migrate the existing pages
> >>       return success
> >>   else if (MPOL_MF_MOVE* | MPOL_MF_STRICT)
> >>       scan all vmas
> >>       try to migrate the existing pages
> >>       return -EIO if unmovable or migration failed
> >>   else /* MPOL_MF_STRICT alone */
> >>       break early if meets unmovable and don't call mbind_range() at a=
ll
> >>   else /* none of those flags */
> >>       check the ranges in test_walk, EFAULT without mbind_range() if d=
iscontig.

With this change I think my temporary fix at
https://lore.kernel.org/all/20230918211608.3580629-1-surenb@google.com/
can be removed because we either scan all vmas (which means we locked
them all) or we break early and do not call mbind_range() at all (in
which case we don't need vmas to be locked).

> >>
> >> Fixed the behavior.
> >>
>