Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20230923093037.961232-1-yangjihong1@huawei.com>
In-Reply-To: <20230923093037.961232-1-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 27 Sep 2023 20:55:28 -0700
Message-ID: <CAM9d7cg=k4sLLgA-EODxxRCg1EQjvWWaNOpm=VMRWokmqxiuew@mail.gmail.com>
Subject: Re: [PATCH 0/4] perf bench messaging: Kill child processes when exit
 abnormally in process mode
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, Sep 23, 2023 at 2:32 AM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> If perf bench messaging in process mode exits abnormally, the forked child
> processes does not exit.
>
> The test result is as follows:
>
>   # perf bench sched messaging -l 1000000 -g 1 &
>   [4] 553
>   # Running 'sched/messaging' benchmark:
>   # kill -15 533
>   # ps -ef | grep perf
>   root         425     371  0 09:11 pts/0    00:00:00 perf bench sched messaging -l 1000000 -g 1
>   root         426     425 17 09:11 pts/0    00:01:56 perf bench sched messaging -l 1000000 -g 1
>   root         427     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         428     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         429     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         430     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         431     425 17 09:11 pts/0    00:01:56 perf bench sched messaging -l 1000000 -g 1
>   root         432     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         433     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         434     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         435     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         436     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         437     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         438     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         439     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         440     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         441     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         442     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         443     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         444     425 17 09:11 pts/0    00:01:54 perf bench sched messaging -l 1000000 -g 1
>   root         445     425 17 09:11 pts/0    00:01:55 perf bench sched messaging -l 1000000 -g 1
>   root         446     425 16 09:11 pts/0    00:01:50 perf bench sched messaging -l 1000000 -g 1
>   root         447     425 16 09:11 pts/0    00:01:49 perf bench sched messaging -l 1000000 -g 1
>   root         448     425 16 09:11 pts/0    00:01:50 perf bench sched messaging -l 1000000 -g 1
>   root         449     425 16 09:11 pts/0    00:01:49 perf bench sched messaging -l 1000000 -g 1
>   root         450     425 16 09:11 pts/0    00:01:50 perf bench sched messaging -l 1000000 -g 1
>   root         451     425 16 09:11 pts/0    00:01:50 perf bench sched messaging -l 1000000 -g 1
>   root         452     425 16 09:11 pts/0    00:01:50 perf bench sched messaging -l 1000000 -g 1
>   root         453     425 16 09:11 pts/0    00:01:49 perf bench sched messaging -l 1000000 -g 1
>   root         454     425 16 09:11 pts/0    00:01:49 perf bench sched messaging -l 1000000 -g 1
> <SNIP>
>
> Capture signals SIGINT and SIGTERM to kill child processes in signal handler
>
> Yang Jihong (4):
>   perf bench messaging: Fix coding style issues for sched-messaging
>   perf bench messaging: Factor out create_worker()
>   perf bench messaging: Store chlid process pid when creating worker for
>     process mode
>   perf bench messaging: Kill child processes when exit abnormally in
>     process mode

Applied to perf-tools-next, thanks!