Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <23f8d25d-b6ae-dd9e-09d2-c28772f9c272@nvidia.com>
Date:   Wed, 27 Sep 2023 20:25:10 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.14.0
Subject: Re: [PATCH] hte: Annotate struct hte_device with __counted_by
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Kees Cook <keescook@chromium.org>
Cc:     timestamp@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, linux-hardening@vger.kernel.org
References: <20230922175344.work.987-kees@kernel.org>
 <0d9a5fc1-1481-2c62-2a77-c8d46ee54f92@embeddedor.com>
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <0d9a5fc1-1481-2c62-2a77-c8d46ee54f92@embeddedor.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3hDY3d4dDloZkpQM1dmS3ZMazk3blVxbDlwT3NrUGpMNy8rNG9DNUdDY1c5?=
 =?utf-8?B?bUtKSGxmRmxpNk9rTlgwUDdnY3YrMmdRTGNOMERERWkvNTdobjFIZzFBTjBh?=
 =?utf-8?B?blVLdGZUZ016TW9yeDlJdm9rQ1J1V3M1bkN2N1ZDNjFMVTlHdEhMTm1ZMHp3?=
 =?utf-8?B?YnlDT0Z6ZFFBZC9SaStvSnJqU0N5dnUxSkJXeWxiSzhUaDh2RmVpb25WU25T?=
 =?utf-8?B?SzBNK3NGQTc4dTVzNFQyUWU3eDdnSU9vS0xSTHErZTJYYXl0aGtWd2hUWXFB?=
 =?utf-8?B?a0s3L2ZpbTlWbnNjYWU5b0toZUgrTEVPYVZvQ3BmRmtwN0ZoN0hDQVM1YWZF?=
 =?utf-8?B?a05EdEhtV1NQUS9mUEdZcHNpeTg2MDVOMDV5V2oxM2xzSHRVNGtYSjVvQmtP?=
 =?utf-8?B?cXFJUGtUMmFEMk1YWDJ2bGNCUVNRUUlydm9td0R0YVZENk1NbSt0ZEFIYmdB?=
 =?utf-8?B?azFoL2NiemJuOHNqNzdHSjJOR3djcFVISkQzMUZZaVZzOXI1QzVDS0F5WCta?=
 =?utf-8?B?MXhpNlM0aTN4RTRQa0RWdWRwcGtqckRQVURZa0t1WlNneG81V1NjQ2hBMC9q?=
 =?utf-8?B?R2ZmeTZ0eG5OUW1VamszTzdoVU5Ob200SFFZSEk0MXF5YmoyeHgreHlSMTh2?=
 =?utf-8?B?REVpc2xYV0FMb2VnMi9POFkxbmdsOWxQbXBURXFEMVUyWUY2YjJsNlM2dEhL?=
 =?utf-8?B?ZHNiZ0oxbXdKNWF0L2Nqa1lVUXZHcktCcnNjQUVzZDZxa2Fyd0JlTG4yYmxv?=
 =?utf-8?B?Rnd3YUN1aEI5MTA0S3crbk5UNVpodGsxdVI2OG80Vmd0azhnNlpvcGpzVmJK?=
 =?utf-8?B?ZmJPb2p4VGdTYkVVMm1tbitLWFlKWDVteFNlc1NJdUNWeEhEZWtYUDhuRXVT?=
 =?utf-8?B?aHU2TmQrbFU4UHJmUGRCZkhHWHlIVThKM2QxTDhvWTVTTkplT2tjZ3RySWF3?=
 =?utf-8?B?OHYvOXBacFJuN2Mvd0RkNy9qYXkyZnlrZlMyT2dacGZpS2w3b0JNWFJCZXNE?=
 =?utf-8?B?NFBQMlYwZU9ELzl1YVdzZDYrWW4wYVI0R1pmODhhYXNVNnUzUzNvcDVNNG9s?=
 =?utf-8?B?WjAvMUFwazhQamJkVnJXVWtTSS9XLzhqME1iNDVTTElwTWdhQjFUVkVZNFAw?=
 =?utf-8?B?SUlSSytCRGZWU2VBVjUwRkppVHlIVG9mbVhSVkQreFNFQnNiM3Y2N2JmQ1dW?=
 =?utf-8?B?WFFhWVNTWm1qQ2o1RDhaSkZkb0ZNWWtIOTJxTW9lbXJMUUo1UFlzeXg3TU5n?=
 =?utf-8?B?VmpLellZZ0xVcDhwS243ZVNJVmRKZnVJbSt5ZGNEdTFDa2dXWW1zbktxWmJp?=
 =?utf-8?B?UW1DVVNKTUFHMkJSd3JkV2tRWGMwaCtseVdSZW9uV3VqVUlhWUxISi8yS0sv?=
 =?utf-8?B?VldVN3JhNUYrSXhOTStUU0xHYzJVbW94RmR6eU5QMEQ4Tm1BNkZsUHJUS0Ri?=
 =?utf-8?B?QVRjcEZBcUc4VE03RGpRSmZHMFIwU2piY0k4VHQydGRMYnc1TFBMMGdlMC9v?=
 =?utf-8?B?ZE94OGNrcGt4L0ZZZ1B1MStyV3oxNmVKU2xXL1h1cDdJRmQxYjNMV1pWamdi?=
 =?utf-8?B?ZmRIc1BKQWR2WkZrZjgzdG4zclBiSHk1TWlGU1cyWlNnRXI2VUs3ZExIMk00?=
 =?utf-8?B?SWlGS1ZzWDZzTTdUbWs3SnkzSE1JK1h5YUZTZDZTSjZTTmlYTVQzdjMvSnVu?=
 =?utf-8?B?Nkw2SEpjTVZST3NuMTJJOWllclEyTWJkb2hFMTZoNCtid09uVFNJeFJmMDFn?=
 =?utf-8?B?bGNJa3h0Z1BFTGFvRXlrekIyZVZpVWlLUXcrUklzOE12ak9uS2MzTk9lQ1dG?=
 =?utf-8?B?bXoxeHNaWUxsOVRnMXhyeFBnRjRQTnRWbHdSQ0I2dmJMMHNEczlzMW14VGJY?=
 =?utf-8?B?Z1g2dm1LaEovZDltbWRlLzQxU1F2cE5ZbE1pV1VJeW1jRisvVjJTcG81akg4?=
 =?utf-8?B?aWZ0Zk9JM3RuNjI2NzU0OTVFakh6ZjhFK3NUc0JESTBlQ1ZYc1RkMXlFQ01S?=
 =?utf-8?B?S1FrUXp6VW91a0dCbm9QRDNHOFZlblJyQUhoOFZjNTA4TnhFRlYwbENQcHFL?=
 =?utf-8?B?bDlxcDh2OWxxVEZuSElyNHBMNlp3eEg1YXFOT0hJTGs5SkVqa2dTM2FMcUZy?=
 =?utf-8?Q?T6sIMF8F+PVNAknrQHRZAwrwz?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e35c403-fa1a-4b9c-4232-08dbbfd2874b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6607.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 03:25:14.1410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dijSN1aOLjE2HbDQTQ8IDga/+qhFepQFYubmVDRXZXmmjiaXYmA+h9imFHMWqIVyhwzvV+xQmgPbUfUSUXOYmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB8445
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 20:25:29 -0700 (PDT)

On 9/23/23 9:37 AM, Gustavo A. R. Silva wrote:
> 
> 
> On 9/22/23 11:53, Kees Cook wrote:
>> Prepare for the coming implementation by GCC and Clang of the __counted_by
>> attribute. Flexible array members annotated with __counted_by can have
>> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
>> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
>> functions).
>>
>> As found with Coccinelle[1], add __counted_by for struct hte_device.
>>
>> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>>
>> Cc: Dipen Patel <dipenp@nvidia.com>
>> Cc: timestamp@lists.linux.dev
>> Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Thanks
Reviewed-by: Dipen Patel <dipenp@nvidia.com>