Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2990740rdh; Wed, 27 Sep 2023 21:47:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuXdhV4uEPr2gcHvzMW4UodKFPi8FFCsNABHgu2lZGOjMZLH9q+v5/cjbVLhr2F9+Lr33V X-Received: by 2002:a05:6870:208:b0:1dd:651a:74b3 with SMTP id j8-20020a056870020800b001dd651a74b3mr211746oad.48.1695876420664; Wed, 27 Sep 2023 21:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695876420; cv=none; d=google.com; s=arc-20160816; b=B1yFpmodwBRlpVlA9GgXEOnh5HgsbJofxNYhFx9F0zcVfkfBE0GA7Cp8k63zlYUiVO w00BLVZENhPRtlPzfunnKWHw8ZnrvYxTHKjLHbV+9OZt07yIegbeP5RdVWTjVn31ofRZ k/fh29Fh0Cbx0I5yUWl0j3xo2GVyarEfOv8/82r/ZUt3bKaRNMZDQeDt+ncFD9MaxMQ1 K2U0aC+GQFF5DwRJvlAsmDj4FpxsYNs5JUwwwnCRoS4Ic47p2daFfCcVBur44V3u/NR8 H7ih7NB1saNLvqtO96HyfjTwZ+fZgTDRkjYSPy3xX54FvIAqHsAv+57dLYNlPLqvLtB3 YIuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AcXbSw9sTgnfH+W7z4t4vq2SV8G0kIJTK37nKEDOZg8=; fh=dB1pHjhBej/97bP8fqhCZJMp3A8zWPiGYsSYcLhenFY=; b=UD+9k7BOJX17D+uR/eEA0u8nsgfCJ77UIUGDUD1H0+QbC45ZBAN1vjyHyLv6ICO/NF 20MgnvwYL5NaEtVXXUoQgNinFOffpfiHnK//6fGuVMzTwujtCgrv1ep6OenSBpcmYtyW cdn0tywimC2QwdZIlCxu2SvTgcoSSVhIoKzPlIdX0+Nr5A2ahhKrOY1cQU50PE81a5Zv KFoI5swtUYtWr/XTGfobhx6AVBG8hwaHQvINItHcMlhyU684wWobd6JsVP0uO19OzrUQ KBiQxiK382iclyNZvqav8NN4YO2SxRucRbmxk0SsumTEoufyWEKiBOxCr0DH23Z1Rn31 pxgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Fk9A+J/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id 184-20020a6302c1000000b00565322ef4f1si18059544pgc.348.2023.09.27.21.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 21:47:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Fk9A+J/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D695D808D497; Wed, 27 Sep 2023 21:45:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbjI1EpS (ORCPT + 99 others); Thu, 28 Sep 2023 00:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjI1EpQ (ORCPT ); Thu, 28 Sep 2023 00:45:16 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49220121 for ; Wed, 27 Sep 2023 21:45:15 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40652e5718cso390135e9.3 for ; Wed, 27 Sep 2023 21:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695876314; x=1696481114; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AcXbSw9sTgnfH+W7z4t4vq2SV8G0kIJTK37nKEDOZg8=; b=Fk9A+J/iNTcG5mmZaxn119zdBOQLgH3bJiCSG58CoPQ6hmHplkqESLxZ6Vdvsz8IT+ 3tpJFpvMrXOQMQ/p9IWLNGJEmvhwCSzUiN309inHaj4FQEAnIhelMCeAju7v22IQdLnj 92fqaNgLqii/rNOEOv+wxPSyOMUUHN7PkCmG8+sQHPKqC72SEWk9ojW3Wb+JJbXREeSQ CCDmPg9xenS3xd+sXGNtnCud+YfdskJTd2R7QcDNPn7+xtUNF8VVHKtMTAmNYzcflv2W yKCpdoEughQXDB/OVrFDKBe0suD+ZGw/etpSEqjHAgcNBKkJIqCb04xi+CBumWr8Leyh p9IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695876314; x=1696481114; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AcXbSw9sTgnfH+W7z4t4vq2SV8G0kIJTK37nKEDOZg8=; b=ctaYGuEzfShUvqqNVWoF3uEUR3sXAazFbOXwewL5TtODesiMCZgr0J1aVJVDQzVzpL iVXVmiCpjMcSDCLwx/JBVSRKfhcnpmQsgZBw6o18HCO78bRYDKg8gZqVcoS9a2d6zuGx 4GZrmiyfACBUSrs8txTmjSjKLeRhf6wN+rF9wvcS36cEOieCpBWsF51zmgkQIWV9WaLi E4nqRWkP/qON9oyowOlqO07inxndbwzr7S8hBDxkS8VbuwWZS0eJ0dm0OcJRAKdBTa36 +MWZVa6YlfaJRgZnPnk7G3hbwk7KIEAiVg8JNMQdZYOekjqMhwYZx0xMvC1Z2tTdIk2B 6nsQ== X-Gm-Message-State: AOJu0YxYN+rr0gmmkDyIydSWmuW4ZcY2QUWA5S/QKJxowzULoOTDTmcO uJooork8I0p9nCr+HauymFLlMbCockKMhwamwTk= X-Received: by 2002:a05:600c:3b22:b0:406:5301:4320 with SMTP id m34-20020a05600c3b2200b0040653014320mr81206wms.16.1695876313748; Wed, 27 Sep 2023 21:45:13 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v14-20020a05600c444e00b0040535648639sm18988603wmn.36.2023.09.27.21.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 21:45:13 -0700 (PDT) Date: Thu, 28 Sep 2023 07:45:11 +0300 From: Dan Carpenter To: Su Hui Cc: Amir Goldstein , miklos@szeredi.hu, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ovl: avoid possible NULL dereference Message-ID: <91ae5901-fae3-42b8-8c82-dc5c2683b4ce@kadam.mountain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 27 Sep 2023 21:45:37 -0700 (PDT) On Thu, Sep 28, 2023 at 09:12:01AM +0800, Su Hui wrote: > Got it, I'm so careless that make this wrong patch. Not at all. Your patch didn't break anything and this stuff is subtle. I've done the same thing myself. regards, dan carpenter