Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 12/12] iommu: Improve iopf_queue_flush_dev()
Thread-Topic: [PATCH v6 12/12] iommu: Improve iopf_queue_flush_dev()
Thread-Index: AQHZ8cSx3Wevaa1nu06TreuvqwoupbAvrbRg
Date:   Thu, 28 Sep 2023 05:00:15 +0000
Message-ID: <BN9PR11MB5276018DE2AC15B3538BBC008CC1A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230928042734.16134-1-baolu.lu@linux.intel.com>
 <20230928042734.16134-13-baolu.lu@linux.intel.com>
In-Reply-To: <20230928042734.16134-13-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qd1XRaLE0dVW1v/xEOhwI/SXsW4WoijXbK7XOiDsZt/kL4swbayh6N6RsZk6?=
 =?us-ascii?Q?TxqfKJ5FVR2eVRS3HjbDx8apvsfGxMvQxM9mLjFCaGyVPRQV3cE2ZMhIRgPZ?=
 =?us-ascii?Q?eyMUQ6vyL/iOxOrVOWpeE4mfzDZmUiRm9LkvUOswPWXURgw+y4qPDQFnx0YD?=
 =?us-ascii?Q?28MbPwukskCqqd5h1FfNuZK2yS5VZuRxpqZGkLVPKqNcbiMLodQtciTSgWTQ?=
 =?us-ascii?Q?Xt65M/yRmtr8lsTzMJL4QUlxsUKpbvYy8OSfX2jThrnszCbGn9sq/61U8eBl?=
 =?us-ascii?Q?sIY/GVJixEQMbjqh+haW6AhLEMjv6XKMHNW/AyK0BXu/oq94+5L2qiqBAvYR?=
 =?us-ascii?Q?z9QVrwSJIAgnyO9+7LKXq2FhvLSye+IA5mSBKYza1lCF5bgzYq/TlGL68Gcr?=
 =?us-ascii?Q?oMiGlrbY2H2UnZkFpAxXI9UIEdp80h88udI6muCXawcp2w2Jg4YFRsfsoTv+?=
 =?us-ascii?Q?ERTPVq1/NLjTyS68jYOU+rmaKU8u4mZatx+LxBDi2fPZrTuua2Hu9emkSYMN?=
 =?us-ascii?Q?JbQNvr7dTUKVsOQ+9F91DpEfswN9XCUm8uxGp1c/4Mul6gC2Li7c9Y3Jf4cX?=
 =?us-ascii?Q?TjVtinjvJ4RWqvgFubdoSnmGFQpbXGB3Dg2LQh8Ivu9eky9+8HX9XwLB9wey?=
 =?us-ascii?Q?H661REFen5nQmKMLic+6UkdJynTocrgp676mNSLXjDw3hW8ctWJkRgsMKOfU?=
 =?us-ascii?Q?GX2j94DILoVU/M77AdLEWz4KTPw3RgNMgbymXUDhWMxCvCLZgvCYBWaxQa6x?=
 =?us-ascii?Q?G3MtBiCOlUKHOSNXcs+spydtg2IAFXbQo7iwfryg8P1UVWWjDF+z3uM1MXpk?=
 =?us-ascii?Q?GOxXH3GXk6xAx4v4kDZOBVrOEL/qo0xFFBb3Yax4fTWWbFnq8zgBkgjZbJCS?=
 =?us-ascii?Q?n+0fsGlIF03IcrT0++iysFrV3Juo+R18fKefmjdOX2tu33S8uFqXgdSqAkk8?=
 =?us-ascii?Q?+IZcVDTGWGYS16j6ZmyH2fKq+xvPOz4wXvwQGyDVcQKnLt5IYu0D3owyvF5l?=
 =?us-ascii?Q?j6bXHusjcLGHO5/sDv3EmTlzeQJ6X6mn984Ag4ckdpFxXeMeGXSLJ142B39l?=
 =?us-ascii?Q?x+F0jfqLtaj0S6BXxuWwq4dZ+S0wFHvKCB+TWLnAc7m/jPuz5OgApKr32x2z?=
 =?us-ascii?Q?vCSpRJXxR8vkOTW8JtBHKAfaVnh/OoEBnbAqNzYNKg3/iFWu4ZN87rOMM5g8?=
 =?us-ascii?Q?WzDMTSyie9DuBEo4hKyAni1UjV48G5AGEYksLGX6Vf40o/kTVK9/WX408AJi?=
 =?us-ascii?Q?Wpi/QqrOc/HxhmyQE6+dNoDjZ6+bMG22l2LR7xr0qMRxp+StYsqml8zQLFJ5?=
 =?us-ascii?Q?V6waAppCb8bvzmSPAtMGDrjsZ0cl4TO87GoUDVRkHA+3xvtckzxS65zhLDTv?=
 =?us-ascii?Q?oOBJfTdyUS4f9Y8BGH0ZVyVYK5P+Np8oHl3pWdc/Pj6usL/0ZTKyJtdrzbEO?=
 =?us-ascii?Q?2//A7w7G42dfQ1Xs1CMptbYKtU4ICL5r32cuSvcwbqXHGUzrlFax1fthpFvh?=
 =?us-ascii?Q?kSHH8iPUPG33DlWLenebFWL1jSOhQgRkl9p/nRG/1DubBtPzTAHc1BXt1EDH?=
 =?us-ascii?Q?li0X/UV9JFujoaogExojEJLf5T93PHsksvek/z0u?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bbde258-d032-4883-0a75-08dbbfdfcdd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2023 05:00:15.4186
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wupYkfep7Sfy6Xe5L/uPWsS974TdW+9XQbaSL7rIaUYiIywDxdsnopG1L8kcwvOcFEGGid503GDNC+BFV6pxoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5003
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 22:01:14 -0700 (PDT)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, September 28, 2023 12:28 PM
>=20
> The iopf_queue_flush_dev() is called by the iommu driver before releasing
> a PASID. It ensures that all pending faults for this PASID have been
> handled or cancelled, and won't hit the address space that reuses this
> PASID. The driver must make sure that no new fault is added to the queue.
>=20
> The SMMUv3 driver doesn't use it because it only implements the
> Arm-specific stall fault model where DMA transactions are held in the SMM=
U
> while waiting for the OS to handle iopf's. Since a device driver must
> complete all DMA transactions before detaching domain, there are no
> pending iopf's with the stall model. PRI support requires adding a call t=
o
> iopf_queue_flush_dev() after flushing the hardware page fault queue.
>=20
> The current implementation of iopf_queue_flush_dev() is a simplified
> version. It is only suitable for SVA case in which the processing of iopf
> is implemented in the inner loop of the iommu subsystem.
>=20
> Improve this interface to make it also work for handling iopf out of the
> iommu core. Rename the function with a more meaningful name. Remove a
> warning message in iommu_page_response() since the iopf queue might get
> flushed before possible pending responses.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>