Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c
MIME-Version: 1.0
Message-Id: <b70fa1d5-7f38-4511-ad2a-abe1b1ad5992@app.fastmail.com>
In-Reply-To: <20230927-strncpy-drivers-misc-c2port-core-c-v1-1-978f6d220a54@google.com>
References: <20230927-strncpy-drivers-misc-c2port-core-c-v1-1-978f6d220a54@google.com>
Date:   Wed, 27 Sep 2023 07:49:56 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Justin Stitt" <justinstitt@google.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] c2port: replace deprecated strncpy with strscpy
Content-Type: text/plain
Precedence: bulk

On Wed, Sep 27, 2023, at 07:20, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect `c2dev->name` to be NUL-terminated based on its usage with
> format strings:
> |       dev_info(c2dev->dev, "C2 port %s removed\n", c2dev->name);
>
> Moreover, NUL-padding is _not_ required as c2dev is zero-allocated:
> |       c2dev = kzalloc(sizeof(struct c2port_device), GFP_KERNEL);
>
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
>
> Let's also drop `C2PORT_NAME_LEN - 1` for `sizeof(dest)` which is more
> idiomatic strscpy usage.
>
> Link: 
> https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings 
> [1]
> Link: 
> https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html 
> [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>