Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Wed, 27 Sep 2023 18:04:48 +0200
From:   Robert Richter <rrichter@amd.com>
To:     Dan Williams <dan.j.williams@intel.com>
Cc:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v11 00/20] cxl/pci: Add support for RCH RAS error handling
Message-ID: <ZRRSoAs04kYWttnj@rric.localdomain>
References: <20230927154339.1600738-1-rrichter@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230927154339.1600738-1-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mlwf5QyH0CoMDEjsP+qoprv0USJumUvlBwsnWmBAOfGgYOlcBbavn2Gih1nw?=
 =?us-ascii?Q?61XFMHfhWB5ooZsIu9GQBiChWS8i53y/CTXpyqIKSBW67dTdozhH5bBwdi9T?=
 =?us-ascii?Q?y6H7vvH/kWyK40QkoSBW6tXOtNxtApqw6NG5RxItPPvv99/RYplGcyZ0PJ/B?=
 =?us-ascii?Q?WpmZuhZUdZVqdGX5FjeOuVC1RUVqyKldDUkhKT7GxKCgO5puQDJ3h7as4OC9?=
 =?us-ascii?Q?ej25knLTdNlrd+M0XS5wPAsUCaO76tIhGeXXt7KgX9iOIsUR0oiEdGGTqmyu?=
 =?us-ascii?Q?s8t9uJaP3rXMAflA6usYAwe48Ad6eRV9PcHTUIygXS3xOAgDHu6MTm4w/mN2?=
 =?us-ascii?Q?mq18UTGYgA1Tov50HL9AGkGJb/MPGgOMgWofBofV3fZJ55F07pCk+hzfjstl?=
 =?us-ascii?Q?TwZJUzzj3zAYzdOGySfOTTpS42gndlpInBgqExw+p2dSDrufF8pSjxvGfies?=
 =?us-ascii?Q?OJ7wSoQmibr4uutevNgpDjpI6COSzOYI40XgjiHSoPxtWuwCvQSRzd2BybbZ?=
 =?us-ascii?Q?RumNTp6vt5AHzCfYzufM7XtrERw1sMTki1W1P5122PzRawvU56dUaKRgkPnC?=
 =?us-ascii?Q?BoAgGM+xOUTcADFWGn1Bo0hOw4wLsRHENTpsro84AqjytvPrsFBVAwU0O5X8?=
 =?us-ascii?Q?03URQEQ5YYUy88PnE5SljCx6Ro5MZzKtjbxiTqts7ZFf6BnkscHYqqj0yQHS?=
 =?us-ascii?Q?hYpUrbGW9h6UAQglFY4RpgY3jC37OEsUinX1422j6+rqT56XnuKwOeDR0jcg?=
 =?us-ascii?Q?PvXUJd4jqqEi4uq8PakGeWHut5TDDMH83iYe1SIsgegCF8cSCJhciw5bqv4q?=
 =?us-ascii?Q?bpODSwd4qkhI4NQd8MA6b7o9P7onWkxuj/SIe0P4itnsH1IlhH55FUCScZte?=
 =?us-ascii?Q?eZpH5Hr93rNBkjGQB1suGJq5iQbS+vVmbTH4av6S7SkIX60URmAQ5aK5F321?=
 =?us-ascii?Q?yc+Ie+pE5lGGSE2wF067I9nxSEPEaI9iqUIaMH/Ty2H9aW9y4wlQw6T/EVP9?=
 =?us-ascii?Q?mXrsXJZMCVw/Ciz2RTul46/MqNyd9C5YIR/HvE98WvC4wKf+3geZfvBCO9iU?=
 =?us-ascii?Q?wbjomPnuAtSz7ija9Ol4PQxKw6IrYhHarUduBazy5qT5tHE/v+/OiI+fQKM8?=
 =?us-ascii?Q?Ed+noNZBh9jtRSvkYk0esWzDTyL+WM0UUMy4ZiL8xcSHG/US+GLiP6cuQNYr?=
 =?us-ascii?Q?709utaJGfM/Nl4X5bJjxGUavyQFE1zytB+tFIV3h/Dykk3o/7LmK54FnVvtw?=
 =?us-ascii?Q?NNLXWAL90u0HrI0dbhM0JNdjU40AnciJcfyNB/Bom2SHuUd8r6AMJ0ozE/rG?=
 =?us-ascii?Q?4zqsN8HMEpEoneEjure5TiBB3d7EZzFsKww3HXvli9V5Fro5exHnNxPEJN+4?=
 =?us-ascii?Q?S2cH3pY8/QWRnnfC7MJ1zb0AGZrARDYremzLiHXkb597NmwiWB0whUOMZkZq?=
 =?us-ascii?Q?4YkbflZybLlEJPQed1FRopfGKdPsNWzH3YBa/nJGb5AaRfYrIbvQLWwDdXBk?=
 =?us-ascii?Q?nrJVY/c1tdZEqD29JvUH5nILzLBUMT/GJpMdf0BaRjX2hd1sF10HlWd8Bhqw?=
 =?us-ascii?Q?qxywwpKnR3eJsQ0M9BqCNzrfu6kpjzXA6cHZkc/d?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d071a96-a552-4b2f-fc1d-08dbbf737dda
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3657.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 16:04:55.8251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ow+24dMleWyeABZwFCOt44wr/yoUcsx4bcfwLgGc2JzDvxtZbQtd+YN4onF37vbQnqH7Mf2BM5Wy4Q7e/5voeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4295
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 09:05:10 -0700 (PDT)

Dan,

On 27.09.23 17:43:19, Robert Richter wrote:

> Changes in v11:
>   - Rebased onto cxl/fixes (c66650d29764)
>   - Added: cxl/port: Fix release of RCD endpoints
>   - Added: cxl/core/regs: Rename @dev to @host in struct cxl_register_map
>   - Added: cxl/port: Fix @host confusion in cxl_dport_setup_regs()
>   - Added: cxl/port: Rename @comp_map to @reg_map in struct cxl_register_map
>   - Removed: cxl/regs: Prepare for multiple users of register mappings
>   - Modified: cxl/hdm: Use stored Component Register mappings to map
>     HDM decoder capability
>     - Dan: rework to drop cxl_port_get_comp_map()
>   - Added: cxl/pci: Introduce config option PCIEAER_CXL
>   - Modified: cxl/pci: Add RCH downstream port AER register discovery
>     - Moved AER discovery to devm_cxl_setup_parent_dport() called when
>       memdev is probed
>     - Fixed devm_cxl_iomap_block() release by fixing devm host
>   - Modified: cxl/pci: Map RCH downstream AER registers for logging
>     protocol errors
>     - Reworded description
>     - Moved register mappings to devm_cxl_setup_parent_dport() called
>      when memdev is probed
>   - Modified: cxl/pci: Disable root port interrupts in RCH mode
>     - Call cxl_disable_rch_root_ints() in devm_cxl_setup_parent_dport()
>       called when memdev is probed
>     - Fixed resource release by fixing devm host
>   - Reworded description of PCIEAER_CXL config option
>   - Added: cxl/core/regs: Rework cxl_map_pmu_regs() to use map->dev for
>     devm

for a v11 this is a major rework. Most of the dport setup is now in
devm_cxl_setup_parent_dport() which is called very late from
cxl_mem_probe(). Also, additional patches with fixes and more
reworks. I saw one failure in the ndctl cxl test suite with qemu, but
decided to send the patches out anyway as a new baseline for review,
testing and debugging. Bear with it as due to its changes the code
need to mature a little.

Thanks,

-Robert