Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com,
        tao.jiang_2@nxp.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: imx-jpeg: notify source chagne event when the first picture parsed
Date:   Thu, 28 Sep 2023 13:37:23 +0800
Message-Id: <20230928053723.20765-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ilMM/09iGlsi2O9VUdnwmpKUARt2BMP6OMYcabgBKF+3yFwiEhCu3tX7vmCq?=
 =?us-ascii?Q?ie3eIode4iLhgY6VptnvBsYlT7UB8Z10M4fgB/qe+BYm/wFCFf2vhzUdvSRx?=
 =?us-ascii?Q?I+HRoe/ifcvxrZD1KMezJM8y5kTjwYXbZZ5DGLNhajdGKI9Z0qZx0LlnK+kk?=
 =?us-ascii?Q?5jTHMzNWEcLcUy0ZmQXU+HnWd6wBRT3nUVqhPxQTK1PovzVjWPoF7ny2yZpO?=
 =?us-ascii?Q?hn9NhiLd5YViq0TgYcb4Y5pFWeRLVwxyGPWBHqsbG6/TVVfpGr9TxuHqbirb?=
 =?us-ascii?Q?tJ9VT0NW0Nb4NmiH/zazTMuIe2ABXQe+f6vlcTXZTA1RjafVNPjvsVZ45wII?=
 =?us-ascii?Q?jWZk52KR4y3EgH3LwsKbLLY2yETJIXMgVH8tI/pBo/ZRBFrscxH8f7bBJogN?=
 =?us-ascii?Q?fe3Cyx1Y3Ry7pmWaxvAdvNLEl0oYssY+0/YcG1+Kd3kWX6r9qOVjBBCIR4yk?=
 =?us-ascii?Q?9gjTGZJRmMrjz6LS3tykJJDSYnyGSzvhjaa7soMC+zVPdT4RniTM1M2qbjMN?=
 =?us-ascii?Q?b3TvOJPo1qF4yyBF/TApVM1xLQaBW9XMvoyWvzwyPEMkFHkVZD8VrQN/pkpv?=
 =?us-ascii?Q?O1k7th4mnNoXoH+SP7VgKUtqm+7HnyhRMuTh29BcUuio9J3kJj3TNFtiOG3b?=
 =?us-ascii?Q?sLCJs/f9XoIc52nhpmpXXmhqatw/pi6T+6Ji/zjbdVylZoyd3wUzB34QEGfT?=
 =?us-ascii?Q?7K+FZ0GCt2bhsoDyC55OyCNpNmh7At032qRRcpytnXqxHzLAb+hsA7DqbULX?=
 =?us-ascii?Q?PUonB+z9twpHObHFyEF2rdSEC5qzNpDRR+A6kp61BRY77w9Zir58niCK0vZQ?=
 =?us-ascii?Q?8QuKPOUuAYbvvbI9C2tQdHNydwwk/mKGR+KJQ54VJpAeRfjIXVc2rqW57RjB?=
 =?us-ascii?Q?+jNtDe5xK7fj/erpLaZKaA4wrHlaAgy3VivTp5BXWMPTVRDEYW4bq+XGwBPi?=
 =?us-ascii?Q?uUXB9OiVBPbJ4BoSjmLpCLhFxfMy2tfpqPgq5qCFKHtB4lqXGMxpyua3QK9o?=
 =?us-ascii?Q?jnmN5h0NgKFuT+eRIVzKILW2xLC4LmlFLfZhUE1B6qPS40UwdlBwXbeAB2Az?=
 =?us-ascii?Q?+liexgge6sa7dBpBkGPYk6l8COedmslsaa9K7+3zlVqWa0xDLe7euxB6+Qfg?=
 =?us-ascii?Q?e3S4YdvCf3MS1y00vpHMY7HOz+wklDluapvX1cy4sPaDjKhGtwequ9kOSMon?=
 =?us-ascii?Q?DR4d8c0v4WJ3vfpzPOqIJYUH+QJpqCv9qTpP4TbTYwvX/lPMGNn3lO9IWgAf?=
 =?us-ascii?Q?bT/KgL90TdC1ScbBrqVCA3s3JLY7UNCo1k23DcVzla7tyBnmapgclW3tQvaM?=
 =?us-ascii?Q?/k+rIKBb4tSLmfm0eNog8yRMqqxRgGT5vHoy0WJJZXKRJ47PXwg7PSIMwa1F?=
 =?us-ascii?Q?Nv2azJAteJxX7bCuN1y8ZBVbR4diwZGK5KKZ7e+nt6dhreS/SpTEXQDY1yBA?=
 =?us-ascii?Q?zIE1lco2HEyEvLpPfKRCgyF+I3Yhm/7+/yEOHFLXxGIQVpiQk8hwM+8ZpAZB?=
 =?us-ascii?Q?rAExyB3i5ukTFlDEHfIcoKbBAylRdg8C2zigfbWkSW4dT7m6W3UhwbrDMEDn?=
 =?us-ascii?Q?LnWKDpKiCYLSA8YncyTdVHUNVW7l5/d2+pEy/bZ5?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 752bc49d-c827-4b34-3327-08dbbfe50a95
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 05:37:45.1548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dqZ8yuerEOvrGKsiccV4HIlLivL9EoKFICSXBoMOG5KpOhby7G79Dbx2WHpSswlbOhudozgeuCWaK79ozg6zsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6912
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 22:38:03 -0700 (PDT)

After gstreamer rework the dynamic resolution change handling, gstreamer
stop doing capture buffer allocation based on guesses and wait for the
source change event when available. It requires driver always notify
source change event in the initialization, even if the size parsed is
equal to the size set on capture queue. otherwise, the pipeline will be
stalled.

Currently driver may not notify source change event if the parsed format
and size are equal to those previously established, but it may stall the
gstreamer pipeline.

The link of gstreamer patch is
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4437

Fixes: b4e1fb8643da ("media: imx-jpeg: Support dynamic resolution change")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 7 ++++++-
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index 3af0af8ac07b..372f3007ff43 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -1348,7 +1348,8 @@ static bool mxc_jpeg_source_change(struct mxc_jpeg_ctx *ctx,
 	q_data_cap = mxc_jpeg_get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
 	if (mxc_jpeg_compare_format(q_data_cap->fmt, jpeg_src_buf->fmt))
 		jpeg_src_buf->fmt = q_data_cap->fmt;
-	if (q_data_cap->fmt != jpeg_src_buf->fmt ||
+	if (!ctx->source_change_cnt ||
+	    q_data_cap->fmt != jpeg_src_buf->fmt ||
 	    q_data_cap->w != jpeg_src_buf->w ||
 	    q_data_cap->h != jpeg_src_buf->h) {
 		dev_dbg(dev, "Detected jpeg res=(%dx%d)->(%dx%d), pixfmt=%c%c%c%c\n",
@@ -1392,6 +1393,7 @@ static bool mxc_jpeg_source_change(struct mxc_jpeg_ctx *ctx,
 		mxc_jpeg_sizeimage(q_data_cap);
 		notify_src_chg(ctx);
 		ctx->source_change = 1;
+		ctx->source_change_cnt++;
 		if (vb2_is_streaming(v4l2_m2m_get_dst_vq(ctx->fh.m2m_ctx)))
 			mxc_jpeg_set_last_buffer(ctx);
 	}
@@ -1611,6 +1613,9 @@ static int mxc_jpeg_queue_setup(struct vb2_queue *q,
 	for (i = 0; i < *nplanes; i++)
 		sizes[i] = mxc_jpeg_get_plane_size(q_data, i);
 
+	if (V4L2_TYPE_IS_OUTPUT(q->type))
+		ctx->source_change_cnt = 0;
+
 	return 0;
 }
 
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h
index d80e94cc9d99..b7e94fa50e02 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h
@@ -99,6 +99,7 @@ struct mxc_jpeg_ctx {
 	enum mxc_jpeg_enc_state		enc_state;
 	int				slot;
 	unsigned int			source_change;
+	unsigned int			source_change_cnt;
 	bool				header_parsed;
 	struct v4l2_ctrl_handler	ctrl_handler;
 	u8				jpeg_quality;
-- 
2.38.1