Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <01c42d09-c24c-2611-ff2e-e1079b6df157@suse.com>
Date:   Thu, 28 Sep 2023 10:48:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v13 00/22] TDX host kernel support
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     x86@kernel.org, dave.hansen@intel.com,
        kirill.shutemov@linux.intel.com, tony.luck@intel.com,
        peterz@infradead.org, tglx@linutronix.de, bp@alien8.de,
        mingo@redhat.com, hpa@zytor.com, seanjc@google.com,
        pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com,
        rafael.j.wysocki@intel.com, ashok.raj@intel.com,
        reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com,
        isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com,
        sagis@google.com, imammedo@redhat.com
References: <cover.1692962263.git.kai.huang@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <cover.1692962263.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VCtGNEppMjZZUW1Ha2lWZXNRUm5CSmNTL0JEd251RjBRS09pRTF3U3lyNDZm?=
 =?utf-8?B?S3luMGlHOXo5ZjRSVUJRdmlpZUlqbjFsajM5SGpERTlBSHhVbm1DeldVRmtH?=
 =?utf-8?B?OUdYL0FwYmplYXp3TEI4NXQvSjZJOFpSM2dHNEs3ZVNPbVk1MWhIMUtPMTdI?=
 =?utf-8?B?M0ZGczZaaStVUk9CbWdiTFlOVTkzYnNtK3JOakdCcnA5aTFQVGxTdDBYSitQ?=
 =?utf-8?B?MnVkeG1VV0RCSWZHbVRQVmx4ZHFqbjcvcFAvUDQ3aklMeGFpSWtwZklJYjNa?=
 =?utf-8?B?V09hTUlPRkl0YU9OYzJMQ1ZUa1djcklqbFJ3eEZZRkxTZnI2ZjM4TFRHWGRJ?=
 =?utf-8?B?YWl1bXNsK28weE9FWGFsRkRDNzY0N3J2cEpNalpSa21yVFozWFYxZ3g3dDRU?=
 =?utf-8?B?TjJ0dkY1TlNjTWdpZjhqemtyQzVtbi9EZW96cG1qYjVIUTdYVWk3VnFjbXZt?=
 =?utf-8?B?RUtSKzdLUCsxZ0NHS3Z6TlJ4TWVGaVFVd000b2RvZUkrblhrMkpHRFpTWWM4?=
 =?utf-8?B?Q3luUmxtNElZdFF5NEpRcXdsMExIakxDTzg0MUhoWGo4aFVRcEVIOFhUMEpa?=
 =?utf-8?B?Z1lGUlh0ZHNLQVBwTVhhSnZhZ1FxRXZRRVExOXR0MXhYNklvYlRlblBXZUJj?=
 =?utf-8?B?aEIyOEMyb3RueVVXSW9KeTNwVzhhMjliSHMwLy9pZWhJSlZyWlVtaVk3ZC8r?=
 =?utf-8?B?Yk5QRzdxc2lNTVJmTVlTc0ZDOFJMOS9OTjZVdFVvRXRkZkRYeDYxT29EVXpZ?=
 =?utf-8?B?UEZ3MDRNNVhCYXorT1JlaEFPcEZab0dyWGhGQkVRVXQ2TEYyQ25LWjF0QnUy?=
 =?utf-8?B?YUxONE9BQ1hqZmhWaHhCTDhEMVcySWN3SzZiZXVtTjlaNnkvWFpmUElORkpW?=
 =?utf-8?B?TUFUKzRZazg3YW92MjlrV2JuNEMwRExMQ1djWndjanJWUiszeEg0Mi9meG5k?=
 =?utf-8?B?c3ovMzA3QVRYOVRUa0pVY0dkd21MMVFBN0JrT2w5RnVTMDVKbjNtbSs1N0I0?=
 =?utf-8?B?aEhTbTA4S2x6ZDloR1huaVVyU29nSm85N2VDZlZrUlFlaXkvaUh0bmJxNS90?=
 =?utf-8?B?WitPdDFsQWs0QzlremZoODJCOFdabVkxWjIwSDVLUi9kVVRYN0RxVXpwbkJJ?=
 =?utf-8?B?dHN2eXoyWHU4R2xtcThMU283Z1FEbkR3bWgwanVNU2lnbFd1alY0NlBJVWZX?=
 =?utf-8?B?a0hOb0hJRzFEZkk0REZ1SVdvYWxYQ1ExSklLMittRTA5cERJTG15Ykxlajlo?=
 =?utf-8?B?K3lucVA3S2dKQS91Tk9hU2RGVklvelJHaldDczJxZkpybEFYdXRWMWlYVzJ1?=
 =?utf-8?B?SFFhbmo1L2Zmd0FEY3FJSWR6ZDlnTCtGUTBQZlY3Ym4vbi9BSEgvcStQaXZr?=
 =?utf-8?B?OXNDN1ZsSEMvWGQ1QXQxOFdXRklFa05iZG02ZlcvQ1pXQ1JhRG56enhmZ3dG?=
 =?utf-8?B?MWdVc210OHg4Wk10eDEySUR0dmtFNWloRk5xZG8zalkxRmlpbDNmakNRcDRS?=
 =?utf-8?B?aHhWS3A4VHVEOVkySVVtWUVFTnZSdEl4QkNJcEliTHJYczFZOVZwV2tZdFQz?=
 =?utf-8?B?VnpsVHQvTG8rb0k2UlFoSUZ0SHNLbmhyZmdzcDVFUnFuc0RGenZubXNOQVBp?=
 =?utf-8?B?NXR3Zkt0QUhxZk5HN3lGNWkvSElTaklvSTMyeVM2RFhsZkg4ZUUxSkZwbWxs?=
 =?utf-8?B?WGVoTHBrWEtSNXYrTFVMTzJqNkF0QW0zSUVnSnB3OE9TZWFTdHgwM2kxYlNZ?=
 =?utf-8?B?aC9Xem15NjdwOGcxV1VDSjFrZVA3M3NFSGxmdXcxRnIzQjBBa0V5N0ZKRlFt?=
 =?utf-8?B?N0dXVWNSSmxaTHhQOWtHcjVIUUZSN2NSbmQzVnliVWU1c3FyYlByM2VldFBv?=
 =?utf-8?B?Vk1ITERueW51aHljdzNwZENwanpPVFAwMFlHNkY2SFcwcncvazlKMy9zMmJ1?=
 =?utf-8?B?TUZJTGNTZFQvSmZtU3l0SmRxOVRoRTJKY2VaR0dMT3ByWTU5NlBYczZFK0Zj?=
 =?utf-8?B?RklxKzZFMWh1LzFCNm9lTE1QMEtEYlgwYmpwNWswR2wwV2dmZlpHaHg1SjFU?=
 =?utf-8?B?NlBFOHU0U0NIQm8ySEZPNW95SDFrM2w4dkY4OUlYcVZIb1dyNGRDYzlzZmVF?=
 =?utf-8?B?M3BQUHE1MDhaMFZ3OFVmZXpzNmpzY0JaSzE5Uk13T1B0d20yKzAvblU5SDBE?=
 =?utf-8?Q?WEeRCsXyZs7h04mAfTLBZHUIAjZKTsSbZdslNvOwYKi6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf7bee1-64d2-4c23-9f5c-08dbbff7501c
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 07:48:33.0180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rhvr7ga3/pmuxbMrm1S94WKsHAp+hqiCK9FeSl+zaUCn7lYuEQHY+UAPO678MSKcAn9D0K/ogj3qoChLC2y6lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8422
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 00:48:56 -0700 (PDT)


On 25.08.23 г. 15:14 ч., Kai Huang wrote:
> Intel Trusted Domain Extensions (TDX) protects guest VMs from malicious
> host and certain physical attacks.  TDX specs are available in [1].
> 
> This series is the initial support to enable TDX with minimal code to
> allow KVM to create and run TDX guests.  KVM support for TDX is being
> developed separately[2].  A new KVM "guest_memfd()" to support private
> memory is also being developed[3].  KVM will only support the new
> "guest_memfd()" infrastructure for TDX.
> 
> Also, a few first generations of TDX hardware have an erratum[4], and
> require additional handing.
> 
> This series doesn't aim to support all functionalities, and doesn't aim
> to resolve all things perfectly.  All other optimizations will be posted
> as follow-up once this initial TDX support is upstreamed.
> 
> Hi Dave/Kirill/Peter/Tony/David and all,
> 
> Thanks for your review on the previous versions.  Appreciate your review
> on this version and any tag if patches look good to you.  Thanks!
> 
> This version was based on "Unify TDCALL/SEAMCALL and TDVMCALL assembly"
> series, which was based on latest tip/x86/tdx, requested by Peter:
> 
> https://lore.kernel.org/lkml/cover.1692096753.git.kai.huang@intel.com/
> 
> Please also help to review that series.  Thanks!
> 


Are there any major outstanding issues preventing this to be merged? The 
review has been somewhat quiet and most of the outstanding issues seems 
to be nitpicks?