Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <c58a017d-81ff-a797-5b3c-af5a016319bb@amd.com>
Date:   Wed, 27 Sep 2023 16:44:35 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v10 01/10] x86/resctrl: Add multiple tasks to the resctrl
 group at once
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Babu Moger <babu.moger@amd.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-2-babu.moger@amd.com>
 <dc1281bd-68ce-18f8-e4fe-d2d07535f047@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <dc1281bd-68ce-18f8-e4fe-d2d07535f047@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akZSV0JpMlFYbjFnR05mdXhLNDZ2dXBJTzBWWExJUkZLMmliZ3R4SlJNQnBP?=
 =?utf-8?B?RUdLVUhOM25NRGc1clZJOFNqSFZ0SnJmaU1qSloxanozcFhoRnRFM3RqYWRy?=
 =?utf-8?B?QnhwMGdWTjdWSmRuOXVQYlBnZkpiNFMwdTk1ZisxZ2ZGUVA4VWhodExjODNO?=
 =?utf-8?B?eldmdUg2Y3B6ZjcrSlZZaUlnblBLa3RIYThEVkkwTUVtOWttSTJpQ0tIeitJ?=
 =?utf-8?B?QWtvb25PZnBXdHBjdE9tekp3N3A0QVRibzE2SmdyV0hTOElqMktDdGlZVTBV?=
 =?utf-8?B?dHRIWHRzTVhpN3VNc2ppL1Y0c0NQTWROcVEzSjJmNVdnbU0wci9KTVhQTWFK?=
 =?utf-8?B?c0p3VUl4LzZ3M0hKVGpsUjFkSTZZZFpxeitPMHNKbDdrbkFFd3JTVjJRTDFv?=
 =?utf-8?B?Q3Q3Y0VmazVGMHdzZy9IODBPTFRBUVlpeG9sK0QwMHhBQjNnR0paRE9Dc2s5?=
 =?utf-8?B?dEo4TktvSHJZaGJ1WkZtZ1NqRG9VS2NXcnVuRHVoSmwvZEV2Qm9RbFZOaHhJ?=
 =?utf-8?B?R0ZqYVpHSEoxTHcrUXZDb2VuR1JJeGJ5V1RrdDR1cmtwZklhZHlLUFJmSHR4?=
 =?utf-8?B?djhNcmt5UDYxNUxNUDliLzVpTytTTmw0MDAyUTEvL0xHWGl4RFoyT1BhTU1C?=
 =?utf-8?B?dXh3VE1GWFVaMUhibm40QkthazBsMnFia1IxTHMyNDdnMmxaNVg5RUdrYllx?=
 =?utf-8?B?dUtSS2xpbkVMd21DUU9LZXJOK3RwZEprNWF4d2hZaXpMSXpFZ2gxWXZ5K01X?=
 =?utf-8?B?Wlh2azd0Um11Zk5BMWVJSlFsYjc3L0dLcmRXTmxIQ2h2cWdOaGUwN21KTE1z?=
 =?utf-8?B?bjF4aTQ5Tzk5U2dsTlFRYnIyWlRWTUI5VFVrOS9FZ0t2aW51T0l5ZGdKTkVV?=
 =?utf-8?B?RUlYUTZwRmM1TStnZDZ4OVYwdVZQSGxQeUpENzlwTlkvOVBGR1Zwekt0TzVr?=
 =?utf-8?B?OEM3NG1uNzdPcndGcFQ5RTBLSTFKTFJNTm9kQ0RpWUVycjAyUFRWSFZnajF1?=
 =?utf-8?B?aUNkWmxKOEFMSTIydjBwVTVHMkU3WFYzR0RwTEc2MXpJcTgzV1RXVHNvNXR1?=
 =?utf-8?B?TDlXVXZBWnlta2M4WHVWVWc3d1NPT3p6OTkydDFSbXU0L0lQRHNsdWR6OTVG?=
 =?utf-8?B?cy8zK0FVL1ZkUnNySi9rM1d0QlJKOSthV0VLOXUzSkNOQVM3SDE4SVdtSmJ6?=
 =?utf-8?B?cGI0ZGYrZzg5SzMwaXp3VXF2ZE40MUFRcjZrZWhDZ0l1MUJpR0M4ZzVxQWNo?=
 =?utf-8?B?ZE1zdVAzaFF4YUJWUndrQkltRmNSSWZRYzJqRm91SG90cURzTmVCdnNJR0tn?=
 =?utf-8?B?Z1lGbUtQWE5jb2R4WEpRRmVuVjliNjZhSTBFQXJ2c0F6VUgxTE9kSjV0SHNp?=
 =?utf-8?B?VW5lSlNiN3BzZ044VUxZeUlpYm9kdkdaUlZvdUIyMjhTWmRXd2NTcEVWRlZ5?=
 =?utf-8?B?SlVSbHltdDRReno0TTE1SHhXSTR0eDJVdTZwcXpBaWc1Z093anMzeG5QRFJL?=
 =?utf-8?B?S1pybkU1L0ZFeWJ4dHB4UUZqYk85MzhSQUFPNnZERlpkMlg1SFdLb250QW9u?=
 =?utf-8?B?SktWcnNKbGlvVFdZSHptSm14eFFtTis0cDZJcXdTMTl4cGxwdEN5OGxrdUVG?=
 =?utf-8?B?aUZ4SmdDZmxvU29tZEpGTFZRQTVHMTkvTXB1UGJhc3g5aFhpNE1aSmpsVGoy?=
 =?utf-8?B?ZHQwRi9DNC9oY1Jtc0YvN2hFSXdBZUZsUklGK0xQWkRxMGZUVXFQRTMvaTRF?=
 =?utf-8?B?LzR3ZEdQN01EM2RuUFhwMVFEcis4UGk3UGNOcmpBcUYrMS9IVnZZc2lNOHZH?=
 =?utf-8?B?cjgycGROWDAwbXJiY0xYczJ1SlBta1RZdDczUDNMa1dmQnJnbFFCc2xycVdr?=
 =?utf-8?B?TGhrUE94SytmZU5VVUExaEhvVDRWRTlnUnFWbitPUXhISHdFQXBMK1cvMEZy?=
 =?utf-8?B?bFRYeHJzbEdCU0JyNU1leEx4a095bzZqRjhBMmttVUVUWE9ldDFuaTJOSm80?=
 =?utf-8?B?eSs3Tm5JRXZuaEhLTnNOOWtOSWw3b3pNQVgrYW1FR09jcktOblIzQ3pSemhn?=
 =?utf-8?B?UWNBQ1RXNHN3djVDUm5PSmxqS1RzRWxERkVxY0NaTTZUdmUvR2h2WVRTbEl3?=
 =?utf-8?Q?+e5Bzg5C+FLcfjCsI6A4XoXG/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c194663c-3365-4434-0331-08dbbfa2f45e
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 21:44:41.0105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BWHUEPmD86w+Gc6zpVAnezdHhn+bxXvK0PYrDgxEplrzr5G7o6uM3K+L6E+KqSap
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4888
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 14:44:55 -0700 (PDT)

Hi Reinette,

On 9/27/2023 1:30 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/15/2023 3:42 PM, Babu Moger wrote:
>> The resctrl task assignment for monitor or control group needs to be
>> done one at a time. For example:
>>
>>    $mount -t resctrl resctrl /sys/fs/resctrl/
>>    $mkdir /sys/fs/resctrl/ctrl_grp1
>>    $echo 123 > /sys/fs/resctrl/ctrl_grp1/tasks
>>    $echo 456 > /sys/fs/resctrl/ctrl_grp1/tasks
>>    $echo 789 > /sys/fs/resctrl/ctrl_grp1/tasks
>>
>> This is not user-friendly when dealing with hundreds of tasks.
>>
>> Support multiple task assignment in one command with tasks ids separated
>> by commas. For example:
>>    $echo 123,456,789 > /sys/fs/resctrl/ctrl_grp1/tasks
>>
>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
> x86 area aims to have a uniform view of commit tags.
> Please review the "Ordering of commit tags" section within
> Documentation/process/maintainer-tip.rst and apply that
> custom to this whole series.

After reading it, it appears this should be the order. starting with Author SOB. Hope this is what you meant.

Signed-off-by: Babu Moger <babu.moger@amd.com>
Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thanks
Babu