Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20230927184556.1422122-1-ben.wolsieffer@hefring.com>
In-Reply-To: <20230927184556.1422122-1-ben.wolsieffer@hefring.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 28 Sep 2023 00:19:16 +0200
Message-ID: <CACRpkdY=kuwiBb965Q7cwu4AeGaG2j0UQ=SOVEZAu=Nq+U265g@mail.gmail.com>
Subject: Re: [PATCH] mmc: mmci: use peripheral flow control for STM32
To:     Ben Wolsieffer <ben.wolsieffer@hefring.com>
Cc:     linux-stm32@st-md-mailman.stormreply.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Yann Gautier <yann.gautier@foss.st.com>,
        Christophe Kerello <christophe.kerello@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ben,

thanks for your patch!

On Wed, Sep 27, 2023 at 8:47=E2=80=AFPM Ben Wolsieffer
<ben.wolsieffer@hefring.com> wrote:

> @@ -378,6 +379,7 @@ struct variant_data {
>         u8                      dma_lli:1;
>         u32                     stm32_idmabsize_mask;
>         u32                     stm32_idmabsize_align;
> +       u8                      dma_flow_controller:1;

I've insisted that we use bool rather than u8:1, ut admittedly it is
nitpicking.

Either way:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij