Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20230927072157.2544601-1-arnd@kernel.org>
In-Reply-To: <20230927072157.2544601-1-arnd@kernel.org>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 28 Sep 2023 11:04:35 +0300
Message-ID: <CAFCwf13JrDtgKiqQw46knk_J2zdBNA348doaTBMvmrYYc1OgHQ@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: add missing debugfs function stubs
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Tomer Tayar <ttayar@habana.ai>, Arnd Bergmann <arnd@arndb.de>,
        Ofir Bitton <obitton@habana.ai>,
        Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
        Ohad Sharabi <osharabi@habana.ai>,
        Dafna Hirschfeld <dhirschfeld@habana.ai>,
        farah kassabri <fkassabri@habana.ai>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Sep 27, 2023 at 10:22=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wr=
ote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two function stubs were removed in an earlier commit but are now needed
> again:
>
> drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declara=
tion of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_in=
it'? [-Werror=3Dimplicit-function-declaration]
>  2231 |         rc =3D hl_debugfs_device_init(hdev);
> drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declarat=
ion of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_f=
ile'? [-Werror=3Dimplicit-function-declaration]
>  2367 |         hl_debugfs_device_fini(hdev);
>       |         ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later")
> Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an ac=
cel device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel=
/habanalabs/common/habanalabs.h
> index 2a3acdbf91714..1655c101c7052 100644
> --- a/drivers/accel/habanalabs/common/habanalabs.h
> +++ b/drivers/accel/habanalabs/common/habanalabs.h
> @@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *h=
dev, char *data,
>
>  #else
>
> +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> +{
> +       return 0;
> +}
> +
> +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> +{
> +}
> +
>  static inline void hl_debugfs_add_device(struct hl_device *hdev)
>  {
>  }
> --
> 2.39.2
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next
Thanks,
Oded