Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3077375rdh; Thu, 28 Sep 2023 01:40:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtiFyjMJvDaZQfvsQzfERywUzM0EosJoBBneDSPmmOa12Xl1qFF0mJsu7W90lBT8ZbFl2o X-Received: by 2002:a05:622a:4d96:b0:418:1855:9d8 with SMTP id ff22-20020a05622a4d9600b00418185509d8mr451653qtb.12.1695890403099; Thu, 28 Sep 2023 01:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695890403; cv=none; d=google.com; s=arc-20160816; b=t0EEkZO35PftDe8NqNgfRMjAZOk7KKsYBt9K7cJ/bOi7VKw/Uo6aSIirIv6VeiXdOD hjmTuCZ07BqdK/tfZp11/pmftBmgJhEqH5ssWw+22jHpgXiEjQMzCmXPRK109i+wWoFH jRRi6zwWrwkcF3mUzI2zr63cuq7vM7m+vqVy5imTved4A1wvHfEGeAm4JIiqNnzKezv3 1LaOOwiCo8ki47yydUD1tZ53ovLfjHTqt7XdAPABd9JQJB5OKQ70J5oy1rYMFt23Xx88 ADWeAPy5JBVRftawdt39n1U7hTWRjSDN/UOZuuzltBaf1MJDshUsP9DOtp4iMnYXqiRY mXRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:subject:cc:to:from:message-id:date :dkim-signature; bh=hs9I162pyAs03yza7EqNHteh8cmylaF4F7X2pBMkODM=; fh=i7DQetGfDsfWYXohCb4E5ZTXE/R/ityVAbXNGIxurAo=; b=ghCtQ6wK1TrfAoDqRR6L6nxP2uqAgpu4NSISHrM6BJw1oYhiDfE4D7dlTCv/DCtDwT Dp/zhBAV42A01fUJukdcbIPUrKcB3ggDqTK7bGhVvkbc60+wWswC/chVoc2J9FM1xPOZ MgG/v0Ygj/dnFxxxYhVGiam+Lv1Yvr4LlX3Kvc+og/PEvCiXFmhIQc/3eznXXBRJOZR+ fXEDJ6eRXeSqC1wskMcbNaImUZVK7PC5gM5Nm1dj2l6kcopz88iwaRJE3JNHe9Qzkt5F mcy6kZbtLa3ilCre5XELryjqnao3QoG0lYSa6wsJMVtsRM2KHw3zbYnrMMV08PdmEADx mLWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mKxAYlqs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id k20-20020a637b54000000b0056959099f46si7399639pgn.856.2023.09.28.01.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 01:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mKxAYlqs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DBFAB81142C6; Thu, 28 Sep 2023 01:31:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbjI1Ibo (ORCPT + 99 others); Thu, 28 Sep 2023 04:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbjI1Ibm (ORCPT ); Thu, 28 Sep 2023 04:31:42 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 538FCAC; Thu, 28 Sep 2023 01:31:41 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c434c33ec0so97338205ad.3; Thu, 28 Sep 2023 01:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695889900; x=1696494700; darn=vger.kernel.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=hs9I162pyAs03yza7EqNHteh8cmylaF4F7X2pBMkODM=; b=mKxAYlqsHudVTRaKPcHre7wcTjMZdusL0nhtmIjCrLE+B2x+TZQca/7csVvBO3NDFB cR2Mqc/tbt3FVc5uwytGs6r9X3E0DzOlIlfoHGEw0QkDPtqZxK9BRxNwVC6NsLWQ+mnT ppPgRWkXQkgkePdJK7Qgvg7UeFxXfBsrt9BS9EXVKGNokZXN1OaYTv6tXXLC/5keI0sP /m5PcDQodkkwQkHXKy2yV33c5bzu1b0ttWvADS9QLVUb7UPVOHLd6YXWEvfYVtjPfBoG e4Jr6uMV4h5OthLj8DiADquJGKm3u/ERXg4yeKESjNwmQ76/0Ny1yXnWyW0N3GkNB6mS XdHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695889900; x=1696494700; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hs9I162pyAs03yza7EqNHteh8cmylaF4F7X2pBMkODM=; b=wbbqXwaRIhzYku91zaZ4ED6ry41epr79wjE2taojgHpstF8iUS2YQ8X9nt53FAzpv0 8LsdG8RbjugSXqlhYYeV/kQue4MOvimq9fYMMGtFU/iyyKs+oyNmIOHSMEUlf5KdJQsh TcLmKsJydydNAFlOdacMWhpBR9Fq94I6Cmelol1gm9z4gXH3RAcw2RTJblO/rUKBCL+T 8emLgXA2zD+tE8IfcrTmVAqgJFSWMUo1ZopZm17xmCQJa1kdwEK4b6zJy5TN9HiDlPQh T479brzNbaFQHLU8R3wQhPpFS/LkUWatfGI3f/kafePBxa49x1ylVzbtoN/jZzA+8bHZ NJNw== X-Gm-Message-State: AOJu0Yz+OL4BceEGYN0ZlsfNUJA8s+ORyh4amU/C5d1X2vXoG12Rkz/l 4RB4swcqETUD2dIkYYY4prl0WsKPyHU= X-Received: by 2002:a17:902:ea8d:b0:1c6:19da:b2a5 with SMTP id x13-20020a170902ea8d00b001c619dab2a5mr481087plb.32.1695889900154; Thu, 28 Sep 2023 01:31:40 -0700 (PDT) Received: from dw-tp ([129.41.58.7]) by smtp.gmail.com with ESMTPSA id jb22-20020a170903259600b001b81a97860asm14505674plb.27.2023.09.28.01.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 01:31:39 -0700 (PDT) Date: Thu, 28 Sep 2023 14:01:34 +0530 Message-Id: <87msx6r95l.fsf@doe.com> From: Ritesh Harjani (IBM) To: Kemeng Shi , tytso@mit.edu, adilger.kernel@dilger.ca Cc: ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 01/12] ext4: make state in ext4_mb_mark_bb to be bool In-Reply-To: <20230928160407.142069-2-shikemeng@huaweicloud.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 01:31:54 -0700 (PDT) Kemeng Shi writes: > As state could only be either 0 or 1, just make it bool. > > Signed-off-by: Kemeng Shi > --- > fs/ext4/ext4.h | 2 +- > fs/ext4/extents.c | 4 ++-- > fs/ext4/fast_commit.c | 8 ++++---- > fs/ext4/mballoc.c | 4 ++-- > 4 files changed, 9 insertions(+), 9 deletions(-) Looks good to me. Thanks for the patch. Feel free to add - Reviewed-by: Ritesh Harjani (IBM)