Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Andrew Morton' <akpm@linux-foundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>,
        "'Matthew Wilcox (Oracle)'" <willy@infradead.org>,
        'Christoph Hellwig' <hch@infradead.org>,
        "'Jason A. Donenfeld'" <Jason@zx2c4.com>
Subject: RE: [PATCH next v4 0/5] minmax: Relax type checks in min() and max().
Thread-Topic: [PATCH next v4 0/5] minmax: Relax type checks in min() and
 max().
Thread-Index: AdnqB/CwAvMQ3gkdSO607JUF4aSKdgHV/OwAACCvOXA=
Date:   Thu, 28 Sep 2023 08:10:09 +0000
Message-ID: <0b03cbd61c104b1db0848f3ad900a2ea@AcuMS.aculab.com>
References: <b97faef60ad24922b530241c5d7c933c@AcuMS.aculab.com>
 <20230927103014.683e41b855cb2cd4ea163fa5@linux-foundation.org>
In-Reply-To: <20230927103014.683e41b855cb2cd4ea163fa5@linux-foundation.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Andrew Morton
> Sent: 27 September 2023 18:30
> 
> On Mon, 18 Sep 2023 08:14:40 +0000 David Laight <David.Laight@ACULAB.COM> wrote:
> 
> > A quick grep shows 5734 min() and 4597 min_t().
> > Having the casts on almost half of the calls shows that something
> > is clearly wrong.

Thanks for taking these.
I had a horrid thought they were languishing again.

> My preferred approach to fixing min() warnings is "the types are wrong".
> But often getting the types better is hard.
> 
> Is there a plan afoot to go around existing code doing some
> min_t()->min() conversions?

Could get tedious given there are 4500+ min_t() out there.
Also every one needs looking at just to check it isn't relying
on the cast - a few do,

But they could get reduced slowly.
Not adding more would be a bonus!

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)