Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 28 Sep 2023 11:38:38 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     David Laight <david.laight@aculab.com>,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        Jason@zx2c4.com, hch@infradead.org,
        andriy.shevchenko@linux.intel.com, akpm@linux-foundation.org
Subject: Re: + minmax-add-umina-b-and-umaxa-b.patch added to
 mm-nonmm-unstable branch
Message-ID: <b1198988-b60e-41e2-99bf-6af145e1d201@p183>
References: <20230927173033.AF86DC433C7@smtp.kernel.org>
 <d74a3644-1d03-42c7-b258-4d5d63416ee0@p183>
 <ZRSJ5QMNGV7ObfrL@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZRSJ5QMNGV7ObfrL@casper.infradead.org>
Precedence: bulk

On Wed, Sep 27, 2023 at 09:00:37PM +0100, Matthew Wilcox wrote:
> On Wed, Sep 27, 2023 at 10:21:41PM +0300, Alexey Dobriyan wrote:
> > On Wed, Sep 27, 2023 at 10:30:33AM -0700, Andrew Morton wrote:
> > > +#define umin(x, y)	\
> > > +	__careful_cmp((x) + 0u + 0ul + 0ull, (y) + 0u + 0ul + 0ull, <)
> > 
> > kmin() and kmax() are (of course!) much better names.
> 
> it's unsigned, not user.

Yes, but the same idea applies to signed types:

min, max require identical types
min_t force type
kmin, kmax are relaxed min/max versions if signednesses match.