Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <04e28f8a-1393-d991-264c-b0592746c123@nvidia.com>
Date:   Wed, 27 Sep 2023 20:30:59 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.14.0
Subject: Re: [PATCH] hte: allow building modules with COMPILE_TEST enabled
Content-Language: en-US
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     timestamp@lists.linux.dev, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>
References: <20230911094604.14179-1-brgl@bgdev.pl>
 <CAMRc=Mc2Yo61uivOWHagR2Raxh11dBb=S6jtCDu8_-csX3ozvw@mail.gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <CAMRc=Mc2Yo61uivOWHagR2Raxh11dBb=S6jtCDu8_-csX3ozvw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N25jVmJDaVEzMGlvVWJDZ0I5ZzhEYmo2OG5MN2RJaXJwSER4RlprcGF0ZXov?=
 =?utf-8?B?cHQyMTdIS3NJeGM5T3Q1TFFJcXh0ejRiWDAvVlJJNUNMNzFydVgvSWZKU2o3?=
 =?utf-8?B?djRyOG5ETkJZTWZqK1AyeExud3ZsY053VjlrZXBrSEl0Z3djVit2dFNkVUZW?=
 =?utf-8?B?RHoxU1pMTHNxK0lSczFacnc4RThVV3dMZzE5Z1JxVmFvS0dxTmRuMkJwRXhn?=
 =?utf-8?B?Ny9aTFpVR1lPRXFxZVZvU1NQNlVReHdERUtCNEhORk12ZWZDbnVjZy9rQW5V?=
 =?utf-8?B?eFA5YUhoY29OOHRhb3JsQzdBRXl3a1hua0dBbmgzYjF1ZWdsR0EyajVLQzhW?=
 =?utf-8?B?QzZhRit4b1ROMEVtdndsT1dKVDU5bFpLSU1oSzQzQ0ZhTWJWR2V1T1kwZFlQ?=
 =?utf-8?B?bjdXcW9ld1l0WkgxQkN4WXVCUXp6Tjl3aWhWc3RCMWE0MzgvVkxPQlRiL1h2?=
 =?utf-8?B?UkpQM01MbDBhN1hSSXZqSGtuYmhQM0VpWTltbStMRFowcUk3eDBlSzFuaTRR?=
 =?utf-8?B?SGFkeGpGQy9xYXNTbEtsYmxuRm9YS2Z3S1AreE9UQUVhbDlGYXE2MWtvV2Jx?=
 =?utf-8?B?K1YveUY2Zk1XUmQybnhPVWtKWGppZHp2Yk9CMC93eHVqc1ZYQWdKS3hRdHRC?=
 =?utf-8?B?eS9zSVNwcUlqTThOZUlhUkpyVDBhUmFvMENoT3BheWp1UzF3WW01QmRXQzBJ?=
 =?utf-8?B?UGVycGtwMGhQQ2MxaU1KV2Y4OXlhUFVWQ2hyWElTL29TVG9tWVJRcERVK0RH?=
 =?utf-8?B?SEJwV3NqZFlPeVQ1YVhVTElNc3VYNTlWZ3dFNDRsWnVxTHVuWm9ETEI3dS9m?=
 =?utf-8?B?K0pzdjAxU2Y3cDlQMGdCVGVSVmJjanh4dkRwcXpQMzQyQSt6YUY3ODdZaXBR?=
 =?utf-8?B?Q1Z5QWI5UGJWaXFxSndZdlpVMFdLVVdOSHFVZ2kxMlBmb2tKNGdFSUhLaHFo?=
 =?utf-8?B?Umo1UzV3NGJVT2cvbTFXOGZFajNXeGtNVmlPOE96b2lnVzB5U1lXM2pyVk9P?=
 =?utf-8?B?UnYvenNudmpGcmwyQ293NEd6L3VRNm0rRHI4VTMxZmNacFNtNXRxUXhuQ0lI?=
 =?utf-8?B?cmJKOHlIRmRYUnJrdFlmK0JxVGo2bVU5TzZTbEdyaWh4V3M4bnk0YUtJZmR0?=
 =?utf-8?B?SkMzb29XbkRPdk1MRGdhOTdzbU1GaUhPWjlheHROazZ2Wmpab1NkNnQ1dHVS?=
 =?utf-8?B?NEhrN0o0cVhrV05uVFFOUXZJQlQ3dDNpYUpyT1hhcnA5RUVzTGw0aXUxeDR5?=
 =?utf-8?B?R2tVQlFJQjYvakVFQm1CQ2xSbVZ5T05vcHROUUVwb2RLQmUreE1DTEhkemtk?=
 =?utf-8?B?M3FwY0FJdzRrdml4V0VTMWFkT3I5RnhHTXBsZnhFS2FnYVZDYkZwT1JGd0F6?=
 =?utf-8?B?NnlXM25pRm1adkNRK0czYlhDWVF3emllNVN0QzdXb1MrKzZKZFJ0aTNzYmhj?=
 =?utf-8?B?ZTZrMVVjSjk2bjNwTGxFanZhbUZoaGRFaENYSVlYdHRmUGFldTJ0dTNaYUUv?=
 =?utf-8?B?OGQrenVoQUV3TFNNbE9tNSswREpzS0JKR2hVRU8rb3pFQ3p3SmVCYUtldExz?=
 =?utf-8?B?RnRBY05zTE1hMVBjaUVzSEt6TVhiaThMNEJJd0llMnFJVGRIbTN3U1F6SFZy?=
 =?utf-8?B?ODQvWFYyZmRCOWJhcm9TS2dveFBBYXRGMG9MM2lzVzJqZmFlOWdRRzlKUC9E?=
 =?utf-8?B?WHdBMDJuVHhvMVZsZXRTZHFhdllnNjE4MDV6d1BWZ2lzUytYL29zQm9hZ2Ru?=
 =?utf-8?B?UDVPeThsQ285K2F1dFQrb082WndwT21mTTZjUXp4ODB3YkFqdlFTREV3ODgw?=
 =?utf-8?B?UXljeHY5cFA3dFFjUWpwRTZxaW9iMVhMU2xQb3crRFc2SWthTWcxVmpJamFz?=
 =?utf-8?B?Y3lJemhUQ3pYbzRieVhSd2paSUFlZnRHL2tiWjlYWDh3d0sxTFJpclNWejkx?=
 =?utf-8?B?YWU4aWJ0U0tLQ0gvVkwvNzZsZ0NpTEV1cE9PYXNxNWVvNFlVWGoxN1Vxc0Fr?=
 =?utf-8?B?RWVTUk94M2lIQ1ZKbUVPVnVtcyszTzN1dTNmZ2RKUlAyMzNMLzRNQW82VjFQ?=
 =?utf-8?B?bWFsajdtNDVWOVBpU3QvWW9GaVVxWjRCS3Z4ZXR6ZTNnVjhISGlBdm5tUmdp?=
 =?utf-8?Q?jvhflzn3/HaRgLqzwWV1jf+su?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b95ed42-5b44-4818-e214-08dbbfd356f0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6607.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 03:31:02.2168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: atH8AXlsL8OsH/ICry0iShZ7og5Enp8ftrssKNd+K6RM8XTmw4nqsvbrEJsnSe734lpr5CQqmNRJxNAjTMWFyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8913
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 20:31:29 -0700 (PDT)

On 9/25/23 1:37 AM, Bartosz Golaszewski wrote:
> On Mon, Sep 11, 2023 at 11:46 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>
>> Allow building all HTE modules with COMPILE_TEST Kconfig option enabled.
>>
>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> This was part of a wider series but since this is independent, I'm sending
>> it separately.
>>
>>  drivers/hte/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
>> index cf29e0218bae..083e67492bf2 100644
>> --- a/drivers/hte/Kconfig
>> +++ b/drivers/hte/Kconfig
>> @@ -16,7 +16,7 @@ if HTE
>>
>>  config HTE_TEGRA194
>>         tristate "NVIDIA Tegra194 HTE Support"
>> -       depends on ARCH_TEGRA_194_SOC
>> +       depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
>>         help
>>           Enable this option for integrated hardware timestamping engine also
>>           known as generic timestamping engine (GTE) support on NVIDIA Tegra194
>> @@ -25,7 +25,7 @@ config HTE_TEGRA194
>>
>>  config HTE_TEGRA194_TEST
>>          tristate "NVIDIA Tegra194 HTE Test"
>> -        depends on HTE_TEGRA194
>> +        depends on (HTE_TEGRA194 || COMPILE_TEST)
>>          help
>>           The NVIDIA Tegra194 GTE test driver demonstrates how to use HTE
>>           framework to timestamp GPIO and LIC IRQ lines.
>> --
>> 2.39.2
>>
> 
> Hi Dipen!
> 
> Any comments on this, the other patch with a comment update as well as
> the one addressing usage of gpiochip_find() in HTE drivers?
Sorry for the late response, This looks good to me. I will review and test
rest other patches.

> 
> Bart
Acked-by: Dipen Patel <dipenp@nvidia.com>