Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 28 Sep 2023 08:53:19 +0200
From:   Luca Ceresoli <luca.ceresoli@bootlin.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Prathamesh Shete <pshete@nvidia.com>, thierry.reding@gmail.com,
        jonathanh@nvidia.com, linux-gpio@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pinctrl: tegra: Add support to display pin function
Message-ID: <20230928085319.0b09bf7d@booty>
In-Reply-To: <CACRpkdbZ0cxA_y=6j_QQpF1SQ1q4hw-qUyeOnEK-+cLBd=gjCg@mail.gmail.com>
References: <0cf720bf-ae4b-5780-bda4-5c9bbb2d1d67@nvidia.com>
        <20230714113547.15384-1-pshete@nvidia.com>
        <20230925183049.10a40546@booty>
        <CACRpkdbZ0cxA_y=6j_QQpF1SQ1q4hw-qUyeOnEK-+cLBd=gjCg@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Linus, Prathamesh,

On Wed, 27 Sep 2023 10:54:15 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, Sep 25, 2023 at 6:30=E2=80=AFPM Luca Ceresoli <luca.ceresoli@boot=
lin.com> wrote:
>=20
> > The symptom is that i2c3 is not working anymore, the I2C lines being
> > always high. No other known issues at the moment. =20
>=20
> Hm....
>=20
> >> +     {"nvidia,function",             TEGRA_PINCONF_PARAM_FUNCTION}, =
=20
> >
> > FYI, I reduced your patch to only this line plus the one in the
> > pinctrl-tegra.h and the problem appears as well. =20
>=20
> I think there is a conflict now, that the pinconf is "stealing" the funct=
ion
> assignment from the pinmux call.
>=20
> It's just a debugprint, I will revert the patch, Luca can investigate and=
 you

Thanks for the quick revert Linus.

> can test a new patch then we will merge that.

Prathamesh, if you send a new patch it would be great if you can Cc: me so I
can test it.

Best regards,
Luca

--=20
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com