Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-id: <e67aec21-eb9b-4133-b879-7b2b6d03f50e@augustwikerfors.se>
Date:   Wed, 27 Sep 2023 22:19:12 +0200
MIME-version: 1.0
Subject: Re: [PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
Content-language: en-US
To:     Sven Frotscher <sven.frotscher@gmail.com>
Cc:     broonie@kernel.org, alsa-devel@alsa-project.org,
        lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        mario.limonciello@amd.com, regressions@lists.linux.dev
References: <O2TN1S.57QJOL6TXOBC1@gmail.com>
From:   August Wikerfors <git@augustwikerfors.se>
In-reply-to: <O2TN1S.57QJOL6TXOBC1@gmail.com>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 8bit
Reporting-Meta: AAEINYZ3dhLONaY9tyI3lZesZ89O1+5jgsVyp4dMSkyYuppG/dP70jN8lViyntJq
 I5DRJNIssIA14bGdujZ1fmSb5GPSDteTcc1b5M5e2YFhy0vdZXH0wyHnib2xRlaw
 5FjQ3xEzAHQ/B+HcNRbV2ZxsHA3tcPdEknFp+e75IcTgcRWeHElJ3e0pz/e7PCR4
 FHyQ+p3JJ7gEKim1O0stnQDZmknsT4AHTv80xo3eIHTaGX0v8bZNqKFcf+8Zvwpp
 8TBggYhu8XSuUYtTB2VFyG3YvX4iV2oNxW7ekW7aGxxsHo0DfilST3Lm3bKg1sR7
 jd099pLdX3hRLS615u9wGdRlLr18AcfxlC3YAp1QoNddj/sk0hZX8Im1cZR0aRAB
 4ohIa40N3sOHy//zCy1rTjcCFEBghrf/ZwtLQvmI8S/23l0kmM7GxDENnr3ekdJ7 YXbnnro=
Precedence: bulk

Hi Sven,

On 2023-09-27 21:35, Sven Frotscher wrote:
> 
> Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8)
> requires an entry in the quirk list to enable the internal microphone.
> The latter two received similar fixes in commit 1263cc0f414d.
> 
> Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 
> 82SJ")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sven Frotscher <sven.frotscher@gmail.com>
> ---
> v1->v2 changes:
> * add Fixes and Cc tags to commit message
> * remove redundant LKML link from commit message
> * fix mangled diff
> 
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 3d8a51351e29..e3d2b9d01552 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -241,6 +241,13 @@ static const struct dmi_system_id 
> yc_acp_quirk_table[] = {
>          DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
>      }
>      },
> +    {
> +    .driver_data = &acp6x_card,
> +    .matches = {
> +        DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +        DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> +    }
> +    },
>      {
>      .driver_data = &acp6x_card,
>      .matches = {
This diff still doesn't look right, some of the lines are indented by 
one tab too little compared to the original code. Also, the e-mail is 
sent with format=flowed which git am complains about:

> warning: Patch sent with format=flowed; space at the end of lines might be lost.
> Applying: ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
> error: corrupt patch at line 15

It's better to send patches with git send-email to avoid these problems.

Regards,
August Wikerfors