Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 28 Sep 2023 08:06:47 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
CC:     <shuah@kernel.org>, <fenghua.yu@intel.com>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] selftests/resctrl: Bug fix and optimization
Message-ID: <kisdkc4pa4fbmkhartsmwbg2lhxl2co3ude7bzrbpubn6r3a5a@xtki2amirkhx>
References: <cover.1695369120.git.maciej.wieczor-retman@intel.com>
 <ec0a63fc-081a-a4bf-8ebf-d501b1d44cc0@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ec0a63fc-081a-a4bf-8ebf-d501b1d44cc0@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?nI9rFmJTOX5+tT/F/PkH4RkE1sve5n2vx4nuk8+SjUc9935MgjqrI93qHF?=
 =?iso-8859-1?Q?YpmAju+MNJlXb1PCHBwDBP6T4xq3SSvtmXCv0YU1/j9EtRTViu4Saj1eNn?=
 =?iso-8859-1?Q?RbLDmHDp3secKMmfRVFgD1eHR1NNdWwoFgC0HsnX2rAAt1tZ4s7Xsx8Oy6?=
 =?iso-8859-1?Q?rJQsPBM0vNKcg5wyKNStpc8+EJ7wOeKZI1ckghoJrn8e9/heqjBto90ToK?=
 =?iso-8859-1?Q?9ZsDME6Tzq6SWA99EVBgkP/kZmuyFKPIs4f8Cx+KuEM9n6aIljpiPVcD6W?=
 =?iso-8859-1?Q?XN7Q6mLI35X3VvQxNIzzVBdhv0NpYvhjz+2w2D+ZadVErF9daSEykxc5EP?=
 =?iso-8859-1?Q?p7EdZ+cetsACzlfame1mwACglSsqvsSJLa7NwiawCK1VfW9JIAGHbLFBj+?=
 =?iso-8859-1?Q?PV/P6MZ/oG1LDkFwHM/uUGljkkS/hlqggY59NjEghFudZWfiSAzqolU0Kz?=
 =?iso-8859-1?Q?IX/t/ybaQnQXdA3Dpd1QU+ZRJarPdPax5i+NpEVPJz1lbizHRmbVtLnfep?=
 =?iso-8859-1?Q?GkmQ4NCy3FWCYGTXDQfU3m+vnpKeMewFLh4gcIS0LZNzPiqsPdXtqBn6NU?=
 =?iso-8859-1?Q?wGo5LVOsAgDCb4o2TkCZY/mqDWDqAheO64vukbZwdX2xFPKkGUpJfphcoM?=
 =?iso-8859-1?Q?pjheF8K1lFXzZxjtsv+bqRAUT99nZBxnh6yRB7VF63gDUdmQQma0WPOAWR?=
 =?iso-8859-1?Q?OwPlQkLpkmRsTemAQRs1/2f159o296CS9VSPEkEUGMHjvx9cKiz8onzGxz?=
 =?iso-8859-1?Q?ewie0GNyr00bp2R2or8PH+4RXg/1cpd8wDwCpWd6Xwrrm1LeAp8pWKVU9H?=
 =?iso-8859-1?Q?cWJFvxqMVbMA6cjCEHSqA6bqMtIBsBuWYANyKwTAX+JnJvASdO6athwlGB?=
 =?iso-8859-1?Q?aZrQbZOQ7Vzs/S72ANWcuo7zo1qUQuESkRYTV/0v0rQD71zY0SJJSIQaaj?=
 =?iso-8859-1?Q?/f2eAPSYL3lWOZ9XxTAqodZIh7v/RmVS6xe/QlOm2ysMOSgXphAeKxr7U6?=
 =?iso-8859-1?Q?Z6AaOsweKPV9E6hRhMcknTR7wDLDL6lfW6l4j9P9wRah8rqlVPmzP1Ox6O?=
 =?iso-8859-1?Q?hu1bbijSkNFtfn7dj91pc1MQ2uWItctHp6JqpiMsAE+ubZJTiBwAMGYgaP?=
 =?iso-8859-1?Q?RfhX9hEGp6FfjqpttHzhPfcWGo3amj+IU56DKWe90XLpCso8cKDu9afMM8?=
 =?iso-8859-1?Q?HRL002gRh8GfPAlk1klsrhuB1ECWJq7Z+IlWfH9x+iE4FMlDNpN6iz011T?=
 =?iso-8859-1?Q?7p5lVDzShRnvR/fxJItgQ16//IkhfzXKy8XRSi2tUgiRtzqJ17NQTuIz4n?=
 =?iso-8859-1?Q?F4E9RaTAXk6MZY2mb3QplTx10d0+iejFHkFF6SBOvN+bBAce6CNRlZm1Vr?=
 =?iso-8859-1?Q?VEt2m/2reDDaTzE5H45eGclJ7nzHfIMJycGLy8cwmW29VroAydJQRX87RX?=
 =?iso-8859-1?Q?drSPFf0Ib/uLG/xCu7wWF4qgzfuavH1HAbkOlnjCPeQH67YQlN50n/dHrf?=
 =?iso-8859-1?Q?6Ou98F6orx5Bk6o9qMf/Kbj9viOE/aYzxs7JpHXNwqSJRXTjMUpA+xPGKt?=
 =?iso-8859-1?Q?fWS3qpCVRN2qQkQCSlaBQQo78CedyHwjdsWq4hxXCrIwu/9taqEMKnJ98E?=
 =?iso-8859-1?Q?I4uJJTeyFc5WnETQHqKZUB9SgMXApr4ycIyNQRU18N27c5rH/RYq12YXNB?=
 =?iso-8859-1?Q?6Tr87s2/L+mQWhJ2Vs8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e1fc7a3b-98ef-416a-87dd-08dbbfe91bff
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 06:06:52.6281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3tlU3jJF29M0cp1PR83it6MOfGfemoh9Y85LkY3CO5bQzQZ159WHZUBqArX2jmvYsOAKD3JXi0xr39AvQEJe5/QGSlUcOjX2152wFcgUc94=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7389
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 27 Sep 2023 23:07:12 -0700 (PDT)

Thanks for catching these, I'll remember to do that the next time.

On 2023-09-27 at 15:16:18 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 9/22/2023 1:09 AM, Maciej Wieczor-Retman wrote:
>> The resctrlfs.c file defines functions that interact with the resctrl FS
>> while resctrl_val.c file defines functions that perform measurements on
>> the cache. Run_benchmark() fits logically into the second file before
>> resctrl_val() function that uses it.
>
>nitpick ... if there are comments in one patch of the series please consider
>if it applies to other places in the series.
>
>> 
>> Move run_benchmark() from resctrlfs.c to resctrl_val.c and remove
>> redundant part of the kernel-doc comment. Make run_benchmark() static
>> and remove it from the header file.
>> 
>> Patch series is based on [1] which is based on [2] which are based on
>> ksefltest next branch.
>
>ksefltest -> kselftest
>
>Reinette

-- 
Kind regards
Maciej Wiecz?r-Retman