Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3194604rdh; Thu, 28 Sep 2023 05:35:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiBIB7BO8Ey/46NH/bpO3zdCej/IN79c0HiMZa4a7TJTWyBE977vCdsCcnZ8E8Pz8Djmxo X-Received: by 2002:a17:902:a417:b0:1c3:323f:f531 with SMTP id p23-20020a170902a41700b001c3323ff531mr950583plq.20.1695904520264; Thu, 28 Sep 2023 05:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695904520; cv=none; d=google.com; s=arc-20160816; b=AtSzBeK8rpg7uSk26GruORTMwfcyRq1vzIujTbrRPw8S0ECwCZAbyBTW8LyHt6lAwQ D3mB50kZRdXlhxCkZ76UXuFUIqC98/ZatISbdwPbaQycPHbqvpso22R2Iz7Gg+CMiJ1u w2XCNh5egPDP8kBedafwGEgB5RdW2RuH9JVNhNsRDiW00oCpi0tvF2Vzg0OAHNF4H68M kfFuBY/7bZ2Zm/tA39hk+Llb/AoFJW8lBDt8B70/769OqQ49UQHr4VJlAvtwlUBK99g4 pmHC+KP5BZWKyQ/MPj9qYc78qUGeZcbCKnTYqh02JZYZkrduZkHPMkiLrmwG4GIblK6x z4/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=A9VjI2n8hqtgoxH7xmMF+d2/mxuNpn/NUYetgidyADM=; fh=gWeUH/kXTdQen/xvn0f6MiiWyYdvwAQC8Bw9RCEdYa0=; b=y4x/OUWzC9QR2R52eiHuzgwX+WKjOj+SoaFQiCpg+vi6lrTBtEsWhUgsE2WCGzU2AW +ogw5btdJbr/2LL+ZNZHRj+cqrnP0+xlSoLTTfmHE9e5RB7aIImwNmWBZACjYkj+cn2N HUuIAgGhuoU27OQgC9oTbwZDPHyReg3j4xAYUxQaq2RNs4RL+drsuxSyKT6d1NWXfAas Ej2CtMteooF5zoDeYktig/kQq83aHhYKWAbbA8lsrzGlbVEsHtgWxYM6q8j9FRO8RT3g OxsN6mYzVGfwjYceW5aUTKAExY9ILIlb66/p6S8agodJ2iegRJIU7x8wVM+BY8VUKeen 5Oaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o75VWMvb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id b11-20020a170902d50b00b001b811261289si20317958plg.482.2023.09.28.05.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 05:35:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o75VWMvb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 70B30828DFE8; Thu, 28 Sep 2023 05:34:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbjI1Me2 (ORCPT + 99 others); Thu, 28 Sep 2023 08:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjI1Me1 (ORCPT ); Thu, 28 Sep 2023 08:34:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91A3139 for ; Thu, 28 Sep 2023 05:34:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF1D0C433C7; Thu, 28 Sep 2023 12:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695904465; bh=lIDMdnTxQP7t89OuJ29zkIG40XJQFpyQ/rEb/H/3OIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o75VWMvbbbKxQKo1vCy3d5UsaSBKlD+JydA226K3A+uLdwMZ35vrCAVmaXBqm63SI p1hAzFivx7QnKpLR/0/O7t9U4c5y4WyJVY7GYX+ONBez4mPAc0/eBJtPPWyyMeU8iz N1rgu98RN7CALLziTxkjyhzSKokSnTdN4qIEhSHGoRzgzsX0mBvhKu38ltj+qUayrT SiqDRZSO+Y+8PjlzzdmwOeqHpcAXRp7h/ZQGhBCG8ZeMChC00ttBdIMhApSozFZKns 5h0bqiF6eJHIJrIqyWb0mAhf3BFgIM+HgGgT+wG2IYa79cfhgxSROZWy6YgvnYPJS6 cVjZV+q8ejSFA== Date: Thu, 28 Sep 2023 13:34:19 +0100 From: Lee Jones To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Mark Brown , Zhiyong Tao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH v4 01/12] dt-bindings: mfd: mt6397: Split out compatible for MediaTek MT6366 PMIC Message-ID: <20230928123419.GG9999@google.com> References: <20230928085537.3246669-1-wenst@chromium.org> <20230928085537.3246669-2-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230928085537.3246669-2-wenst@chromium.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 05:34:35 -0700 (PDT) On Thu, 28 Sep 2023, Chen-Yu Tsai wrote: > The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has > a different set of regulators. Specifically, it lacks the camera related > VCAM* LDOs and VLDO28, but has additional VM18, VMDDR, and VSRAM_CORE LDOs. > > The PMICs contain a chip ID register that can be used to detect which > exact model is preset, so it is possible to share a common base > compatible string. > > Add a separate compatible for the MT6366 PMIC, with a fallback to the > MT6358 PMIC. > > Fixes: 49be16305587 ("dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC") > Signed-off-by: Chen-Yu Tsai > Acked-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Let me know when the other patches have been merged and I'll apply this. -- Lee Jones [李琼斯]