Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <90091a63-df01-c5d1-1b7a-42d852cde276@amd.com>
Date:   Wed, 27 Sep 2023 16:51:32 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v10 03/10] x86/resctrl: Rename rftype flags for
 consistency
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Babu Moger <babu.moger@amd.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-4-babu.moger@amd.com>
 <49c10592-5e95-30cf-7bfa-7105a16bc315@intel.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <49c10592-5e95-30cf-7bfa-7105a16bc315@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTdmcnJ3WWxJSitpTm9uenpTekZxUm16M1lJSnIySFYvSWN3dWNnYWljWm1U?=
 =?utf-8?B?VXRnQlI2Sk5NRkQyQlZ6cUFTNUlJOHdOSlU1MVBIMnJSc3B1cWdEMlNtU2Qx?=
 =?utf-8?B?OHhqL0dyR3d3UzF1aWErVXB2dFZoRm9CeFZmdXFnNWMralNnK3R2UytDUFhz?=
 =?utf-8?B?UHpxSXZZb0tCc016S3cwcHFTeW5Gbjl0SzU1bFczVWpiWjhycTFZU0NHam1C?=
 =?utf-8?B?dEtFbHBnaTFidllVYWx6TWRNYjFvUkEyUlpFc1ZDWFRWZTk2dkdZNzg3ZFdq?=
 =?utf-8?B?NEt3Zm1yTWs3M28rWERTRlptRTQwSGxNNXlLMUNnMTY3WkZ0RzNxekR2bXZB?=
 =?utf-8?B?eTZOUlFxdHBQd05Zb1hsZTdBYUpoK01MQTdXa1NZVHBLeENiU3d5MFY3a2Mw?=
 =?utf-8?B?Mk84bUpFSkdkVWJVQkdCRk9VTkN4Z3VGY0gwWGhWbjRYR0xOYzdDM3ZnRnlh?=
 =?utf-8?B?aFRFVFUrazVvVkRGQlJ1eFhvWWFPSzl1L2M4NlVCMElKWFBuajVqS2tKOWZX?=
 =?utf-8?B?SG43MGl0T1ZHOWRNcVhNQnJRWWVJblR1Z2xibmNDTmtFckxHYm5PajhPTjN4?=
 =?utf-8?B?QUJJbDdFNWM1bng1b1RrOEVROThPTmlrQnFVU3NjYlYyNklrSUROWFR5N1pZ?=
 =?utf-8?B?REVraG5LcjNCWEVjMnJwTkZYcTNjMnlkMkROLzdxdnBBdWZXUGdoVy9LT1NG?=
 =?utf-8?B?dDlNaHdvQ1pZa3pPR3MrelFDVjRKM2dDdyswM2llOVJzR0x2MWw2ZHNwclFq?=
 =?utf-8?B?MTFFSjgxRUwxdHBmMFVPLzdLRWEwU1JmWkpWaTNGYWYrckJ3eXg0K1QxNmZ2?=
 =?utf-8?B?SjNZWTRud0pyRDFNV21KYnBLdkJDWWgrVzYxSUthc1NjODZ2SmRUNGdTQW9J?=
 =?utf-8?B?aFhKNU42YTBwWlRDdTZUaURJbnE2Vm9SYUYrcmRTWXRsa1hGVVBURXpyQjRO?=
 =?utf-8?B?UUNOR3R2ZSt6Wk9CaDNlUlYrcXRzREk4SVFXSHordE43bUE1Q2xDbmd4NGhR?=
 =?utf-8?B?c2U3TG0vc0RGOHd2cW9hdCtRcG5kYzB6dmxNdzZ1WFh5Z3Nnc0tuOGY1UUJh?=
 =?utf-8?B?TnBwdXpMcS9MWUFJR0UzeEhUQVBqWnQ3c05ZZ3c5OUVCWXltOWpCeDdGMXZX?=
 =?utf-8?B?d25XNzZSc0J3NWNzZVdSbC81eHA4WXliZnRpYVJjWDhOdmlWRm8xbTJKZDB4?=
 =?utf-8?B?R2pVME1BT29NWXNLNDdHK1RqdmxsWFVKRXR6K0JDWk1ubXdRb1RYUDVqeW1Z?=
 =?utf-8?B?aldjbDFHTUZ6d0ZQLzhVUTJyeUNMaDJZNmJubzlrdlpXTEVra05zZjNNeVc4?=
 =?utf-8?B?SnlpZmhpMTVDeUhnSi9Bd2JIS1dtVCsyVHhhbHdSQ0tHYStDVEVlMjFpTHJC?=
 =?utf-8?B?ejZXUi9rZTlrN2YvOW0yb1hiNFRka0ZvK2FoVWpHRkM0UlRueGtqTm5aczB4?=
 =?utf-8?B?b0xBQTJvcmhCTjBVNFZ3MUhHbFdTRmJUMW43M05qempBUDZTQXczZXhZVm40?=
 =?utf-8?B?ZWlNekdoQ2kxTFZ1SFphRlBVcGN6Sm1FNHd3RXRlR1hPdDBLdkgrWmRHZWJP?=
 =?utf-8?B?VkFCdjZubFZCaDZIS2xVdVo2ZytUKzVGQzBYalhmZnZjOE5XemdvRHRmNktN?=
 =?utf-8?B?ZHRkYzN1UTY5TXFaV1JiVi94N0RGeXJGeVptQkM1TEJWLzVvc0hPRHNjeXZ6?=
 =?utf-8?B?clREVzdIcVgwTkJYRzFlSEdhNmUwNmtXTk0xL1I0VElOek1pZjhtQk9TUmhY?=
 =?utf-8?B?VXlvVDMyV3p5ckhkVC9qUDRkdFhhdzdJN0ducFo1ZUw3OUdJbitNa0FjWTRq?=
 =?utf-8?B?UVQxN0Z1QWdrTVUyMGt4aEhTRmVJM0VuSmMrTlJGc3ZJUENuZDMrTGhwZDdk?=
 =?utf-8?B?T01JejlITXYyT29GcXAwNTBsYmxMQ3V0S0xXVVhjM2x1bTVrNHZIQ1hEZlZX?=
 =?utf-8?B?TDdTT3RyUE1vZ1B3YjVDak1uSTRiK3ZLOVJVeUNhQmxmK3VKaGg3NXhDSjgz?=
 =?utf-8?B?MVMwOUcyQlBoRzN3bUhOT0J5T3NjYTNob3FsdTRKOFUwUzMzek1aajdJSXhN?=
 =?utf-8?B?bk1FUm96bzQxY0w1dUdEaHI5TTBKalVMSzY4VG5UcDRIQkFuNjRnaGxEL3F2?=
 =?utf-8?Q?fMJA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d429afac-16d1-4440-3754-08dbbfa3ed1d
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 21:51:38.3530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z809PA5mPaNZoI4LLvbaobeGojTdXjsn/ESC2v9ak0JJQpSfBRm6Zz75+WClTYKF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8500
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 14:51:55 -0700 (PDT)

Hi Reinette,

On 9/27/2023 1:31 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/15/2023 3:42 PM, Babu Moger wrote:
>> resctrl associates rftype flags with its files so that files can be chosen
>> based on the resource, whether it is info or base, and if it is control
>> or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes.
>>
>> Change the prefix to RFTYPE_ for all these flags to be consistent.
>>
>> Also add the flag RFTYPE_MON_BASE, which contains the files required for
>> MON group only.
> This appears to be appending an unexpected (because it introduces an unused flag)
> change without motivation as an afterthought.
>
> How about:
> 	Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE
> 	complements existing RFTYPE_CTRL_BASE and represents files
> 	belonging to monitoring groups.

Looks good.


>
> Feel free to improve.
>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
> The patch looks good. With the changelog cleared up:
>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thanks

Babu