Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbXKMLLW (ORCPT ); Tue, 13 Nov 2007 06:11:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753017AbXKMLLM (ORCPT ); Tue, 13 Nov 2007 06:11:12 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:1067 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752677AbXKMLLL (ORCPT ); Tue, 13 Nov 2007 06:11:11 -0500 From: Herbert Xu To: kaber@trash.net (Patrick McHardy) Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode Cc: joonwpark81@gmail.com, davem@davemloft.net, w@1wt.eu, cfriesen@nortel.com, auke-jan.h.kok@intel.com, netdev@vger.kernel.org, djohnson+linux-kernel@sw.starentnetworks.com, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net Organization: Core In-Reply-To: <47397AB3.90705@trash.net> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Tue, 13 Nov 2007 19:09:23 +0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 27 Patrick McHardy wrote: > > I still think promiscous mode should disable all filters (which would > also provide a consistent view between accerlated and non-accerlated > devices), but an ethtool option is better than nothing :) I agree. People doing a tcpdump don't have to turn on promiscuous mode, that's what the -p option is for. In other words, having promiscuous mode disable VLAN filtering does not take away the user's options at all. In fact, the very definition of promiscuous is to turn off hardware filtering, albeit the filtering of MAC addresses rather than VLAN tags. So it would seem logical to have it turn off VLAN filtering too. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/