Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3231461rdh; Thu, 28 Sep 2023 06:29:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjbJOpTwB193ThqbP1OvY/S32hGnDzaYryuQdRzYbdAwTCbBCVh6ex4Ggam3YrQK+b2I7n X-Received: by 2002:a17:902:6b4a:b0:1b7:e355:d1ea with SMTP id g10-20020a1709026b4a00b001b7e355d1eamr1122110plt.24.1695907764946; Thu, 28 Sep 2023 06:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695907764; cv=none; d=google.com; s=arc-20160816; b=XJhuoNnbxTqgWrlvd7WPP1gSMGzOFCgBQK4OkzzX1PY4tsuzcK3OPYXhJgeAKU2Qex 0KgPuR/C7TuD/hbdd/ewW4nb85nC+QRpGeLT+oIfygM5TY+Q6RbXqsJGsqROmjg9C0Ho rCi29NplmSJ1ew0FgzXa0gkHI9yYvr5DXSMMUJOoDuozMXk4TLxsLctEoX8VyxSH1js+ CxFfY8V4zoBJvKw6JZ+uuSpnnerwWWPCRN0ixgfA1BlpD1ydUDNCdJcu5VTYoU23ffqs i5+sDHBoGJVxyO8fI+PKLlory/KJGv+L9yQly8ZT7QN3LmvAdMMHX+4AwOvSvT9ej5+6 UzIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hjfvIWhQ+m+q4929vlveX4zjXAL3hYK7PMFgGUVSELc=; fh=DWsu+nphnXaftKgW3nlltk1unhQS9IMzmZZBp0Uyh98=; b=W1puqQV+iteZKHHO4ABZBw5BP6Y/stnzvGOQlpV19+xPhV5J4sqGJuB1Znp65O5Lob Fc+ZbaC/s0mOn3fuoKT4JO41/mtZJOBy3XTQ6AgbQD9u/37JT+P9A6wN3LXzjQqEmzi1 JcK8r1v26FBgG6zfeK3X9p2iiCvfjEjY4RIFA9SSoaKPi4oBvgApFQHGA2F7vLH5ZPP/ h8ZBpmemHhgbnYu5L0Pn70Dvkvzla7g/gCW/DZnTYrzbKd3I/hxJn+8B8WsiU7jHZHUZ WLJUHi7OZjfyj0c5vv1EMUnuQrUE64UWTDJLbWBUto1SP54S4Jo+Iqa/qlCMgU23q8Nn HV0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id z1-20020a1709027e8100b001c61bd9db5csi9693315pla.317.2023.09.28.06.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 06:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id CD2188022E82; Thu, 28 Sep 2023 06:27:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbjI1N0z convert rfc822-to-8bit (ORCPT + 99 others); Thu, 28 Sep 2023 09:26:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbjI1N0r (ORCPT ); Thu, 28 Sep 2023 09:26:47 -0400 Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 754F819D; Thu, 28 Sep 2023 06:26:45 -0700 (PDT) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1qlr2M-007Wbe-KI; Thu, 28 Sep 2023 15:26:38 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlr2L-009JBq-Is; Thu, 28 Sep 2023 15:26:37 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 0DF2D240049; Thu, 28 Sep 2023 15:26:37 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 601D5240040; Thu, 28 Sep 2023 15:26:36 +0200 (CEST) Received: from localhost.localdomain (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 0DA0632071; Thu, 28 Sep 2023 15:26:36 +0200 (CEST) From: Florian Eckert To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org, kabel@kernel.org, u.kleine-koenig@pengutronix.de Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v2 0/4] ledtrig-tty: add new state evaluation Date: Thu, 28 Sep 2023 15:26:28 +0200 Message-ID: <20230928132632.200263-1-fe@dev.tdt.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Content-Transfer-Encoding: 8BIT X-purgate: clean X-purgate-type: clean X-purgate-ID: 151534::1695907598-3EC89A8C-CDBCAF2E/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 06:27:09 -0700 (PDT) Changes in v2: - rename new function from tty_get_mget() to tty_get_tiocm() as requested by 'Jiri Slaby'. - As suggested by 'Jiri Slaby', fixed tabs in function documentation throughout the file '/drivers/tty/tty_io.c' in a separate commit. - Move the variable definition to the top in function 'ledtrig_tty_work()'. This was reported by the 'kernel test robot' after my change in v1. - Also set the 'max_brightness' to 'blink_brightness' if no 'blink_brightness' was set. This fixes a problem at startup when the brightness is still set to 0 and only 'line_*' is evaluated. I looked in the netdev trigger and that's exactly how it's done there. v1: This is a follow-up patchset, based on the mailing list discussion from March 2023 based on the old patchset v7 [1]. I have changed, the LED trigger handling via the sysfs interfaces as suggested by Uwe Kleine-König. [1] https://lore.kernel.org/linux-leds/20230306093524.amm7o4ppa7gon4ew@pengutronix.de/ Florian Eckert (4): tty: whitespaces in descriptions corrected by replacing tabs with spaces. tty: add new helper function tty_get_tiocm trigger: ledtrig-tty: move variable definition to the top trigger: ledtrig-tty: add new line mode to triggers .../ABI/testing/sysfs-class-led-trigger-tty | 53 ++++ drivers/leds/trigger/ledtrig-tty.c | 280 +++++++++++++++++- drivers/tty/tty_io.c | 130 ++++---- include/linux/tty.h | 1 + 4 files changed, 396 insertions(+), 68 deletions(-) -- 2.30.2