Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3239891rdh; Thu, 28 Sep 2023 06:39:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEx+Rszs5bwur+9LaCpbM+DjaOycGYcRdVYB/b4oXGdjIxTtPo3QfnjbSSTonJN03a0QrZG X-Received: by 2002:a05:6a00:10c3:b0:68e:4303:edb8 with SMTP id d3-20020a056a0010c300b0068e4303edb8mr1220027pfu.30.1695908367586; Thu, 28 Sep 2023 06:39:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695908367; cv=none; d=google.com; s=arc-20160816; b=xrKUno7kTsL4JhORgBP9CcWfAudNHFU5GlDcEgeW+it0aT0cpYL3GHUBK5/ik+tQCj 1DsvjdSSMaRwPD/E+vPUcaXaikqQ1zQm7FIwnU7HNRa6Ihx5abbkEFhR/xFRTgf1nV+x X1x6ltnYtS+w0Y7BLxUrEb0TRQB8JBNmUc3PBAp5xyEtHsKKluJhncpDu9BfTqYwitoJ MyIz+qm9oThUzQQVPD4G5GkJcAvXpM/f60kvvQirLAo43DIm/W2Ca0poMKP6nFd7G/9S 0nS9lrMTQU+N1rdpIF5fg+P+LZygYYA1yIlNW2/x7zGGn3zPS9F6SQYKC7an16a9yWgv xrOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ZJGfzbzqsQolfNZxcGHUPFh9lMpJwZ49t/lm83zD2RI=; fh=ZF0eDKTvegzekvzFKRePbLH2Vhsb76O8i56rsbYQbRo=; b=IaMI/dM1QYIUD027FprVrQEJhBDLsclSM85DoJ8DbWWWuG6/EUdQmeyUxfzgvC42Z6 43Qtj7yBn31luwL8qlznPfd/V426pW5D7hg3IiaP9iuq+gdzX1ts/akIkb8bDAZaTsNd XhF0iR9vjQAQgSJyi6U2cOUsOsX8isfBPGe8DuOc0g0vDq/UpTZmY8pbHE61VWNesUIn vUiMYn4hlQjf84F9v99qU7lO/40xTLxzwAd6JWE4wSdQWAJb/aJc01wXCcfsQLbFVZTC nH0l0QdhxiPNyhQy4C4NV4XJXwH6wkCrXISeXA8IsWD0lBgiIeLm5JxpmXVZKB+QVfRF +a9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QOtchHqZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z125-20020a633383000000b0057d08dac754si6844495pgz.671.2023.09.28.06.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 06:39:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QOtchHqZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EE0498068956; Thu, 28 Sep 2023 06:25:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbjI1NZM (ORCPT + 99 others); Thu, 28 Sep 2023 09:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbjI1NZA (ORCPT ); Thu, 28 Sep 2023 09:25:00 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3FE5CCB for ; Thu, 28 Sep 2023 06:23:39 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE437C433C8; Thu, 28 Sep 2023 13:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695907419; bh=AW7dHkRQzx5w/sq3kpZwJmYTqaOBZOIX9xTY92Ig2Y8=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=QOtchHqZn1CmEVA5W3aiLlIdl3+qOTFuHZAVGibOYbGX6q//etgkDH+NqZYut6qFM fnLnxdSwmza+l49+j98oBfH1GRqVRJ7wSS7HREgCMjo1CTmdaviaaa9f8oLyxKQJdL mx3vMa4YVI1jpLqRli7qNh6RkgQf3u56pYIO06GDo+Dg9XnYs0m3gSmTxyrSyJHacF 0AgPl68kTiw/XwwdFn7CkEzm6eorZH4NBAEi9ERWtS7b/4Lp1T4/QcEXvYbI3MCVVf O5uVb5pRDy3RUIMV6WrLkWHtdPWJJwl/dNcdygIlgW7vVsNl0QuWagLXfiegS3V1VY 8DEs7Je0gYckw== From: Lee Jones To: Dinghao Liu Cc: Lee Jones , Qiang Ning , linux-kernel@vger.kernel.org In-Reply-To: <20230925024134.9683-1-dinghao.liu@zju.edu.cn> References: <20230925024134.9683-1-dinghao.liu@zju.edu.cn> Subject: Re: (subset) [PATCH] mfd: dln2: Fix double put in dln2_probe Message-Id: <169590741844.1593952.14473081444893949061.b4-ty@kernel.org> Date: Thu, 28 Sep 2023 14:23:38 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 06:25:20 -0700 (PDT) On Mon, 25 Sep 2023 10:41:33 +0800, Dinghao Liu wrote: > The dln2_free() already contains usb_put_dev(). Therefore, > the redundant usb_put_dev() before dln2_free() may lead to > a double free. > > Applied, thanks! [1/1] mfd: dln2: Fix double put in dln2_probe commit: 20890756e8753844de76afdf757cb74c6bab3e8b -- Lee Jones [李琼斯]