Date: Tue, 13 Nov 2007 03:36:11 -0800 (PST)
Message-Id: <20071113.033611.73195922.davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: kaber@trash.net, joonwpark81@gmail.com, w@1wt.eu, cfriesen@nortel.com,
       auke-jan.h.kok@intel.com, netdev@vger.kernel.org,
       djohnson+linux-kernel@sw.starentnetworks.com,
       linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when
 promiscuous mode
From: David Miller <davem@davemloft.net>
In-Reply-To: <E1Irtdz-0000DX-00@gondolin.me.apana.org.au>
References: <47397AB3.90705@trash.net>
	<E1Irtdz-0000DX-00@gondolin.me.apana.org.au>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 876
Lines: 23

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 13 Nov 2007 19:09:23 +0800

> I agree.  People doing a tcpdump don't have to turn on promiscuous
> mode, that's what the -p option is for.  In other words, having
> promiscuous mode disable VLAN filtering does not take away the
> user's options at all.
> 
> In fact, the very definition of promiscuous is to turn off hardware
> filtering, albeit the filtering of MAC addresses rather than VLAN
> tags.  So it would seem logical to have it turn off VLAN filtering
> too.

Ok.

The performance implications can be pretty severe however.
I wish we could address this somehow.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/