Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3261868rdh; Thu, 28 Sep 2023 07:09:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGamLbgczKTGNDIy/uEbslMc6cR/STRlGeqEubS9O+BybqLnVIQUplWyhwhlfSCWkSwhE6C X-Received: by 2002:a17:90b:1649:b0:277:4fda:c9dc with SMTP id il9-20020a17090b164900b002774fdac9dcmr1198361pjb.7.1695910187633; Thu, 28 Sep 2023 07:09:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695910187; cv=none; d=google.com; s=arc-20160816; b=pDIBFAQlVIc8kqrZaGPY+UP0Kbev5wigWCxutqUgS62GrGYgGhq4a1PZ6ILabPZu0L 83gSA+msNFihEwcmvBycBYNFoUVYgVlEpn9SXdTiOGMpPL9w8L8/l7cYmlGMJEUT4slt lEGxG62CQYxIw4RKhu39oby3mofalnxZ6Zo5JgeBKMQRLpLJRgCBN9DPluNROvRxDukn +rUFnrywmzWgPFLg74UqmaXELa+WGK9oMZFuxGqMhxbCZnogTI6SszwRjr8/68DUC2kS mUyXkDWQCBco6vB9npzvM+5auJ/PjCdoACKf48vA/0Ea7YPfGcLdNHMYBqWXMGjyAKuy u+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=iYQSq7QHiuiyS0dR9XMV5Ksd5EKV/hFTK+3dgExQusQ=; fh=yWm2k3OgTjRJE6sBXhb8CggRlS8it4Ec4FFh1W8j8Y0=; b=pPl2Cjhr6mOwYtdyhrThmzYVehdxgHESLYtx/ogIwI52kUUTxRhaxvUN558RxUgrLa sKVuEVion2jvQirr+Bp7PARvP4Hv/WwAT78YxAdY2veZ9skC/brZlevHXFQRhV6rZbQP 2taJjATFLzD6p1mxTmNrV2CSMXOXL0C6JR38OlhNvmf7RSVXyZ8BHuvHC5xj+fEjTBEy xRe+3hYVWiumgCBjhRCRk37tqbd0fxxEq2CCoLjnKpKBotzztEOwqWQHlOG64BDkKOL/ I84wMEPW0yuYAtEkZjK8i4p6Dv7ei59reczFnVlUPhNqSbBOmED1q5BTO94ISAr2rerl +9Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bNwNO/EY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id mu14-20020a17090b388e00b0026d40e6a7d0si20115739pjb.56.2023.09.28.07.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 07:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bNwNO/EY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3C31A8316EB7; Wed, 27 Sep 2023 22:26:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbjI1F0C (ORCPT + 99 others); Thu, 28 Sep 2023 01:26:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjI1F0A (ORCPT ); Thu, 28 Sep 2023 01:26:00 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A82DC122 for ; Wed, 27 Sep 2023 22:25:55 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-532c3b4b55eso15148522a12.0 for ; Wed, 27 Sep 2023 22:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695878754; x=1696483554; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iYQSq7QHiuiyS0dR9XMV5Ksd5EKV/hFTK+3dgExQusQ=; b=bNwNO/EYBK8s6FDhLgM5qdUp/Vksj8q3jbaCWL1j/6Bey4WRgApk5OFvUf0o54xk/1 BF71ItDmJreFBUkV6SID+UB4tpB5DLFIfob7IWVBLSg95L3uGWjjL7sQ/u4VseYVP3P1 ehpD08kOoDPiZjzqlRbzzgznrBJp+BK5Diy8hLRr2ruU4+tIHm9ENL6MQCIBIlm+NCIa Zr+sEo6Iz1acM2rFX34//S2TW/TV1BosOhRp6IfEgzdWHhQru8LPYW760Uzxvi8qIJVI wWVTp3SOc00vf8hTZsbZWfcMuXTCv+23xf2nCQ1Q3iKMXyx7ZGfBigbOq/AxYoNbwN+E knUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695878754; x=1696483554; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYQSq7QHiuiyS0dR9XMV5Ksd5EKV/hFTK+3dgExQusQ=; b=euQABHFbuN7j5d3idv2zECcHGPqRbtVC6W590hr6ntJEw/OXa3kIvfamLXwZtGACd1 zzpSAZNnwi8jWwXXdlKSYs4PmsNKahojtULXONH5csN8WnjbI9D+pK5MLQiLHc2JOLD/ S82JGQPfP1fgut7akrsHJnGJrKOahUiQChUTZdW1am3zrptXKQyKaTSpsjYwDJHZEQ+b /lKEtfspHp50UbVRHI/4awWSeIkOKl3RVvQNPIc1HxlayL2fhpxuxLTLTiB4B98tAOZi 2EYUv5bNldxE3fbx04lkPWaqSV+hB2KjWU1KDIKx1Ux6S2kGmtnNQQ5GRfe5ecoJSsnz EBUA== X-Gm-Message-State: AOJu0YwPvdHE/cY8z16ve/eMHQVCdQrqJMT45qBADVdjlVI89swZ5Lmr C40xIIQcxmBS2gXSs9Ys6ojhsA== X-Received: by 2002:a17:907:778d:b0:9ae:3ee3:1f59 with SMTP id ky13-20020a170907778d00b009ae3ee31f59mr227125ejc.13.1695878754001; Wed, 27 Sep 2023 22:25:54 -0700 (PDT) Received: from [192.168.1.235] (host-87-4-82-94.retail.telecomitalia.it. [87.4.82.94]) by smtp.gmail.com with ESMTPSA id lz1-20020a170906fb0100b0099297782aa9sm10230778ejb.49.2023.09.27.22.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 22:25:53 -0700 (PDT) Message-ID: <3d15a1a1-d47e-49ad-9491-1ac95f68bc64@linaro.org> Date: Thu, 28 Sep 2023 07:25:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] input: Imagis: add support for the IST3032C touchscreen Content-Language: en-US To: Karel Balej , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Markuss Broks , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht References: <20230926173531.18715-1-balejk@matfyz.cz> <20230926173531.18715-3-balejk@matfyz.cz> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20230926173531.18715-3-balejk@matfyz.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 22:26:11 -0700 (PDT) On 26/09/2023 19:35, Karel Balej wrote: > The downstream driver sets the regulator voltage to 3.1 V. Without this, > the touchscreen generates random touches even after it is no longer > being touched. It is unknown whether the same problem appears with other > chips of the IST30**C series. > > Co-developed-by: Duje Mihanović > Signed-off-by: Duje Mihanović > Signed-off-by: Karel Balej > --- > .../bindings/input/touchscreen/imagis,ist30xxc.yaml | 1 + Bindings are always separate patches. Always. Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof