Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3285623rdh; Thu, 28 Sep 2023 07:42:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIFPr2JdC4PefDsXfrNGyv+pxWoIkQGLFrSzm4B1BbMpQAEDZyErYdn7svEyV1Q2s5Cq91 X-Received: by 2002:a54:4809:0:b0:3ae:108c:57b3 with SMTP id j9-20020a544809000000b003ae108c57b3mr1463115oij.39.1695912134414; Thu, 28 Sep 2023 07:42:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695912134; cv=none; d=google.com; s=arc-20160816; b=mhWVWAtqwrPu7v8pKpI1akEn9thFwVajMSz78NNnn1UMtnrhEYHzX/qCNq/bRSF2Pr YVHUCzgKPDjU4qMSTY3oxju58xchTAsR7W926gEEDaDWJY6iskNzBxQzMb6eV+/A8RLX 3l1Xu44Xwv5zQSs8raPwuvh55an7edMtfPeObTmeNBVapoiR0Uj4b+wAbAsrdHoB5Q6e isS+Gh1g1YMeU3k13+ffEXtuWg5Lh/OmKoAP+ztZUAVMAQPARjiLaQ676Zk4okc2XOrg Y8JubmuRCoTAjQysC+pyD8ZZ0Jt143DMOLSBa2HbOd5caNmAw4V8hlResNpFVygiO8fz jlEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=XjyoWJ1tpx/uEpVSCmTksL+kF4CTyeGA4CWSET/lKz0=; fh=CoatFLHyK45TuYHhngEX1JzPWNkl+7cr69Q9pKxo4w0=; b=HfXATS332OxeznEWluzlohYtOGL2VDV7sAIWD1LRA91JQPEkFzOnKFeU3UUfqsHl4F TwH9O+RfLyN8OukeSSoBhRY/RSuymrvjm+NAzfGQuGB1VxYm3k7tMNlRqcfT3jFXDnXT 7Tog50tnvkgJv5ACvJY5Bvd4aKowDlpMCCcEb4h3IQX9SlOSOMltZma1jK8K2on8bjTg 6zr/z2eOy3MLee0KNIio4EpLQAAEBewRtWgStO3Q/fHpe/qyQ3HXrk1fNYphZfbdS7he It64k7RHGRUeftB+Kr0bv8n8PYPNNQ74jykAdEQKdHQU337xx8FHDMlDqh0ajfHrfAYO O7dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=HWmtgcdS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id ds12-20020a056a004acc00b0068e47f1fc7esi18861178pfb.159.2023.09.28.07.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 07:42:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=HWmtgcdS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4F69981C99B6; Thu, 28 Sep 2023 01:23:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjI1IXa (ORCPT + 99 others); Thu, 28 Sep 2023 04:23:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbjI1IX2 (ORCPT ); Thu, 28 Sep 2023 04:23:28 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2273418F for ; Thu, 28 Sep 2023 01:23:26 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5334f8a40e2so3000174a12.1 for ; Thu, 28 Sep 2023 01:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695889404; x=1696494204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XjyoWJ1tpx/uEpVSCmTksL+kF4CTyeGA4CWSET/lKz0=; b=HWmtgcdSxPUB9k4SIG12WzfmaNU8HpGSTDY3s+X0Q1j70bpT4Z4JxDiDkSubkPUiYJ oCL+NF6PG0RDW4JadTdiw6BquWCWa6zYpzbr1pW/wBEXFcJgaKGfvVKaLUleo0fou88T tBoj57jIvFMH+1JcRFB/1ifT0UOjxsS2qu+DI0qNJjj/06M81ydWRdb20DC9/0u0fnC7 YlCBnE3No5SdTU8ip9F34TePtGbMLlXsqpzkB9NnPY4KDkn7YtEXmS2j396VPLSlSSWs KHP3BGFKHPzXf+hWoRZfl4wmuqbZt0uZxH3qVla/dKRrioQCLb/owysuUtg4kq46oe8f Yw4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695889404; x=1696494204; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XjyoWJ1tpx/uEpVSCmTksL+kF4CTyeGA4CWSET/lKz0=; b=QJpNab8QDT3+XpoDbF03QjSCskBgYmlPO75HRPUQyfzOvYBjR9r4bxarQrJD+ID1Db sqz1t9ltBZLJkk8RLNQHp9HZJuOlHgRv8OrWNI/CVZQNGvYI/GE7dUtCZ+d/cz116bmX WVcsiD9x4mqoQBUdV1aiM9nQlsSamhB++s33fAIyQ586GPU6NMQ+aFWfJkOuQC3yT1Sv FgtL5/1oSVKFF7LnKeEc0UDRwl820FeHQpz2lLn+nP9BCKhkP4G+9wk2F4qYHwjAzy7O Se7Zld7oTWHeJ0/3zeF8enp3YSFL2VtDeBoHpvlSTajgUGXQYTz7ANjwmoP8zWPQ4Yl1 NEqw== X-Gm-Message-State: AOJu0YyD4YC82vIaKBnRPwwt5GbJtmop1lZ38gmylk/FAZUEok32MWIX o9e+RJysJDbGt6QxHY18Zko+dw== X-Received: by 2002:a05:6402:2808:b0:523:f69:9a0d with SMTP id h8-20020a056402280800b005230f699a0dmr583570ede.4.1695889404485; Thu, 28 Sep 2023 01:23:24 -0700 (PDT) Received: from [172.20.13.88] ([45.147.210.162]) by smtp.gmail.com with ESMTPSA id p17-20020aa7d311000000b00532bec5f768sm9345793edq.95.2023.09.28.01.23.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 01:23:23 -0700 (PDT) Message-ID: <84dd8b92-0b1a-4632-8e1f-33e4724e503a@kernel.dk> Date: Thu, 28 Sep 2023 02:23:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] IO_URING: Statistics of the true utilization of sq threads. Content-Language: en-US To: Peter Zijlstra , Xiaobing Li Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, asml.silence@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, kun.dou@samsung.com, peiwei.li@samsung.com, joshi.k@samsung.com, kundan.kumar@samsung.com, wenwen.chen@samsung.com, ruyi.zhang@samsung.com References: <20230928022228.15770-1-xiaobing.li@samsung.com> <20230928022228.15770-4-xiaobing.li@samsung.com> <20230928080114.GC9829@noisy.programming.kicks-ass.net> From: Jens Axboe In-Reply-To: <20230928080114.GC9829@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 28 Sep 2023 01:23:46 -0700 (PDT) On 9/28/23 2:01 AM, Peter Zijlstra wrote: > All of this is quite insane, but the above is actually broken. You're > using wall-time to measure runtime of a preemptible thread. Would have to agree with that... wall-time specifics aside, this whole thing seems to attempt to solve an issue quite the wrong way around. > Now, I see what you're trying to do, but who actually uses this data? This is the important question - and if you need this data, then why not just account it in sqpoll itself and have some way to export it? Let's please not implicate the core kernel bits for that. -- Jens Axboe