Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3297549rdh; Thu, 28 Sep 2023 07:58:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJSjto94MOvDFhDH9WW/N9CyhcVrXBmXybgI5XugwgNVnYis1ZDu95cBERBu5Fnl2HfKDj X-Received: by 2002:a17:903:41c7:b0:1c1:fe87:f550 with SMTP id u7-20020a17090341c700b001c1fe87f550mr1843329ple.7.1695913130439; Thu, 28 Sep 2023 07:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695913130; cv=none; d=google.com; s=arc-20160816; b=d/Kt+2XeIVXzOAGQX8AdMy8Rvy1cMQEoP8VRQdk+xBj+b87Skm74LNT5oTbqr4P+pB /WIYqeeVSH3eHkQ119iITb2CFlYuOw9d+NSQ8FbfiivkNV3ftYXkxJZYe//1toN0eK+x 4PdyCgmbd/rD6JuctIF5uceTv+TdCT76BCNvUcYEgYb30fk30wgINjbjelxeJuMMBwCD H5rd+2MBIxvumlRPjm/yjIB3L2lH/tgXvQTlWEhnPU8+f8wzcDcwY5v5tcim1GKzdlOS F3sxn1ijEjgh5bKzO8ihJOuMH6orO7jtOk0AablpQK64x9/snxfHU5oLGoJC0YnrjD70 M5+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a8zYVxz6+/lN4r34iMz9w+nBRdiZImEnlaobnfr0iy8=; fh=wYk28n3/Bmx+6DLvXni6WKwkZLaUGkz9ulYZ8wxwat0=; b=Ga9iYcEIQWwWNger13BEaKnwr0UuK0OfULol7fLsImPFOJ+1sUaY/Egte61rbeRDRh bLC5Fnd6dRtTbNPwcw1euV4yozs0E0G0/+3XXQDTJ+wqTwsxTYHkoyt1YKMRFyRO1Ndk eNyfZCqGLXG4VqJaQeH/kbIwhAxL/v0Exx7DTbB1GF/PMLcid2Gf1kFkqYrp5kXKxz2g tKuKpXTnLHM5ORm2uFFXCWS075NJ4N1HYAQiXY3Rlcz1uW4WpGfKw/kdaHUaoKtjBcho ZmfLT/TDUkd7Fqxqx45V1waY435OM4yTmaZ/O54IJPKQt08uHgBf5Ww3ZqVTmGReC/tS xXoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTVgTYHS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id le6-20020a170902fb0600b001c62b659f98si8218070plb.79.2023.09.28.07.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 07:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTVgTYHS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4A66380B79C0; Thu, 28 Sep 2023 07:52:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbjI1Ovr (ORCPT + 99 others); Thu, 28 Sep 2023 10:51:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231388AbjI1Ovm (ORCPT ); Thu, 28 Sep 2023 10:51:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 854061BF; Thu, 28 Sep 2023 07:51:35 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42EA2C433C8; Thu, 28 Sep 2023 14:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695912695; bh=ngdTCrwOUwR55XWtCbHA962yNGY14Ep1dAAyBjjxwQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTVgTYHSZ/4DohPeRJvnKEz4QGDirx/RUKg7f9vzVf96KqcyIsGEzI/+ijF9AUthp bWD2MMbUokoHk21y8A1E16Tctsy0lD0crrPFEucksYdsdb4zcxjAU42/8ZRYod34oV c1w1ke6DiVaSfK+6TEivFYAAGhCwwjM/cORRpSF9yWICf+mWnk5aBVRyVREIgiXAYf GEyU0yCuWA8Mqr9JPNWnVqOIG1/L6+iANcWKPALPRDjieFmYGj7CQ2p7sU3OeT4GEM jJ+6LrLbCaaPHqzypENARfRuokM3hUwwj1Xo30YVJqWB17R8n94sXj9KPwfccAsRAI hlLjYjW+wJeTw== Date: Thu, 28 Sep 2023 16:51:28 +0200 From: Andi Shyti To: Jian Zhang Cc: brendan.higgins@linux.dev, benh@kernel.crashing.org, joel@jms.id.au, andrew@aj.id.au, zhangjian3032@gmail.com, yulei.sh@bytedance.com, xiexinnan@bytedance.com, Tommy Huang , Wolfram Sang , "open list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list Subject: Re: [PATCH v2] i2c: aspeed: Fix i2c bus hang in slave read Message-ID: <20230928145128.tjflbgvena4apivs@zenone.zhora.eu> References: <20230927154244.3774670-1-zhangjian.3032@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927154244.3774670-1-zhangjian.3032@bytedance.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 07:52:01 -0700 (PDT) Hi Jian, On Wed, Sep 27, 2023 at 11:42:43PM +0800, Jian Zhang wrote: > When the `CONFIG_I2C_SLAVE` option is enabled and the device operates > as a slave, a situation arises where the master sends a START signal > without the accompanying STOP signal. This action results in a > persistent I2C bus timeout. The core issue stems from the fact that > the i2c controller remains in a slave read state without a timeout > mechanism. As a consequence, the bus perpetually experiences timeouts. > > In this case, the i2c bus will be reset, but the slave_state reset is > missing. > > Fixes: fee465150b45 ("i2c: aspeed: Reset the i2c controller when timeout occurs") > Signed-off-by: Jian Zhang Why I'm failing to find your v1 patch? And where is the changelog? Andi