Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 28 Sep 2023 10:03:30 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Inochi Amaoto <inochiama@outlook.com>
CC:     Conor Dooley <conor@kernel.org>, <aou@eecs.berkeley.edu>,
        <chao.wei@sophgo.com>, <devicetree@vger.kernel.org>,
        <emil.renner.berthing@canonical.com>, <guoren@kernel.org>,
        <jszhang@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
        <palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
        <robh+dt@kernel.org>, <xiaoguang.xing@sophgo.com>,
        Anup Patel <apatel@ventanamicro.com>,
        Chen Wang <wangchen20@iscas.ac.cn>
Subject: Re: [PATCH v3 06/11] dt-bindings: timer: Add Sophgo sg2042 CLINT
 timer
Message-ID: <20230928-winter-uranium-cc07496a49e3@wendy>
References: <20230928-bring-gnarly-05eeeb85f3c5@wendy>
 <IA1PR20MB49537BCE9EF342B55174B829BBC1A@IA1PR20MB4953.namprd20.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="b6mSgDjZ5Q8taV3j"
Content-Disposition: inline
In-Reply-To: <IA1PR20MB49537BCE9EF342B55174B829BBC1A@IA1PR20MB4953.namprd20.prod.outlook.com>
Precedence: bulk

--b6mSgDjZ5Q8taV3j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 28, 2023 at 04:24:54PM +0800, Inochi Amaoto wrote:
> >
> >On Thu, Sep 28, 2023 at 08:34:42AM +0800, Inochi Amaoto wrote:
> >
> >>>> +properties:
> >>>> +  compatible:
> >>>> +    oneOf:
> >>>> +      - items:
> >>>> +          - const: sophgo,sg2042-clint-mtimer
> >>>
> >>> There's only one of these, so you don't need the oneOf.
> >>
> >> Thanks
> >>
> >>> Also, is the clint here not a thead IP? In which case, you need to ad=
d a
> >>
> >> Yes, The clint is a thead IP, like that of th1520 and allwinner D1.
> >>
> >>> second compatible IMO. That second compatible then would be the one t=
hat
> >>> appears in opensbi etc.
> >>>
> >>
> >> As this is a thead IP, maybe use thead,c900-clint-mtimer is fine?
> >
> >I would suggest calling it -aclint-mtimer instead of clint-mtimer.
> >
>=20
> It is OK for me. As I describe below, now use sophgo as vendor is better.
> Anyway, I will add a new second one in the next patch.
>=20
> >> If so, whether we should replace the "thead,c900-clint" with these sep=
arate
> >> DT to describe the thead clint?
> >
> >No, since that's a different device, right?
> >
>=20
> Yes. It seems sophgo defined these by themselves, but the T-HEAD. Sorry
> for my mistake.

I'm sorry, I don't quite understand this. Do you mean that the IP is not
T-Head, but rather designed by Sophgo? If the IP is made by T-Head, then
I would expect to see something like

compatible =3D "sophgo,sg2042-aclint-mtimer", "thead,c900-aclint-mtimer";

in the dts.

>=20
> >> The DT binding said the thead clint is not
> >> compatible with the sifive clint, so maybe this is a chance to just mo=
ve
> >> them out.
> >
> >I don't think that it really makes sense to do that.

--b6mSgDjZ5Q8taV3j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRVBYgAKCRB4tDGHoIJi
0vLWAQCaVGggIAebDnmEiJzjw1X/RgLe0+aKKdWYxJ0fcufvIgD/QjEGmlfqom8m
pARBLjaCCUh5j/+WVtng9mGnCts03wA=
=pEic
-----END PGP SIGNATURE-----

--b6mSgDjZ5Q8taV3j--