Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3314000rdh; Thu, 28 Sep 2023 08:18:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKCa1WUXHxg9Q3JQ7kLyCLI4b39PH/kCbCMKMj0+PhFx8FU0naagYrHXCT+98lFQEEid8d X-Received: by 2002:a05:6a21:2702:b0:152:e902:8aa with SMTP id rm2-20020a056a21270200b00152e90208aamr1206597pzb.34.1695914286253; Thu, 28 Sep 2023 08:18:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695914286; cv=none; d=google.com; s=arc-20160816; b=gXuOhLWJvvQKxt6fphYZKY8xuiLTLTx4YufYiP468edC9706QRmnnyPMeRudxeJ3aU O9uHnnXf4A7+gqEnT1SliPFsN+JX+8TVzbXm6Ycy/solmHl4iG0TbwGoF6Hleg/bZ8Bi Ezl6mrt0HONOFR7mhHKY7cyfH00zUtS1882WwmhKxKgXdB4Q664LWm/8XAEbnnMITbG5 N7JyHbm0EwTili0EkfGvA/6GmY9RfW7vR2CgC00jiEk/oks0e6p4az4FAkDWV0Gvz2z/ 8kXcl/thYK9GCMby3wOv6RJQ71/CZDIELVdSkV3u88eUxRXxVV8sbDAIFl806HbuyYuL rzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; fh=nqhej2PsS2Bgtsjk82MDANcgSUbzpPRo0U4LNAslw5M=; b=SULt+7YouB42EYqhEYDZzty1cpzF33axfK19JvTkI7m51W6DvB22vBhcQ4+7KrdioU ZA2x6ie4Y9WbXYRYkQlDuCFXnhssbJfz2nxZ0epvezgitvibUXJtwbFg4CXy/PM5nSYS uOQCDYn6SxO7+l10SoshTtS6pjSOovS/X6cD7TBClh10ojE+Tvcup60hdgOGdiTct90m +WODPtA78Kt2ieBb7WeF+nszVaVCuAEtVDljOQhu4LJePCKwuIceGZUATwCryacrv/wL RRvHfL/Hge8yRWpSq/I7PMQFdIFkVPKNyjpMhVEG8aCVhv6zkcyTG95cvyd7BybmZ9mB ep7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YhZTZwcm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id u9-20020a056a00158900b0069100d1fc37si19974904pfk.49.2023.09.28.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 08:18:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YhZTZwcm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0D99A809B092; Thu, 28 Sep 2023 08:07:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231687AbjI1PGr (ORCPT + 99 others); Thu, 28 Sep 2023 11:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231828AbjI1PGl (ORCPT ); Thu, 28 Sep 2023 11:06:41 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D878CCD7 for ; Thu, 28 Sep 2023 08:06:38 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1c5bf7871dcso105298365ad.1 for ; Thu, 28 Sep 2023 08:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695913598; x=1696518398; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; b=YhZTZwcmFEbdHc+kXq6csoHQKmXWBVdwmKN2G7BNlX/Hfb0Bfq+22kDs3ywy5AIVAe eThQ+K6HmZeyevwIFTZTa8EoU0353YnLLJK5LY2z3TzOe6yEPc5PqpZNc2Eh984+ApLc 1QpktzjyUjpFZjnlpXMqHxsoK8Xhs9olQGYDiLueoUgAyBCuvTRcro7qNoOXy/XZv7N1 +9Lprypb+U7grw7XqCQz1YpBbSMlNPntmSG2PUb5RaOSI1I//fYow12CSDARxG+rk5fz 0rxz/NW1vbIPYqc4dW+cUK25o2AKYDniDIcRB8ejmxv9+AdqHQj6getDmam8QAYA2JQT xwww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695913598; x=1696518398; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IMmONcUMFN4joLAp8VT5Tk17MJvLEuHX0aR8+7SHQug=; b=Of4HnughcOoojXR/NjaQsOBUVlvPBxBbSWfaR7fR59p+H1MZ9bizbAJSwgvm6taYEt v0cpAiZhefuNH8W4taRDzUy84EVXCGxq4e77Sl13AwZ9kFAnO5elJAFVJBACtOmtlJfQ paw0zaY7vy3tygiT5WhWqlYKwJnqpbVYKBcKpZ95UrjxewzJ4aTgYBYJLbXhc4BP89hd nf60o2C01WbMYCJIcckDW8QHmFv5j0glkdM6JsNbJ0hqZ7L3JKCeB0VkdiYWfQpFK280 5x3ag5iuXDAu1mQ/MlxlMl3SQKsZUKjlpHsWPFb+GESn51pMhOkO1C7ygJ6EdcG8WHNs 1GJg== X-Gm-Message-State: AOJu0YwCx/OAwA9ygn6ZmpRTFIQLd3/mP0vwTDUHfV3u1IS4fpmOGLyW JJB+uRo8ZaB7LkvkSxyE1QvQk1wgygo= X-Received: by 2002:a17:902:f80a:b0:1c0:cb4d:df7c with SMTP id ix10-20020a170902f80a00b001c0cb4ddf7cmr1420658plb.1.1695913598188; Thu, 28 Sep 2023 08:06:38 -0700 (PDT) Received: from ubuntu.myguest.virtualbox.org ([122.162.35.36]) by smtp.gmail.com with ESMTPSA id w8-20020a1709029a8800b001b9f032bb3dsm15074659plp.3.2023.09.28.08.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 08:06:37 -0700 (PDT) Date: Thu, 28 Sep 2023 20:36:24 +0530 From: Pavan Bobba To: Forest Bond , Greg Kroah-Hartman , Michael Straube Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA" Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 08:07:17 -0700 (PDT) array name "abyBBVGA" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba --- drivers/staging/vt6655/baseband.c | 38 ++++++++++++++-------------- drivers/staging/vt6655/channel.c | 4 +-- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 8 +++--- 4 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 0ae2ab3987c6..a19a75f5d761 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -2016,10 +2016,10 @@ bool bb_vt3253_init(struct vnt_private *priv) iowrite32(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); } - priv->abyBBVGA[0] = 0x18; - priv->abyBBVGA[1] = 0x0A; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x18; + priv->bbvga[1] = 0x0A; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -50; priv->dbm_threshold[2] = 0; @@ -2034,10 +2034,10 @@ bool bb_vt3253_init(struct vnt_private *priv) result &= bb_write_embedded(priv, vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); - priv->abyBBVGA[0] = 0x1C; - priv->abyBBVGA[1] = 0x10; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x1C; + priv->bbvga[1] = 0x10; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -48; priv->dbm_threshold[2] = 0; @@ -2056,10 +2056,10 @@ bool bb_vt3253_init(struct vnt_private *priv) iowrite8(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); - priv->abyBBVGA[0] = 0x14; - priv->abyBBVGA[1] = 0x0A; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x14; + priv->bbvga[1] = 0x0A; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -60; priv->dbm_threshold[1] = -50; priv->dbm_threshold[2] = 0; @@ -2074,10 +2074,10 @@ bool bb_vt3253_init(struct vnt_private *priv) result &= bb_write_embedded(priv, vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); - priv->abyBBVGA[0] = 0x1C; - priv->abyBBVGA[1] = 0x10; - priv->abyBBVGA[2] = 0x0; - priv->abyBBVGA[3] = 0x0; + priv->bbvga[0] = 0x1C; + priv->bbvga[1] = 0x10; + priv->bbvga[2] = 0x0; + priv->bbvga[3] = 0x0; priv->dbm_threshold[0] = -70; priv->dbm_threshold[1] = -48; priv->dbm_threshold[2] = 0; @@ -2088,7 +2088,7 @@ bool bb_vt3253_init(struct vnt_private *priv) } else { /* No VGA Table now */ priv->bUpdateBBVGA = false; - priv->abyBBVGA[0] = 0x1C; + priv->bbvga[0] = 0x1C; } if (by_local_id > REV_ID_VT3253_A1) { @@ -2126,7 +2126,7 @@ bb_set_short_slot_time(struct vnt_private *priv) /* patch for 3253B0 Baseband with Cardbus module */ bb_read_embedded(priv, 0xE7, &by_bb_vga); - if (by_bb_vga == priv->abyBBVGA[0]) + if (by_bb_vga == priv->bbvga[0]) by_bb_rx_conf |= 0x20; /* 0010 0000 */ bb_write_embedded(priv, 0x0A, by_bb_rx_conf); /* CR10 */ @@ -2140,7 +2140,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data) bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */ /* patch for 3253B0 Baseband with Cardbus module */ - if (by_data == priv->abyBBVGA[0]) + if (by_data == priv->bbvga[0]) by_bb_rx_conf |= 0x20; /* 0010 0000 */ else if (priv->short_slot_time) by_bb_rx_conf &= 0xDF; /* 1101 1111 */ diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c index e90e0b43505d..e20701815db9 100644 --- a/drivers/staging/vt6655/channel.c +++ b/drivers/staging/vt6655/channel.c @@ -87,8 +87,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch) /* Set VGA to max sensitivity */ if (priv->bUpdateBBVGA && - priv->byBBVGACurrent != priv->abyBBVGA[0]) { - priv->byBBVGACurrent = priv->abyBBVGA[0]; + priv->byBBVGACurrent != priv->bbvga[0]) { + priv->byBBVGACurrent = priv->bbvga[0]; bb_set_vga_gain_offset(priv, priv->byBBVGACurrent); } diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index 8c90539cc3d7..b662c74a2dc7 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -250,7 +250,7 @@ struct vnt_private { unsigned int uBBVGADiffCount; unsigned char byBBVGANew; unsigned char byBBVGACurrent; - unsigned char abyBBVGA[BB_VGA_LEVEL]; + unsigned char bbvga[BB_VGA_LEVEL]; long dbm_threshold[BB_VGA_LEVEL]; unsigned char byBBPreEDRSSI; diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index f76f482f4c06..385848df8848 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -424,9 +424,9 @@ static void device_init_registers(struct vnt_private *priv) bb_vt3253_init(priv); if (priv->bUpdateBBVGA) { - priv->byBBVGACurrent = priv->abyBBVGA[0]; + priv->byBBVGACurrent = priv->bbvga[0]; priv->byBBVGANew = priv->byBBVGACurrent; - bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]); + bb_set_vga_gain_offset(priv, priv->bbvga[0]); } bb_set_rx_antenna_mode(priv, priv->byRxAntennaMode); @@ -1053,7 +1053,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv) for (i = 0; i < BB_VGA_LEVEL; i++) { if (dbm < priv->dbm_threshold[i]) { - priv->byBBVGANew = priv->abyBBVGA[i]; + priv->byBBVGANew = priv->bbvga[i]; break; } } @@ -1510,7 +1510,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, priv->short_slot_time = false; CARDbSetPhyParameter(priv, priv->byBBType); - bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]); + bb_set_vga_gain_offset(priv, priv->bbvga[0]); } if (changed & BSS_CHANGED_TXPOWER) -- 2.34.1