Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <cover.1695903065.git.geert+renesas@glider.be> <0f0eae276da4f8ed44cd1a15ffa138879d27b148.1695903065.git.geert+renesas@glider.be>
 <d9020d20-f512-42e6-8259-a7377c3d0d58@suse.de>
In-Reply-To: <d9020d20-f512-42e6-8259-a7377c3d0d58@suse.de>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 28 Sep 2023 17:32:02 +0200
Message-ID: <CAMuHMdUXnT61Hj8JwPenD+x_0-k_wU3bUtj8k9wh7Dd+kN4_Dw@mail.gmail.com>
Subject: Re: [PATCH/RFC 3/3] drm: Split drm_modeset_helper_vtables.h
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Thomas,

On Thu, Sep 28, 2023 at 3:59 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 28.09.23 um 14:16 schrieb Geert Uytterhoeven:
> > <drm/drm_modeset_helper_vtables.h> is the second largest header file in
> > the DRM subsystem, and declares helpers vtables for various DRM
> > components.  Several vtables contain methods with the same name, and all
> > but one vtable do not fit on the screen, making it hard to navigate to
> > the actual method one is interested in.
> >
> > Make it easier for the casual reviewer to keep track by splitting
> > <drm/drm_modeset_helper_vtables.h> in multiple header files, one per DRM
> > component.
>
> I never liked this header either, but do we need new header files? Each
> struct could be appended to the end of the regular header: struct
> drm_plane_helper_funcs to drm_plane.h, drm_connector_helper_func to
> drm_connector.h and so on.

That would work for me, too.  But perhaps we want to maintain a clear
separation between core and helpers?

Note that moving the contents to *_helper.h would be another option,
drm_crtc_helper.h and drm_plane_helper.h already exist.

> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > RFC, a future patch could replace inclusion of
> > <drm/drm_modeset_helper_vtables.h> by inclusion of one or more of the
> > new files, and reduce compilation time.
> > ---
> >   include/drm/drm_connector_helper_vtable.h   |  364 +++++
> >   include/drm/drm_crtc_helper_vtable.h        |  483 ++++++
> >   include/drm/drm_encoder_helper_vtable.h     |  381 +++++
> >   include/drm/drm_mode_config_helper_vtable.h |   97 ++
> >   include/drm/drm_modeset_helper_vtables.h    | 1466 +------------------
> >   include/drm/drm_plane_helper_vtable.h       |  297 ++++
> >   6 files changed, 1627 insertions(+), 1461 deletions(-)
> >   create mode 100644 include/drm/drm_connector_helper_vtable.h
> >   create mode 100644 include/drm/drm_crtc_helper_vtable.h
> >   create mode 100644 include/drm/drm_encoder_helper_vtable.h
> >   create mode 100644 include/drm/drm_mode_config_helper_vtable.h
> >   create mode 100644 include/drm/drm_plane_helper_vtable.h

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds