Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3342115rdh; Thu, 28 Sep 2023 08:58:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFd0+xGXsAcIVmPZjUO0Qm4Dlg6OfOWEoi7epRb8qfnrNPNqVJOT6hTqFq+Ph4fjZLpAQI X-Received: by 2002:a17:902:ee51:b0:1c5:c36b:e954 with SMTP id 17-20020a170902ee5100b001c5c36be954mr1645943plo.2.1695916703718; Thu, 28 Sep 2023 08:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695916703; cv=none; d=google.com; s=arc-20160816; b=gp/cwgPQiOgFATQ8ZYSuqR7IN0FFK2zx8bqm2fxNE/UGVDZzAG7jRqhECj5rW/r9PN G4RK+Ey1dH4Hmz0hBKKlcAJOYzZ5p02v1jdC5cC0vHIpc9UVNYAJveOZ/yHg0BIR13Pb U1GHKykhCrTcmK8END/IFQqPkFjbCPvR+KFzkJxK60xhh2A+fV8B6UN/0loJ4g7hWGWi KiPIDt/OjM0cxk1zSuOoVogL8aC68hak6a6tQI9p6LmvK+KspFNnh4DTTaFSJ1/uDKpk maiQNa/OHiaGJzwRomUgscXzB06NFZiV1oVXmHvNPNQsf2MaqTm7gxEgUsyJnJogwNgH HA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=4OOWmretAa7TcVqNXxB5c5DBUS1hZWMqm3G0yA3Bim4=; fh=79NMzyg5jWw1GC2ZsVvFItsiz02+VDawOkVE3uYKbzw=; b=KvnEIzYths3z9AWLmIPzn6s0G9soc1+8mUMs7p6TQKkUL5mlNWAkTZ9tKtWefVbkCz Wlr1uBGchLzDoLLCjkF/cTlGXrDKuZ0xb6jULguPYX9DpckicGbX9eANxUzWZClcIr4S VYnptWl8xBkjCcpj0NJMHxcJSEedOEWX2uDis85TtY7N/NISkR1ZtPZXkqtrUnqVPZOB JZo5okWmFBw2LvwxWBKrJNt9dM0+1GlBlt/iIDkwSuHDF9bdVkVKWO1MoRa+wkNy9XB/ 90lAt+7ZhzMR+pPehGBulUCXHHMDKo2rwj0HVhzYJTFTNA+00KWbxGUhytpeu/G0i5IK kt4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VzXi0RI/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id iz19-20020a170902ef9300b001b9be3b94dfsi17236241plb.268.2023.09.28.08.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 08:58:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VzXi0RI/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 45B9C823D9F1; Thu, 28 Sep 2023 06:48:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbjI1NsS (ORCPT + 99 others); Thu, 28 Sep 2023 09:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232286AbjI1NsR (ORCPT ); Thu, 28 Sep 2023 09:48:17 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B888136 for ; Thu, 28 Sep 2023 06:48:15 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40528376459so132807425e9.3 for ; Thu, 28 Sep 2023 06:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695908894; x=1696513694; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4OOWmretAa7TcVqNXxB5c5DBUS1hZWMqm3G0yA3Bim4=; b=VzXi0RI/+AgiIKw8LUAFxqj5zjZFSLvOWkvUZHitx4AZtw/8fhBaex0y4jwN5eF/hJ cLVLbGE5ey5X27vjhCIJzfY7xHgLzVHw9iYC/prQDr2AuAiFskphj66aQMiuXwe+8Tb5 kUPbdZT/iVRDgV059eRFAAwipRINX9p9kqFU3VjjhMwayIgkUTJFzkdmRJWdld1aaMgk wcczIsvjOQuCs9zn6IcVbQnm083WNEj+kSLC+JiHAe7cop7so+ZF6LYU3XiNqAea1mVw bNVmXtAsxtUTJ2c1ySpCXUV9Hv6kH5zp4yiajFJqAsy8DGveEN2tRUnk6rUF8VH9gvKl jCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695908894; x=1696513694; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4OOWmretAa7TcVqNXxB5c5DBUS1hZWMqm3G0yA3Bim4=; b=NLULg0wpdB34VtyQHyJ83r5wmm8yjUy4fwnNSWxxqeU+UhwepuqieyC/dbZhWeFdef ufobp69aqQ1gc12XoohkGeHsVKfAmmlf3j/SuCSM7j+bmuritAiJoS4Hl1jOYskMxH2F 2jWUyU0BvXb7J7+LhA5uD8B4aLlBEouXjYNTAYS6/phs0Ps1daH34XCLZ4MDakzyKtg+ K155c4r3uTPvgfJTX48Aby0T4w6exPDJh2FTyX3gYk7CpVn0MLMJwlPLL8HAia7VQzXi nvS5Cxm/fB0jFVc3pKN94/sX8yJsytZ1uckUvrX1q88hl4XV5w9JJ39V9lstNI7KavGz YDHA== X-Gm-Message-State: AOJu0YwZ5JR4LmFRqX729aBsdrcpF9LYTTtycLaNmeXP/zhvzMEUuUpp 1uGlyF8BSw1BDre8yb+ER+7DsA== X-Received: by 2002:a1c:7917:0:b0:406:4a32:1919 with SMTP id l23-20020a1c7917000000b004064a321919mr1319929wme.29.1695908893604; Thu, 28 Sep 2023 06:48:13 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0? ([2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0]) by smtp.googlemail.com with ESMTPSA id l17-20020a1c7911000000b00406408dc788sm4957831wme.44.2023.09.28.06.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 06:48:13 -0700 (PDT) Message-ID: <9b1be97e-b042-87d0-447a-9645c3039e59@linaro.org> Date: Thu, 28 Sep 2023 15:48:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] tools/thermal: remove unused 'mds' and 'nrhandler' variables Content-Language: en-US To: Kuan-Wei Chiu , rafael@kernel.org Cc: amitk@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <93c87b5c-ae8f-d27d-0342-faa884a3142e@linaro.org> <20230926173736.1142420-1-visitorckw@gmail.com> From: Daniel Lezcano In-Reply-To: <20230926173736.1142420-1-visitorckw@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 06:48:35 -0700 (PDT) On 26/09/2023 19:37, Kuan-Wei Chiu wrote: > In the previous code, the 'mds' and 'nrhandler' variables were not > utilized in the codebase. Additionally, there was a potential NULL > pointer dereference and memory leak due to improper handling of memory > reallocation failure. > > This patch removes the unused 'mds' and 'nrhandler' variables along with > the associated code, addressing the unused variable issue, NULL pointer > dereference issue and the memory leak issue. > > Signed-off-by: Kuan-Wei Chiu > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog