Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230920022644.2712651-1-jcmvbkbc@gmail.com> <20230920022644.2712651-2-jcmvbkbc@gmail.com>
 <2023092835-applied-shakable-f5dc@gregkh>
In-Reply-To: <2023092835-applied-shakable-f5dc@gregkh>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Thu, 28 Sep 2023 08:07:38 -0700
Message-ID: <CAMo8Bf+fKpvb5DgN3P847qKNxUa5Y3Q+e4AOikHGrhyZiDCWSQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] serial: core: tidy invalid baudrate handling in uart_get_baud_rate
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 28, 2023 at 1:17=E2=80=AFAM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 19, 2023 at 07:26:40PM -0700, Max Filippov wrote:
> > @@ -539,6 +537,7 @@ uart_get_divisor(struct uart_port *port, unsigned i=
nt baud)
> >  {
> >       unsigned int quot;
> >
> > +     WARN_ON(baud =3D=3D 0);
>
> Why is this needed?  If this isn't happening today, then there's no need
> to check for this here.

I'll drop it then.

--=20
Thanks.
-- Max