Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3374255rdh; Thu, 28 Sep 2023 09:44:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzYaCa/aeBvLpzOmkTVy0YR5gACk2AYfPEYXZWhTeRuMfORRvEQX1Au8UwuLLpqA1wWhs6 X-Received: by 2002:a05:6a20:7349:b0:15f:16f5:858e with SMTP id v9-20020a056a20734900b0015f16f5858emr1840511pzc.58.1695919489458; Thu, 28 Sep 2023 09:44:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695919489; cv=none; d=google.com; s=arc-20160816; b=JDIjFXv22ODO4/SCuo8UzUC3IsFJqu1oVTrTnIijlUXtSo566D80zesdhd4t/g0IDv 8TpK2UF/+DECRvvXTB3M/AixrRZXi4bqA0k0AlNNqS351kWOca8GoSDAFH3/JWpn7lfw E2MN11wFLCqOXbP8JDyfV/dBAMzpmG0/PHZLE/qRZti58BGBlokbxIpKRkt1c/YG+fwk SkDSCV+vUa9TdO10mw6s37Q7gpsPFCbjI5hXaUSvSQ+3gl18CVRhlEpNUxuWFeev8ktD EkhWUWXZEgImatwTz/pUO2ar5XJwShJyHD1AYBD3E0QKIZV6PuXpUli0JLBVZFkCHXPw hNEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kS8XZBKz28BBi3c9hikI+1lwQc5huSrdQqi8rvWTFeE=; fh=UMVCnV6+Gde6qAodH83OhGDkn76uaRHAGzw8tlfy+xM=; b=DfjKJ1ABeF1TM4ct0ThvWEEdZIAHMjJY64zWbV4lVbL+cvDzvE0TpjPiX5BMWQECLr bQ5ndzE0H0vlv9orBG49DatpgfNymzvnPm0GNERWPSFYxs54z8vPJCp1UTb+gGvc12OP egscJf6yXDNL+w8K1Kw2KR5JAtnrxN4dbBfD3EZzZ0zzJMFFwJRQsxRPIvXbDcz//5qI amm+TgcRRgW02FK2liY/TL/EES2Z3NA0MXIvgZLa0CyY2+6+cq7BjcsQ8zD/bBzGwvxf eFrnDae0C8Gh1xrbkoOVBRM2Qz/l7d4ozY4SL1AfTgDxZZDpRj0TOFmfMPyfD5S4bixw l9zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Izb656/I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id eb27-20020a056a004c9b00b00691019fd0efsi19474151pfb.75.2023.09.28.09.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 09:44:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Izb656/I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 43E31811246C; Thu, 28 Sep 2023 06:08:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbjI1NIX (ORCPT + 99 others); Thu, 28 Sep 2023 09:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232590AbjI1NIV (ORCPT ); Thu, 28 Sep 2023 09:08:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE4A819C; Thu, 28 Sep 2023 06:08:16 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 582FDC433C8; Thu, 28 Sep 2023 13:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695906496; bh=FgvrFkLj5yALBmEOjNK1KfhRZZ+9X76BFIOyFCpvUuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Izb656/IaNyoP69KH2Jadd3UbLfQ6FgPWbsbXin0u85ElT4sCrhpAguqFkYo7ICcY eKcKjc3AORwEnGZf+kyhQfyh4pICyZ0yb+QJhpqRz0yRXR+hou8eojCnqWqNTr68KG E8c6+NL5lN89WUQLCfvqpK8ZK+2Dhmobfq03r9Wk= Date: Thu, 28 Sep 2023 15:08:12 +0200 From: Greg KH To: Ekansh Gupta Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, ekangupt@qti.qualcomm.com, linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free Message-ID: <2023092840-balmy-proved-e337@gregkh> References: <1693463723-16937-1-git-send-email-quic_ekangupt@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1693463723-16937-1-git-send-email-quic_ekangupt@quicinc.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 28 Sep 2023 06:08:28 -0700 (PDT) On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote: > Metadata buffer is allocated during get_args for any remote call. > This buffer carries buffers, fdlists and other payload information > for the call. If the buffer is not reset, put_args might find some > garbage FDs in the fdlist which might have an existing mapping in > the list. This could result in improper freeing of FD map when DSP > might still be using the buffer. Added change to reset the metadata > buffer after allocation. > > Signed-off-by: Ekansh Gupta What commit id does this fix? And you sent 3 patches, but not in a list, what order are they to be applied in? thanks, greg k-h