Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3400616rdh; Thu, 28 Sep 2023 10:26:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4TJdM03Xode0zPDIumTwk39QDqyiAWW1TEQITuvl/0lROqX0kdT42P/D1GW8FHZt+Wg6e X-Received: by 2002:a17:90a:53a5:b0:276:757d:8c89 with SMTP id y34-20020a17090a53a500b00276757d8c89mr1719389pjh.44.1695921995440; Thu, 28 Sep 2023 10:26:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695921995; cv=none; d=google.com; s=arc-20160816; b=JgYyKOHIAmcolX+SFonq+ylIwU3hRLS0J7v4+nkUnkwildFXDC7S6ClzzjMG0RUg9i q3cEhXonsFBzjnpp5+wUl/e1bYII7B40vytss0+vu0vmnErMk3XPW7YACq1yn/BUE/lR kowCHBYBFzdDKO77JmWeUYto6ezOmx+9KcJqm/+3p+yxWvKW9DbWcxHw9IDGttzAFKIs vapISZ01Xj5yv3T8Iycyui+496rdXZvqFwiBWJhAwTzWS/YV0BwOjnk8eRzEI8Qa+QST MKOqhINmcRN27GXuL7A4yK4/BXf6QGZ13ZYvQV56zzjMPi6kIG5kssDeEMn2szy60t39 RUtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NfgEOxeSgPzf5YIzv2Gv1CuDr6cayB88kUGYz6CEoT8=; fh=UMVCnV6+Gde6qAodH83OhGDkn76uaRHAGzw8tlfy+xM=; b=KYXxPwoCQ87vZfNoerNgtELuJiWVbnbH2nNvorsfi4kULmotWdcYdGjamk8JcbadDd Z7J5ZNnrnWMCG0SUuAYco4C9Yk7x3YCPg2tBNvfTBtw1+iBexyadkQ6RDfJYfztg4G7e Zkz2aYmqpEzzxSDv3muINLc/w5SRR1ANUQUj46g5BtvpA0l8G9UFAu+fL9t0ohtdLEnA zWNXDv+5OFMa30C0ZdVLv1rRCYxGd5xlvbMX44BVX9Do//bwLJONOj7pmkc8q6jVrEbC fsEEtpXEEiH1ivxQLbq9mRQQvM4mpnoW1P7ifghBGxxlWOP846WvE0WlQg6diY51Qjig sy1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j9qGQZtT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id pf2-20020a17090b1d8200b0024e47fae466si10286162pjb.180.2023.09.28.10.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 10:26:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j9qGQZtT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 77B5881D55C2; Thu, 28 Sep 2023 06:07:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbjI1NHS (ORCPT + 99 others); Thu, 28 Sep 2023 09:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbjI1NHS (ORCPT ); Thu, 28 Sep 2023 09:07:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99FC6F5; Thu, 28 Sep 2023 06:07:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD351C433C7; Thu, 28 Sep 2023 13:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695906435; bh=NfgEOxeSgPzf5YIzv2Gv1CuDr6cayB88kUGYz6CEoT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j9qGQZtT27F4bLJfQGTzVRTpgQmwU0auqm5ddJJ36nLEvD0FbeO2NGSF5TGwafXOE sV013+2nOXvFmfxMEo0snHu0YZBCHArqkR8queAMk7R58itOnTWAV0ZtQwgHNJqnGr 9slhvm07FAfJ7GRN7EavZ5hqZuF0JG/Jq2hrKcJg= Date: Thu, 28 Sep 2023 15:07:11 +0200 From: Greg KH To: Ekansh Gupta Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, ekangupt@qti.qualcomm.com, linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com Subject: Re: [PATCH v3 1/5] misc: fastrpc: Add fastrpc multimode invoke request support Message-ID: <2023092840-rental-ascension-b062@gregkh> References: <1695206827-29446-1-git-send-email-quic_ekangupt@quicinc.com> <1695206827-29446-2-git-send-email-quic_ekangupt@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1695206827-29446-2-git-send-email-quic_ekangupt@quicinc.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 28 Sep 2023 06:07:39 -0700 (PDT) On Wed, Sep 20, 2023 at 04:17:03PM +0530, Ekansh Gupta wrote: > Multimode invocation request is intended to support multiple > different type of requests. This will include enhanced invoke > request to support CRC check and performance counter enablement. > This will also support few driver level user controllable > mechanisms like usage of shared context banks, wakelock support, > etc. This IOCTL is also added with the aim to support few > new fastrpc features like DSP PD notification framework, > DSP Signalling mechanism etc. I can't see where you are properly checking the reserved fields in your new ioctl structures, am I just missing that logic somewhere? thanks, greg k-h