Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 27 Sep 2023 11:27:39 +0200
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Luiz Capitulino <luizcap@amazon.com>
Cc:     tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        longman@redhat.com, kamalesh.babulal@oracle.com,
        lcapitulino@gmail.com
Subject: Re: [PATH v3] cgroup: add cgroup_favordynmods= command-line option
Message-ID: <hegunkr2yuuhxvqevza5qthqnhv66dmru2c2elfk3rl7rwycl5@levqk6gto7e5>
References: <20230926211617.42746-1-luizcap@amazon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mvxntxtnmhzpfusm"
Content-Disposition: inline
In-Reply-To: <20230926211617.42746-1-luizcap@amazon.com>
Precedence: bulk


--mvxntxtnmhzpfusm
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 26, 2023 at 09:16:17PM +0000, Luiz Capitulino <luizcap@amazon.c=
om> wrote:
> We have a need of using favordynmods with cgroup v1, which doesn't support
> changing mount flags during remount. Enabling CONFIG_CGROUP_FAVOR_DYNMODS=
 at
> build-time is not an option because we want to be able to selectively
> enable it for certain systems.
>=20
> This commit addresses this by introducing the cgroup_favordynmods=3D
> command-line option. This option works for both cgroup v1 and v2 and also
> allows for disabling favorynmods when the kernel built with
> CONFIG_CGROUP_FAVOR_DYNMODS=3Dy.
>=20
> Also, note that when cgroup_favordynmods=3Dtrue favordynmods is never
> disabled in cgroup_destroy_root().
>=20
> Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
> ---
>  .../admin-guide/kernel-parameters.txt          |  4 ++++
>  kernel/cgroup/cgroup.c                         | 18 ++++++++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)

Thanks,

Reviewed-by: Michal Koutn=FD <mkoutny@suse.com>


--mvxntxtnmhzpfusm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZRP1iQAKCRAGvrMr/1gc
jsr1AP4tFlDP1JxCkCQQQanb8dPX0P90i82rcOq6fKAF7PKMHQEAp3/0+E0VebU3
IxXBMCjqJvEx7hEhL5bygjmy8HOdsAM=
=e3lV
-----END PGP SIGNATURE-----

--mvxntxtnmhzpfusm--