Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Anders Larsen <al@alarsen.net>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 62/87] fs/qnx4: convert to new inode {a,m}time accessors
Date:   Thu, 28 Sep 2023 14:41:37 +0200
Message-ID: <3384318.5fSG56mABF@oscar>
In-Reply-To: <20230928110413.33032-61-jlayton@kernel.org>
References: <20230928110300.32891-1-jlayton@kernel.org> <20230928110413.33032-1-jlayton@kernel.org> <20230928110413.33032-61-jlayton@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On 2023-09-28 13:03 Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/qnx4/inode.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c
> index a7171f5532a1..6eb9bb369b57 100644
> --- a/fs/qnx4/inode.c
> +++ b/fs/qnx4/inode.c
> @@ -301,10 +301,8 @@ struct inode *qnx4_iget(struct super_block *sb,
> unsigned long ino) i_gid_write(inode,
> (gid_t)le16_to_cpu(raw_inode->di_gid));
>  	set_nlink(inode, le16_to_cpu(raw_inode->di_nlink));
>  	inode->i_size    = le32_to_cpu(raw_inode->di_size);
> -	inode->i_mtime.tv_sec   = le32_to_cpu(raw_inode->di_mtime);
> -	inode->i_mtime.tv_nsec = 0;
> -	inode->i_atime.tv_sec   = le32_to_cpu(raw_inode->di_atime);
> -	inode->i_atime.tv_nsec = 0;
> +	inode_set_mtime(inode, le32_to_cpu(raw_inode->di_mtime), 0);
> +	inode_set_atime(inode, le32_to_cpu(raw_inode->di_atime), 0);
>  	inode_set_ctime(inode, le32_to_cpu(raw_inode->di_ctime), 0);
>  	inode->i_blocks  = le32_to_cpu(raw_inode->di_first_xtnt.xtnt_size);

Acked-by: Anders Larsen <al@alarsen.net>