Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <4b13536d-a8e4-e1c8-c75b-914246651eaa@intel.com>
Date:   Thu, 28 Sep 2023 11:44:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 4/8] x86/resctrl: Add node-scope to the options for
 feature scope
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-5-tony.luck@intel.com>
 <5d93f726-bd43-20ad-5057-1de575809cde@intel.com>
 <ZRW69o0tNo2s8m+H@agluck-desk3>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZRW69o0tNo2s8m+H@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1M0SFliTVBqM0Fla0hQaUsxNm5rMjlVM0Z6Z1hvV3dtL3dSZzZSWUNrTTlW?=
 =?utf-8?B?ek90TnRWTkZiQ3R5UnVXOXJpeFdON1pVWXludVpmL0hIS1hDWDhEZGlKSHVD?=
 =?utf-8?B?RlM0ZlQrRWhsQk1nTmhYR3dIbmFHNk1vUisyd1U4bHVZVTdJdmt5dmNQSGVy?=
 =?utf-8?B?OE82Q0hPVUN2SVJraE9yaTBhVnNIZkJMdFUzc2ZqT1EyNjlLSkNLejFhV08x?=
 =?utf-8?B?aWM4T1dpYkpENm1jeG5mVmtSdG55UTlvaFkveEp6T1ZCVWNlNExZdWZlaTEw?=
 =?utf-8?B?cHZDNHFIUnd0TkwvREcwSzBXamNaNG55bW1jU3NsVkhmMzNXL3lFTis3VVBG?=
 =?utf-8?B?ZGtWdjVVL2VuMDZRTmlPK01xaFZXYVBXYWJoY2VsaHdVS0VLdlZtVEVNd2pj?=
 =?utf-8?B?Z1NsWFhTTmE0RkxmbFd0N2J6RU51N2xhQ0J1WUc5Z1RsYXZ6dmtHMDVuQnZW?=
 =?utf-8?B?VDkveU5lZ0hlbDhFQS9vVGFHeUR3UTQzNERrOWYxRFhVL0V5OWdvZTNzWktq?=
 =?utf-8?B?Rnp3WUJObE9FYXJ5TzVidWs5U3VXUjM2MHd0YXFRZWJCdEt5NUtpeU9uZnZN?=
 =?utf-8?B?T0ZFa2ZYMWlqekoxK1VWaktRditWL2luR3Awam9CUWZyb3l6L2NFTDgzMUh2?=
 =?utf-8?B?MnVnamplL0tiaklJVW42cjhxSmVKV3BVL3NUQkY3MTVWbi9uTUhFTTZkdGpq?=
 =?utf-8?B?dHJCeTFEZzRkUFVDcDNJNnBzcHFKUlZyRnM2ZUQveXFDcG5paGpPOEVzNXVp?=
 =?utf-8?B?SjdhdDVZMU80YWpnZXQ4TGtXcUQ2VFArQ2JFeXh5QjAvZ09Lb0EvOGIzM3cy?=
 =?utf-8?B?aU54MkI4TkZQOEJhV1ZBUzRFSkhPTlNOU21McGJOQmE2U0M4WHJaNHh0ZVA0?=
 =?utf-8?B?K1VabUxjMmdnS2EwYTZRa2RLTWN4WlhxMWZEZVlPenh6MG01Z3lZU0lqWW1v?=
 =?utf-8?B?dGcyT2lxcFF3T0ZzS1NNVnVMRlovREJqUHdlcVpad1BCL1JSUG9LZGVpNWdn?=
 =?utf-8?B?L1V2SEx0QzlOOXRhSDIwb1h4cnZRdzBEbDNpUHlXMkp1MHV3a3p4NzZBQ2RM?=
 =?utf-8?B?c3ZlaFZNZDBlOHJyQnIyZFNadHlkM28yUmtJWVZCRTBSdmRKT0tTQWlpTVRl?=
 =?utf-8?B?S2hhdG1MOG84dmpzN0ZQdmF2dm9iV001RE14cFdmVERPdTAxYXA1VmdtNGlN?=
 =?utf-8?B?eXA1V2FZd0pncWtjd2JpNlp2MDgvR0toZmNrMEQ5ckFxUWp0MTEzcEluSzZw?=
 =?utf-8?B?WVZVbnY0TFdveXNjOEt2THp0T2htQWE0Mnd0dHRNaFJ5U1QveldRVHFpMGNV?=
 =?utf-8?B?MmdJZVBqMFUwblpLTWJUaGNvZWhHK2d2a0pmUDZ4aW5aWTF1d0tma0Z4OVpR?=
 =?utf-8?B?OWhreE12VmVBOGp0Y3NNcHdCcEdlZHA0Z2JlUGVRNTZoV1lRUkYzTzE2UUl4?=
 =?utf-8?B?TWJOS1hjVGVTYTZub0taMkg0WnMrWGwwY0JOVFdzR3FNd3V6UHE0blRML2Fk?=
 =?utf-8?B?SXpxQzBRQzlJM3Z0K2Y0WWZKVURnSkpQeHpaRitvbVdaZWhkUGhyeUFGaU9a?=
 =?utf-8?B?VkpXdmJpUnNUNFZNVXJobXVZTDJsdnQzbFhjWk0vaWZJU1VaMklGb1RSN1g1?=
 =?utf-8?B?ZVJwMzNkMC9LTUZMQXN2WFY2YVJ5QTFieUszcVpCUGNwblduN2RYUWtQVnpC?=
 =?utf-8?B?Rkt5VEZqVmJnQUluYTBFc29meWd6Nm1tNXhicDJBMXpKZmhJYU1Iam5wRUZa?=
 =?utf-8?B?RjgzWVpYMTB6RGVNeXNWanhSTFhnWkxMZUhuSXVIQjVMZEZYdkZXQjloZEh0?=
 =?utf-8?B?MDVlVkFROUJpMVhiS0Fid3l3OUJzSzBkNDQ4Sjg2TTAwZG9aNXdNbEk1SFRM?=
 =?utf-8?B?OVYzTXY1V1hMUXBVemp3VWhvWWExeE0wK2ZMQVhjeDNVUHUwOVVqdWZaWXZ0?=
 =?utf-8?B?ZUVCTmpxeWphMzZrSUZsQ21WZEtMWWgxS2lLenJiL0czMmFXZmd6Q09PbUl0?=
 =?utf-8?B?aE4xeXZzTUkvTVNFaklZbTZKbU1QQWpXWFd0U2tkUmxTZUFLNjdva0tHd1k2?=
 =?utf-8?B?OU9OUU9IdzVpdXA0RGhxYTdWaVROK2NnR1MvZzJVSXFMd3RsNmdHYis4eUt2?=
 =?utf-8?B?QnNGYkxnVFBYUm4rdkQ1bXhkWksyN2l2VTkrYmNmRERTT2dEQmZrWkpEMEZY?=
 =?utf-8?B?bWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c08ce969-56d3-4483-822a-08dbc052f6fd
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 18:44:36.7992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ht/sPx29IPI8XpCF05RQoq9cTA1ByaJTCDtLdOBMPv7BmtXG6tgNL62U+EKt3dJQHegcv6xaqfG0KTe4k5xDCnZa7du4/2nnxkbw088Uf2k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6816
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 28 Sep 2023 11:53:02 -0700 (PDT)

Hi Tony,

On 9/28/2023 10:42 AM, Tony Luck wrote:
> On Mon, Sep 25, 2023 at 04:25:54PM -0700, Reinette Chatre wrote:
>> Hi Tony,
>>
>> On 8/29/2023 4:44 PM, Tony Luck wrote:
>>> Currently supported resctrl features are all domain scoped the same as the
>>> scope of the L2 or L3 caches.
>>
>> fyi ... this patch series seems to use the terms "resctrl feature"
>> and "resctrl resource" interchangeably and it is not always clear
>> if the terms mean something different.
> 
> I think a "resctrl feature" is a h/w control or monitor feature. A
> "resctrl resource" is "struct rdt_resource" (which may have more than
> one "resctrl feature" attached to it. E.g. the RDT_RESOURCE_L3 resource
> has L3 CAT, MBM, CQM attached).

Please keep in mind that in resctrl documentation
(Documentation/arch/x86/resctrl.rst) L3_MON is described as 
a resource. The main message is just to ensure that it is clear
what is meant with particular terms and then be consistent in
their use.

Reinette