Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <a5fbcf09-2445-28f1-4113-0de4f72b7f90@intel.com>
Date:   Thu, 28 Sep 2023 06:40:18 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3] x86/bugs: Add a separate config for each mitigation
Content-Language: en-US
To:     Breno Leitao <leitao@debian.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc:     leit@meta.com,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
References: <20230628142129.2468174-1-leitao@debian.org>
 <ZRV1bIuSXjZ+uPKB@gmail.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <ZRV1bIuSXjZ+uPKB@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/28/23 05:45, Breno Leitao wrote:
> 1) Create one Kconfig entry per mitigation, so, the user can pick and
> choose what to enable and disable. (Version 3 of this patch. May need a
> re-spin due to the new mitigations being added.)

This means, what, roughly 18 today?

#define X86_BUG_CPU_MELTDOWN		X86_BUG(14)
...
#define X86_BUG_GDS                     X86_BUG(30)

Plus two bonus ones:

#define X86_BUG_SRSO                    X86_BUG(1*32 + 0)
#define X86_BUG_DIV0                    X86_BUG(1*32 + 1)

... and we've slowed down the rate at which we're adding these, but
we're still seeing a couple a year.

Perhaps Pawan and the others actually _doing_ the patches for these can
speak up, but I don't think adding a Kconfig option will be too much
additional work for each new X86_BUG.

I still think it's highly unlikely that someone will come through and
pick and choose among a few dozen vulnerabilities.