Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <4b906b98-b535-e203-ffa7-6f6a34d6c54e@intel.com>
Date:   Thu, 28 Sep 2023 11:42:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 3/8] x86/resctrl: Split the rdt_domain structure
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-4-tony.luck@intel.com>
 <5f1256d3-737e-a447-abbe-f541767b2c8f@intel.com>
 <ZRW4zRZtgZ0cdzqC@agluck-desk3>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZRW4zRZtgZ0cdzqC@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzdXakhZZ3ZYc0lOM2w0R3hTU2RNQU9RWHpkbEtpWEFDT0xDL2k2WlhHaVhm?=
 =?utf-8?B?SVE1NEluSEowV1RVemg0NXZ1TjZrMlRYK2VlSU1GNVo3QlA3eXBKQ2NoQVF4?=
 =?utf-8?B?a2ZXZ3RMUnNVVzhCVUc1TUVGVlJPM0tyTzNVdWpGVGF0NDhBRzhDNDNDN1pM?=
 =?utf-8?B?SHczM0xSRlhlV014SGJScVFnVXRrY01rbnlWV1hLL0tZWXdSdi9YQ3ZRY2xr?=
 =?utf-8?B?UDdueE5IMnBEaktrTG1Yb1lLdEFZdXhtVEU5dTgxVmlaUVo3Tm95ay9RM2dp?=
 =?utf-8?B?WU5iWEZkVFpYWXh6d3k0NkdNdVlMeEptRTNkQWIySW9kSmh1ZEZYWDh2VVlO?=
 =?utf-8?B?Rm1DZkdmOFo1Q3l1QlZ2aXE5RGltczYzY3FDQ2dMRC9WWEJvaFVNK0ZGcXlH?=
 =?utf-8?B?SnlBYmdBR3kxaFZuZitwSTNzNjZTbVBmZDB0ZWk2MHR1V2hqM0QxdG44Qkp0?=
 =?utf-8?B?dWljWm1TUjVXZ1Z5dXRzSG5RbTV4TDBNRUttOXNhcHkyUGxRR04zM3BlZFY0?=
 =?utf-8?B?b1g4Y1hldlRJWVpPbjh0bkFjRWFDMC9BOFovSW5OOEFiWndaL09Ud3BGdEhY?=
 =?utf-8?B?VnVQZTdzelJGZkNKT1YyWTh4UG15dVFXV0Z2aytiU01rOTlVS3A0K3hhNTIr?=
 =?utf-8?B?V1NnUTlCY2VOU3J2TXBpZldWazR6RndVRlNVaTk3RUg5SXE0amZWNmRpRnJD?=
 =?utf-8?B?cldmVmN0MUZtMkRpb0tqVWtEWnVoVG16cHhsL1dwUjJTODdOL05pY0R0ZHNj?=
 =?utf-8?B?U0tLSU9sUWxEbXZpN3RKa0RHNk5HVjZlSFBwME9UUjhRNmFBY25TakZEYUg2?=
 =?utf-8?B?ZFhYUHhLL0xNbTl5aWFpaVZub0JjUmk2bkR6WlF0dUo3MmM4NU01dUN3MkdR?=
 =?utf-8?B?RzdYTDR5bTNuUlYxUlFLOHIySzdjcWowTHlrVUcvSDFvTHBrN053RGMyKzZ4?=
 =?utf-8?B?NXdaWGFIUm4vSk8wakJyazcvUlN2clpFazlQb2s5NGFjY05pb0VkVFlHZkYx?=
 =?utf-8?B?VEViZmRTcXhDbk9pckw2eUh5cDhkS1UrUzVCdWhZTVMrNjhNRi9xaSthU0pz?=
 =?utf-8?B?UVhuc29raHZKUWtLNDZkalRtTEh0S2xBMDduaU1KdEVuSVcrRGlMRTNDRHg5?=
 =?utf-8?B?Q3NXK3ZaVWR4ek92elY2USt2RG51eXU3eENBTFVPOERBZngxdGMwcTRDWHg2?=
 =?utf-8?B?Mm45YkUyNmk0OExDVm1pR1hBeE9hVURWckxZRXFtOVpGV2psRDZsYlNqZnJC?=
 =?utf-8?B?ekxRbDRrODBGUFE0LzIxMmE1Q2lndmdmN2ozSEVSOGRvV3RWamh6bnA2bXE3?=
 =?utf-8?B?eElvS29xaGhtKzdnODNCN0VlTmN0dlAwZzVkUXlMSmttM0p6VmhGYkVVV1V3?=
 =?utf-8?B?T1pxMDZrajRQSUFOOHZZc3hFY3VPVThtVFJpbzJ2NGE4YWdzZzBiRTcvRW9V?=
 =?utf-8?B?MTlWQXRBWERDZjYyaE1lOUhKRmJKYTJJcDBBSytlb3dieGFDTlhuUWt4R1NU?=
 =?utf-8?B?bmtKdTR5UlVLbEVaaTdWOFRiVUNQTTNyUXdTUzRDWHFFa3dJWFhaVFJJb05a?=
 =?utf-8?B?SmdrY01yc1g0UnRmTmRBSkRZYXI3dFlhUmxvYTdUdEFWYmIvK2NTQkY0NTln?=
 =?utf-8?B?bnJzeGxsTUFvbExrTXdabHA4UmFzaWovM3k2SHc2ZDEzaWJiVGlGdHJETlQv?=
 =?utf-8?B?UFFSb2pBOHJsMnhaUEduVWVLZ3ZycGJpd3RhU2x5UlpnWEtRUXYxWWhEdU9h?=
 =?utf-8?B?MW1VTC9uRUQxOFoxVXREbzFMRkd1SEZmQVFSY1Q2c1VodHlwM0ZzdDJSbElB?=
 =?utf-8?B?c1czdEcrdThEZXpLY09iT1JHY3M3OGNLOHBsR01jNkkvQ0N6NUJvT2pqTVVw?=
 =?utf-8?B?SzBuMXhCcm1La2J3TEUyNzQxd0lKVFJHMTJZdzZzMjNaMlBwR2J0eHB2T1JI?=
 =?utf-8?B?S21vVmk5aFdKOWRxWmtna3kvRmpkWXozRXV5TExDMmlDRHM5Yjc4VWg0VFB6?=
 =?utf-8?B?VHdXMkhyM3M5Vjh4bnhCb25IWWFpa0xEaXZxQTdRLzhzZG0xNkYrUjBRZHJ4?=
 =?utf-8?B?dzVoWG5BOGFGcktVU09mcVlXQ2liWFJNaERROGN3WThlZU5WSm41c3UxZUo3?=
 =?utf-8?B?L3lNQy9zZmZha3dWOG05ei9nbUF1R0d6WURmVlJRNHpCNG1Xa0VnTmlZQ0ZK?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 52357b31-e592-42d2-cb86-08dbc052ae84
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 18:42:35.2239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7oRJXQ5pJkY82rUqDJ8IvTnYfQfE93YwEhFIQHQ6CcpvSAr5g70Br9VHa4UO2WJTSZTPRT612aT1O+ItV/DfmdFxRGLo2y7bb6oVMf26W4E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7056
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 11:51:22 -0700 (PDT)

Hi Tony,

On 9/28/2023 10:33 AM, Tony Luck wrote:
> On Mon, Sep 25, 2023 at 04:25:15PM -0700, Reinette Chatre wrote:
>>
>> On 8/29/2023 4:44 PM, Tony Luck wrote:

>>> Similar breakout of struct rdt_hw_mondomain from struct rdt_hw_domain.
>>
>> rdt_hw_mondomain and rdt_hw_ctrldomain?
> 
> Yes. rdt_hw_domain is split two ways and each gets an appropriate name.
> I added an extra "_" to match shape of other names. So these are now
> "rdt_hw_ctrl_domain" and "rdt_hw_mon_domain"

Thank you for adding the extra "_", it looks good.

...

>>> @@ -641,12 +641,12 @@ void cqm_handle_limbo(struct work_struct *work)
>>>  	unsigned long delay = msecs_to_jiffies(CQM_LIMBOCHECK_INTERVAL);
>>>  	int cpu = smp_processor_id();
>>>  	struct rdt_resource *r;
>>> -	struct rdt_domain *d;
>>> +	struct rdt_mondomain *d;
>>
>> Reverse fir (Please check all code).
> 
> Fixed. (I wrote a simple awk script to find these (as I'm
> obviously bad at noticing them). Included at end of this
> message).

Thank you very much for sharing your script. 


Reinette