Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 28 Sep 2023 22:48:00 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     jic23@kernel.org, andriy.shevchenko@linux.intel.com,
        lars@metafoo.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] iio: imu: Add driver for BMI323 IMU
Message-ID: <20230928204800.tlsauorjk6iz5r7f@pengutronix.de>
References: <20230918080314.11959-1-jagathjog1996@gmail.com>
 <20230918080314.11959-3-jagathjog1996@gmail.com>
 <20230927095708.l57kmdc3mmrtaco7@pengutronix.de>
 <CAM+2EuKb9-Wc+HAmsmPfmdM49k=7yoXboDF+swaMS_bgXbCOQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gahfz3hanrircdwo"
Content-Disposition: inline
In-Reply-To: <CAM+2EuKb9-Wc+HAmsmPfmdM49k=7yoXboDF+swaMS_bgXbCOQA@mail.gmail.com>
Precedence: bulk


--gahfz3hanrircdwo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 28, 2023 at 11:49:01PM +0530, Jagath Jog J wrote:
> Hi Uwe Kleine-K=C3=B6nig,
>=20
> On Wed, Sep 27, 2023 at 3:27=E2=80=AFPM Uwe Kleine-K=C3=B6nig
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > Hello,
> >
> > On Mon, Sep 18, 2023 at 01:33:14PM +0530, Jagath Jog J wrote:
> > > The Bosch BMI323 is a 6-axis low-power IMU that provide measurements =
for
> > > acceleration, angular rate, and temperature. This sensor includes
> > > motion-triggered interrupt features, such as a step counter, tap dete=
ction,
> > > and activity/inactivity interrupt capabilities.
> > >
> > > The driver supports various functionalities, including data ready, FI=
FO
> > > data handling, and events such as tap detection, step counting, and
> > > activity interrupts
> > >
> > > Datasheet: https://www.bosch-sensortec.com/media/boschsensortec/downl=
oads/datasheets/bst-bmi323-ds000.pdf
> >
> > Maybe put this link better in the driver.
>=20
> Yes, if there are multiple commits on the driver, the datasheet
> link will move further down with the initial commit. I will add
> datasheet link in the driver.
>=20
> >
> > > +static struct i2c_driver bmi323_i2c_driver =3D {
> > > +     .driver =3D {
> > > +             .name =3D "bmi323",
> > > +             .of_match_table =3D bmi323_of_i2c_match,
> > > +     },
> > > +     .probe_new =3D bmi323_i2c_probe,
> > > +     .id_table =3D bmi323_i2c_ids,
> > > +};
> > > +module_i2c_driver(bmi323_i2c_driver);
> >
> > If you want to compile this driver after v6.6-rc2 (which includes
> > commit 5eb1e6e459cf ("i2c: Drop legacy callback .probe_new()")) better
> > use .probe here instead of .probe_new().
>=20
> Thanks for pointing it out.
> I switched to v6.6-rc3 and I will change to .probe.

Note that you can use .probe (with that prototype) already since
v6.3-rc2. So there is no hard requirement to go to v6.6-rc3.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--gahfz3hanrircdwo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUV5oAACgkQj4D7WH0S
/k4esgf7BLpFWcXJXdhUexxP4+lc7WqPmab2RU67NFt7RdHv88Da4TAqWR+H7oWD
KJ1C8M59Ko+CV2jwfyCsef5tHE7WYlVUQOZixU+It/DOOY0r9wTOgt1B+iYl7BF9
vlfKNolt5AAlWMbunLjot7h3/37+mXLV+5JWMOBu/pmo6R1FM8mduXVJ7mdSZfRj
hWDuGnfTysXg60mPgVhMfjGNRkgc5qfmt/ec4Cf9uznBKfm8SbtH1oy4Ucs+uGtl
WaqtKfNh+shFge+7maB/JUo/bur8IO90K+Tadf4Gfh9i71J3RZKBQZioiWlaAyAX
skxOOb/jTr0UPgpUqnuINOcaTDoQFA==
=QnTw
-----END PGP SIGNATURE-----

--gahfz3hanrircdwo--