Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Thu, 28 Sep 2023 20:07:04 +0200
Message-Id: <CVUR18U9FUME.XSF1MML0B1QN@gimli.ms.mff.cuni.cz>
Subject: Re: [PATCH 1/2] input: generalize the Imagis touchscreen driver
To:     "Markuss Broks" <markuss.broks@gmail.com>,
        "Karel Balej" <balejk@matfyz.cz>
From:   "Karel Balej" <karelb@gimli.ms.mff.cuni.cz>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Conor Dooley" <conor+dt@kernel.org>,
        <linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
        <~postmarketos/upstreaming@lists.sr.ht>,
        "Jeff LaBundy" <jeff@labundy.com>, <linmengbo0689@protonmail.com>
References: <7b9864bf-2aa6-4510-ad98-276fbfaadc30@gmail.com>
 <72e02837-9a82-4007-8ba2-fa05f3c17670@gmail.com>
In-Reply-To: <72e02837-9a82-4007-8ba2-fa05f3c17670@gmail.com>
Precedence: bulk

Hello, Markuss,

thank you for your response and please forgive that my original emails
didn't reach you - I am trying to see if I can get the SMTP server I use
for my primary address officially authorized to send emails in its name
so that Google does not reject them.

> To be fair, this driver should work with all Imagis3 chips, which could=
=20
> be a better name for it. However, I agree with Jeff here: the driver=20
> doesn't necessarily need renaming.

I will be sure to drop the renaming for v2.

> Additionally, there used to be my series [1] that generalized the=20
> driver, but it never got applied. I will re-send it. It introduces=20
> `struct imagis_properties`, which contains register addresses for the=20
> registers that we use to read the touch input. In your specific case, I=
=20
> believe it should be:
>
> static const struct imagis_properties imagis_3032c_data =3D
> {
> 	.interrupt_msg_cmd =3D IST3038C_REG_INTR_MESSAGE,
> 	.touch_coord_cmd =3D IST3038C_REG_TOUCH_COORD,
> 	.whoami_cmd =3D IST3038C_REG_CHIPID,
> 	.whoami_val =3D IST3032C_WHOAMI, /* change it to your whoami */
> };

I have come across your patch series and in fact my original experiments
were based on it. However I thought it was abandoned and decided not to
try to make any further generalizations to the driver for now, except
making it work with IST3032C. Should I then perhaps wait before your
series gets applied before sending v2 of my changes? Or should I send
you a patch on top of your series, where I would add the `struct
imagis_properties` for the IST3032C (which you surely could do yourself,
but I can at least test it with my device). Please let me know if and
how we should coordinate.

> As for the voltage set, I believe this does not belong in a kernel=20
> driver. You should set it in device-tree with `regulator-max-microvolt`=
=20
> and `regulator-min-microvolt`.

Please see my response to Jeff regarding this. I will be happy to hear
your thoughts on what I propose.

Kind regards,
K. B.