To: Max Asbock <masbock@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>, tglx@linutronix.de, mingo@redhat.com,
       hpa@zytor.com
Subject: Re: x86 32-bit machine check handler
From: Andi Kleen <andi@firstfloor.org>
References: <1194899975.9979.7.camel@w-amax.beaverton.ibm.com>
Date: Tue, 13 Nov 2007 15:15:47 +0100
In-Reply-To: <1194899975.9979.7.camel@w-amax.beaverton.ibm.com> (Max Asbock's message of "Mon\, 12 Nov 2007 12\:39\:35 -0800")
Message-ID: <p73abpiz0x8.fsf@bingen.suse.de>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1840
Lines: 40

Max Asbock <masbock@us.ibm.com> writes:

> Now that the 32-bit and 64-bit x86 machine check handlers live next to
> each other a certain asymmetry in functionality is apparent. Notably,
> the 64-bit machine check handler implements a timer that periodically
> polls for silent machine check errors and makes them accessible to user
> space through /dev/mcelog. 

Actually 32bit implements that too (non-fatal.c). But it misses some
of the more advanced functionality like AMD Threshold Interrupts.

> Are there reasons the x86 32-bit machine
> check handler couldn't do the same?

The 32bit machine check code has some serious design problems. The
best would be probably to just move 32bit over to the 64bit code too.  In
fact there was a patch to do that some time ago, but it ran into some
minor problems and was unfortunately never merged. But it would be the
right thing to do.

The only missing functionality on the 64bit side would be support for
old non IA compliant old machine checks like P5 or WinChip. One option
would be to simply drop them. AFAIK these CPUs don't really have
anywhere near usable machine check capability anyways so dropping it
would not make much difference. Or alternatively keep p5.c/winchip.c
around. But if you look at them they don't do much except simple
printk with not much information and printk in a machine check handler
is always wrong because it can deadlock. I personally would prefer
dropping.

And I think one or two K7 quirks are also missing on 64bit, but these
would be very easy to add. Other than that it should just work on
32bit CPUs.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/