Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3531136rdh; Thu, 28 Sep 2023 14:46:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgKuPAMuvlXPam0xnUqgZHuo36PdcSh+8PLRP1V2GYTZkRewKFJb+nAvIm5E+2iadjxxWC X-Received: by 2002:a05:6a21:7189:b0:15e:5e8c:e457 with SMTP id wq9-20020a056a21718900b0015e5e8ce457mr2245159pzb.24.1695937597021; Thu, 28 Sep 2023 14:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695937597; cv=none; d=google.com; s=arc-20160816; b=uEwyaLzcokr67DL9BSAuTcgRrqw39EsHS6jjaNmtArviC+o0v4E9Knchr/qZCQYmyK iBcUgVBJ2FmZnGwa0fBDQ0b9XEiDeu+Kk801duiQLWHRKp5CF530+wBqq4EE0DR2zVbT NULDXAIYnkQurp8la/Eq1Mq+5nWfjr4p66Ob9EOcqVaS1QM0d5qGj/JCGppRn+bhwqoW Yr5E2m62i+7Hkj+FyjjILvsj37LF6BY0sjv1yTv+/pfrFd6vBImCAwsvG2b6OoNukHa4 ikkPuyQV6Eil3mqjbzu4/s9gUmZ3Oe7k46oLAarTUOJGLnsYfNrYPFZ/SgOzeQPwOk3+ ilXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8/OGVEqmKZ+YrEmaYsT23Mong0SvETBYb//Qn3SwQyE=; fh=McWMhBXbZKPJudkA+aRuAP3u2dQeraI6k1jPJeJNhbk=; b=ZwOWEPtx8u6mWmCbkcLyPcYcl71xVy3cDuc7c3vyjupT4AsP/wKFPYf5WjzaASYWlP AQdTFnCjCRrQ/XtTWQINNUD0ylH44Y/aM9XqZLtpuiXUt8BJFrZkXYypUBFZo+Q6hwP8 u6a1dQBrR1aqoenknPZvlxzJtGxBWOmhsd7PMJpo1ShA8Lctcsm8TJ2lzVcbLaK7OlRf 07w7FA/XMCwqBMgRCwifDkeqzPRdkPHsWNKggcyFfhm/KF2JcjwvWxaxQGFhAiQGo7hf lgcQ7UBzBh4d12aXi/x14FfbzcUQZ9gGbn9vwgpnpToodQHv5Aw/SYBr1n7FMROERAjW M6Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="KKqEJg5/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y17-20020a170902cad100b001bd9c43c896si13563352pld.287.2023.09.28.14.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 14:46:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="KKqEJg5/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 14B2382E7501; Thu, 28 Sep 2023 10:25:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232019AbjI1RZs (ORCPT + 99 others); Thu, 28 Sep 2023 13:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbjI1RZf (ORCPT ); Thu, 28 Sep 2023 13:25:35 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A7C1AA for ; Thu, 28 Sep 2023 10:25:33 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9b2c5664cb4so29725066b.1 for ; Thu, 28 Sep 2023 10:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695921932; x=1696526732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8/OGVEqmKZ+YrEmaYsT23Mong0SvETBYb//Qn3SwQyE=; b=KKqEJg5/0J2pSzaW+ZhrOc7EXQeEHD4+ZX0czpHDEl2Akr6z2EyzfaY3gmvzTugV51 yT9gKDKV3F6sH1nBBqmN/eREyeyBM1B9tShvYz04j6lBTHtM+g/6eTJkUW/bXEoj8aEz xzA48gN1TZq7SPDGhqquMhbvLZaYP/7OzS8P4X8UczVzBXu7Z7tkklaO2LHtzO0dD0qf Ju3CGVwaA3JGw9HELFTRJ0dwxk9g/8YgqYjbJWlKN5kvUnoe9SkGMmx79kzklTs4pYNE uTE+7+osxZlAFdL6/wXQehY+aZOpMbXMUId2duKiF9zd56fgjWyGZxgojSe21EYCTu5X Fi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695921932; x=1696526732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8/OGVEqmKZ+YrEmaYsT23Mong0SvETBYb//Qn3SwQyE=; b=eedLCaKOUYbx/fBlaRJnpJYVOS7DMPJ0qweKoUagej++NDiWGP0l4TelsqkjRgfch1 Slu351J2zQhljMd86EXbnvw5hLPtx9pwsa0CDWbtbvlJ8GKdXTYEUeZmp2zvrR5dp1Oa ycuP+JzKGopoJuSrJ3MsO3oYlGjkmEknhGvWKXieLknMX2HSAWy+dSdtiOVcgAlTOWlr tK/nqo9kj9BB5jl7h7RWWmA+HeulMGlp6736o2pzVbK+sOgP9FkL1j9+511f4RNMERB2 vYX4Brne6noYw7PXJcy1X8wKfJIZIsiQG8d+aqcEoSx5rKyLJ5Gul+tOvaT12feBxMWE aDWg== X-Gm-Message-State: AOJu0YzgKP2w8WlOLKyXTuWFgJmWh3DkVhdN6pRfmTGHp/ABDN/qr/4K y+Mx8xOxJPptPb/+xIW8ftI8OA== X-Received: by 2002:a17:906:5352:b0:9a1:d79a:4190 with SMTP id j18-20020a170906535200b009a1d79a4190mr1460967ejo.2.1695921932053; Thu, 28 Sep 2023 10:25:32 -0700 (PDT) Received: from localhost.localdomain ([45.147.210.162]) by smtp.gmail.com with ESMTPSA id j17-20020a170906279100b0099329b3ab67sm11151788ejc.71.2023.09.28.10.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 10:25:31 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: peterz@infradead.org, andres@anarazel.de, tglx@linutronix.de, Jens Axboe Subject: [PATCH 6/8] futex: make futex_parse_waitv() available as a helper Date: Thu, 28 Sep 2023 11:25:15 -0600 Message-Id: <20230928172517.961093-7-axboe@kernel.dk> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230928172517.961093-1-axboe@kernel.dk> References: <20230928172517.961093-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 10:25:51 -0700 (PDT) To make it more generically useful, augment it with allowing the caller to pass in the wake handler and wake data. Convert the futex_waitv() syscall, passing in the default handlers. Signed-off-by: Jens Axboe --- kernel/futex/futex.h | 5 +++++ kernel/futex/syscalls.c | 16 +++++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h index 76f6c2e0f539..6b6a6b3da103 100644 --- a/kernel/futex/futex.h +++ b/kernel/futex/futex.h @@ -361,6 +361,11 @@ struct futex_vector { struct futex_q q; }; +extern int futex_parse_waitv(struct futex_vector *futexv, + struct futex_waitv __user *uwaitv, + unsigned int nr_futexes, futex_wake_fn *wake, + void *wake_data); + extern int futex_wait_multiple(struct futex_vector *vs, unsigned int count, struct hrtimer_sleeper *to); diff --git a/kernel/futex/syscalls.c b/kernel/futex/syscalls.c index 2b5cafdfdc50..4b6da9116aa6 100644 --- a/kernel/futex/syscalls.c +++ b/kernel/futex/syscalls.c @@ -184,12 +184,15 @@ SYSCALL_DEFINE6(futex, u32 __user *, uaddr, int, op, u32, val, * @futexv: Kernel side list of waiters to be filled * @uwaitv: Userspace list to be parsed * @nr_futexes: Length of futexv + * @wake: Wake to call when futex is woken + * @wake_data: Data for the wake handler * * Return: Error code on failure, 0 on success */ -static int futex_parse_waitv(struct futex_vector *futexv, - struct futex_waitv __user *uwaitv, - unsigned int nr_futexes) +int futex_parse_waitv(struct futex_vector *futexv, + struct futex_waitv __user *uwaitv, + unsigned int nr_futexes, futex_wake_fn *wake, + void *wake_data) { struct futex_waitv aux; unsigned int i; @@ -214,6 +217,8 @@ static int futex_parse_waitv(struct futex_vector *futexv, futexv[i].w.val = aux.val; futexv[i].w.uaddr = aux.uaddr; futexv[i].q = futex_q_init; + futexv[i].q.wake = wake; + futexv[i].q.wake_data = wake_data; } return 0; @@ -306,7 +311,8 @@ SYSCALL_DEFINE5(futex_waitv, struct futex_waitv __user *, waiters, goto destroy_timer; } - ret = futex_parse_waitv(futexv, waiters, nr_futexes); + ret = futex_parse_waitv(futexv, waiters, nr_futexes, futex_wake_mark, + NULL); if (!ret) ret = futex_wait_multiple(futexv, nr_futexes, timeout ? &to : NULL); @@ -421,7 +427,7 @@ SYSCALL_DEFINE4(futex_requeue, if (!waiters) return -EINVAL; - ret = futex_parse_waitv(futexes, waiters, 2); + ret = futex_parse_waitv(futexes, waiters, 2, futex_wake_mark, NULL); if (ret) return ret; -- 2.40.1