Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <a1eedcbb-3797-dc0a-918f-eea8a58bbf52@intel.com>
Date:   Thu, 28 Sep 2023 13:47:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v2 4/4] x86/resctrl: Rename arch_has_sparse_bitmaps
Content-Language: en-US
To:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
CC:     <linux-kernel@vger.kernel.org>
References: <cover.1695371055.git.maciej.wieczor-retman@intel.com>
 <e689caf9dbb7664c26515a980084b5f17cb0644e.1695371055.git.maciej.wieczor-retman@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <e689caf9dbb7664c26515a980084b5f17cb0644e.1695371055.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXNvNDRVMmFDOGNoOEgzWkd1WGIwK0IxZzlyOEVsWEVTUGtVOGFSV0toc0Zl?=
 =?utf-8?B?UlJYWWdZdUp6aHFlMTdCYkdndlVZTEVtdGZFN0Z5TFNIWTZrVnBaMldINy9U?=
 =?utf-8?B?N2F1bjdsVXlRSkNadENjZlgxNVFVTnQzZ2YzVDdJNW9jOEp5dU4zcWZIbXBt?=
 =?utf-8?B?Z2lPWjBGUWJ4SUkwS0JrVzhaZkhCZUIxNVpseDc2d083S3ZDNmFtN2VFeU9F?=
 =?utf-8?B?QlIyRWxId2tjR1BHU2ZHR3p4eUVTaXgyZzQ3b0ZOeEFMV3czVXZUTE1xTVFN?=
 =?utf-8?B?OHc3cXpWSy9xT3pJcWxReFdSQ1k5ZUMyTk5hbzdFZGVsTXVNZDVoaERxd3kz?=
 =?utf-8?B?aWZUQ0Z3ZnNGa20zTFdHSm9SRkNiVlJZYXdJVGFiSUtLdTNuSUcrMTZVVkpX?=
 =?utf-8?B?TkthRitjK3pxVkFWLzRMdmJOK3VPSDVKbml1OUVHUVJuSU4xMWRSZys1dzZ2?=
 =?utf-8?B?ejFwNmhlbFR1UklUOERsaTRNRXBTZFhuM0ZUV1VBeEs0VEU5eGpsSjZBVWkv?=
 =?utf-8?B?c0dScEJVdDlDZkt4Uy9nRi9ER2M5Z0JaczhadXdXUVFxeTVxTlhWVEFnL1pJ?=
 =?utf-8?B?MTRkZXR6MmRUS1lDVXZxOXVwcnJEV3J2UzBtNlZjSzVsZnZmaWNWV1RaUUF0?=
 =?utf-8?B?TnFiU0laMTE1R2tGRE5xNzJDTE1kTjN5OUZwNjdDcHAwRUF1bVh4SDVjTUJB?=
 =?utf-8?B?a1k5RGJOS2dBcHZuTHg3ZVNHak14cWdRcFVCd0R1SW1jYlJrc3NYekN5TWk0?=
 =?utf-8?B?M2F0SHBuTUo3VmRzeUtsL0dmTW8xL0I5WkJDb0p3U2tGQjhMQWluNXdJbFR6?=
 =?utf-8?B?SVZFK0FUOTEzT3dCQVBNVy92RWx4YWtLS0tqNnZ4dlpoWDVzb3VkSUVaSXlO?=
 =?utf-8?B?NEZIQXBONTZDY0RsYkhFQ2hwYUpQVlJHbENlRC9kSUV5OEN0a2h2VmRQVWRC?=
 =?utf-8?B?SHN0RGxVWGZEQmpIMjBKb3dieW9POHliYnI4OTRlMi9aSkc1QnFmdUpLUHZr?=
 =?utf-8?B?MjdzR2pFNE9jNHVTL3ZXNE9RNzR2ell1eVZtR3pPcmVHcE56Ujhnd0N4RW53?=
 =?utf-8?B?ZDNTbnZ2RFdaczZzcTdrcVgwTjNxWXJxbDRoUTQwWHlqNjB6TWMwTTlrM1pE?=
 =?utf-8?B?ei9tR2JPbnppZjNCWUFScUlSelN0VGRWY2xHUU1ydERQUzI5T1VtbEt0b3dS?=
 =?utf-8?B?MFRzUFc3TW5wTXppT0RUYXBFeEsyRGtTODg5aFkvcGs3ektwakJWb2w4SU9T?=
 =?utf-8?B?QWtYSndTcWxuYUgvNTVVbjExb0FNSWxSSjRYZ2F4L1hYWG9zb2I3YVFmdUNo?=
 =?utf-8?B?NlVNd1VObE1OenJqRkQzL0VQR3haVStTTTNwR3cxdnRONG9hR3k2ZnN6cDdS?=
 =?utf-8?B?ZE03dnJUekw2bTdhM05LRGhkZHpsRWtCSFR0NFdGQ002eGVxMkNwbW9HNmlH?=
 =?utf-8?B?QjJ5TUJoTmI4cGVqUDJWNzRETkRuYkcvU3BzMDBySXd3WEpXVVNnbWlQQUk0?=
 =?utf-8?B?TjVqSVA1QU83Y0VZY3oydDdTTVhWVkpzdnhXNUhVbUw4enM0TkdiOGdXMk5s?=
 =?utf-8?B?NG9qS1kwOEh1Y1o3N0VXMG1OZFZpampUcWRNV091UDNCUjhXcHlrNGpPVysw?=
 =?utf-8?B?T0dhZzdyQ1BGbUlHeGNOMitFZ0cvWW1iMnFHOU5Jc0srSnQrMXB3Y0w2NkN6?=
 =?utf-8?B?RU1jQXhtalY1ZE5EbUQvZVdqQjZDdHpEMzVmUUMreXBMTUZiR3ZQMzl4NER5?=
 =?utf-8?B?S3pBek1JRWJxbmNCOERWK04rbG1VZmtmdXJ4YW1RMWEyWng3TzhwM01IODFZ?=
 =?utf-8?B?USsvOGtTbmx4NW5aKytsc0tLM3ZucTVObWJMUlhacFVJZmFweDJFN21DeTVU?=
 =?utf-8?B?L3JNNjR4eTgwbzhwRGRmMDRGWjhNVGFuMXlIR2VFdUhOY3BGdDA5R1ZwMjRy?=
 =?utf-8?B?Nnc5WGdIQit0TDU2QUx2NEhoNlJZMWNLOTdDZEV4K3JoRUZ4UWpWb1l6MndL?=
 =?utf-8?B?V0ZNaDh0aXRGRklzNGlEQTd5Sy9mVTRnc0p0dTFIY0g1RXA5d3p4bkJsbGxy?=
 =?utf-8?B?MmxQNlFKcE1RNWtjMXZGQzZwTEF3Rkx1UDhLU25TMGpxTUdGcE4vUFExdGpC?=
 =?utf-8?B?cmthMzJ0cmE4c3dzZVp5V0NwSm82TVBVbUYvU3hXZ04xdXJ3U0k4ZWozWnJB?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0293a72f-2e37-4561-ec72-08dbc0642eb1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 20:47:51.6883
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V/yRjyjYwm2ck74DY5ghHg1BVcyAtKKc7DhPlA+Xl09YYKlGtTh07CleBvBpgoOhx6MpWjXr+ZOnI4t7+G3h+GzjfdAa5JKJ7EZJiglAWpk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7458
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 13:54:27 -0700 (PDT)

Hi Maciej

Could you please move this patch to the beginning of this series?
Having it in the end results in a lot of churn with significant
changes to new code introduced in this series. All this can be avoided
by providing a smaller patch at the beginning of the series.

On 9/22/2023 1:48 AM, Maciej Wieczor-Retman wrote:
> Both AMD and Intel documentations use capacity bitmasks terminology
> rather than capacity bitmaps. Also bitmask term is much more widely
> used inside x86 resctrl code.

Since resctrl is intended to support many architectures and Arm coming
soon (and they use bitmap) I do not think we should use the vendor's
language as a motivation. For me there are three reasons supporting the
rename:
* arch_has_sparse_bitmaps is the *only* instance in resctrl that uses
  the bitmap term for capacity bitmasks, all other parts of resctrl refers
  to it as a bitmask
* bitmask is the established term used in resctrl documentation
  (Documentation/arch/x86/resctrl.rst)
* bitmask is the term already exposed to user space via resctrl ("cbm_mask")

Finally, why do the rename as part of this work? This can be motivated
with something like:
	A later patch exposes the value of arch_has_sparse_bitmaps to
	user space via the existing term of a bitmask. Rename
	arch_has_sparse_bitmaps to arch_has_sparse_bitmasks to ensure 
	consistent terminology throughout resctrl.

> 
> Unify the naming convention by renaming arch_has_sparse_bitmaps struct
> member to arch_has_sparse_bitmasks.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---

...

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 8334eeacfec5..83c2cbf7136d 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -57,7 +57,7 @@ struct resctrl_staged_config {
>   * @list:		all instances of this resource
>   * @id:			unique id for this instance
>   * @cpu_mask:		which CPUs share this resource
> - * @rmid_busy_llc:	bitmap of which limbo RMIDs are above threshold
> + * @rmid_busy_llc:	bitmask of which limbo RMIDs are above threshold
>   * @mbm_total:		saved state for MBM total bandwidth
>   * @mbm_local:		saved state for MBM local bandwidth
>   * @mbm_over:		worker to periodically read MBM h/w counters

Please drop this hunk. rmid_busy_llc is indeed a bitmap.

Reinette